diff mbox

[OpenWrt-Devel] Add 'traceroute6' to busybox default features

Message ID 55E8182D.1060004@iki.fi
State Superseded
Delegated to: Hauke Mehrtens
Headers show

Commit Message

Hannu Nyman Sept. 3, 2015, 9:51 a.m. UTC 
This patch adds 'traceroute6' to the default features of Busybox.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
---

Reference to earlier discussion:
https://lists.openwrt.org/pipermail/openwrt-devel/2015-August/034828.html

On Sat Aug 1 16:47:02 CEST 2015 Felix Fietkau wrote:
 > On 2015-08-01 13:04, Bastian Bittorf wrote:
 > > i build it for ar71xx, and these are the numbers [bytes]:
 > >
 > > before:
 > > 359736 build_dir/target-mips_34kc_musl-1.1.10/busybox-1.23.2/busybox
 > > 208071 bin/ar71xx/packages/base/busybox_1.23.2-1_ar71xx.ipk
 > >
 > > after:
 > > 359884 build_dir/target-mips_34kc_musl-1.1.10/busybox-1.23.2/busybox
 > > 209115 bin/ar71xx/packages/base/busybox_1.23.2-1_ar71xx.ipk
 > >
 > > so it adds ~1k to the image. (strange that uncompressed ~148 bytes)
 > > it's as simple as adding CONFIG_BUSYBOX_CONFIG_TRACEROUTE6=y
 > > what do you think?
 > Feel free to send a patch.
 >
 > - Felix

Comments

Hauke Mehrtens Sept. 11, 2015, 7:06 p.m. UTC | #1 
On 09/03/2015 11:51 AM, Hannu Nyman wrote:
> This patch adds 'traceroute6' to the default features of Busybox.
> 
> Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
> ---
> 
> Reference to earlier discussion:
> https://lists.openwrt.org/pipermail/openwrt-devel/2015-August/034828.html
> 
> On Sat Aug 1 16:47:02 CEST 2015 Felix Fietkau wrote:
>> On 2015-08-01 13:04, Bastian Bittorf wrote:
>> > i build it for ar71xx, and these are the numbers [bytes]:
>> >
>> > before:
>> > 359736 build_dir/target-mips_34kc_musl-1.1.10/busybox-1.23.2/busybox
>> > 208071 bin/ar71xx/packages/base/busybox_1.23.2-1_ar71xx.ipk
>> >
>> > after:
>> > 359884 build_dir/target-mips_34kc_musl-1.1.10/busybox-1.23.2/busybox
>> > 209115 bin/ar71xx/packages/base/busybox_1.23.2-1_ar71xx.ipk
>> >
>> > so it adds ~1k to the image. (strange that uncompressed ~148 bytes)
>> > it's as simple as adding CONFIG_BUSYBOX_CONFIG_TRACEROUTE6=y
>> > what do you think?
>> Feel free to send a patch.
>>
>> - Felix

This already went into trunk with this commit:
https://dev.openwrt.org/changeset/46829

Hauke
diff mbox

Patch

Index: package/utils/busybox/Config-defaults.in
===================================================================
--- package/utils/busybox/Config-defaults.in	(revision 46773)
+++ package/utils/busybox/Config-defaults.in	(working copy)
@@ -2229,7 +2229,7 @@ 
 	default y
 config BUSYBOX_DEFAULT_TRACEROUTE6
 	bool
-	default n
+	default y
 config BUSYBOX_DEFAULT_FEATURE_TRACEROUTE_VERBOSE
 	bool
 	default y