diff mbox

[OpenWrt-Devel] extra configuration options for OpenVPN in init script

Message ID 55E061D4.1070204@tuxed.net
State Rejected
Headers show

Commit Message

François Kooman Aug. 28, 2015, 1:27 p.m. UTC 
Hi Mirko,

To accompany my patch to the OpenVPN configuration module for luci [0]
to support some extra fields here also the change to the OpenVPN init
script.

It adds the following fields:

tls_version_min
tls_version_max
key_direction

They are needed to support "eduVPN" [1]. The change here is not
depending on the change in [0] so can be done without any side effect.

Thanks in advance for your consideration.

Cheers,
François

[0] https://github.com/openwrt/luci/issues/436
[1] https://wiki.surfnet.nl/display/eduvpn/eduVPN

Comments

John Crispin Sept. 15, 2015, 5:20 a.m. UTC | #1 
On 28/08/2015 15:27, François Kooman wrote:
> Hi Mirko,
> 
> To accompany my patch to the OpenVPN configuration module for luci [0]
> to support some extra fields here also the change to the OpenVPN init
> script.
> 
> It adds the following fields:
> 
> tls_version_min
> tls_version_max
> key_direction
> 
> They are needed to support "eduVPN" [1]. The change here is not
> depending on the change in [0] so can be done without any side effect.
> 
> Thanks in advance for your consideration.
> 
> Cheers,
> François


Hi,

this package is maintained on github. please send a properly formatted
PR via github. also you patch is missing the SoB line and it is attached
and not inline.

John
François Kooman Sept. 15, 2015, 8:04 a.m. UTC | #2 
On 09/15/2015 07:20 AM, John Crispin wrote:
> this package is maintained on github. please send a properly formatted
> PR via github. also you patch is missing the SoB line and it is attached
> and not inline.

It seems the OpenVPN init script is not maintained in the packages [0]
repository on GitHub? It seems to be in the repo on git.openwrt.org [1].

Regards,
François

[0] https://github.com/openwrt/packages
[1]
http://git.openwrt.org/?p=openwrt.git;a=tree;f=package/network/services/openvpn
diff mbox

Patch

diff --git a/package/network/services/openvpn/files/openvpn.init b/package/network/services/openvpn/files/openvpn.init
index 861d0d6..6e331f2 100644
--- a/package/network/services/openvpn/files/openvpn.init
+++ b/package/network/services/openvpn/files/openvpn.init
@@ -121,7 +121,8 @@  start_instance() {
 		reneg_bytes reneg_pkts reneg_sec \
 		replay_persist replay_window resolv_retry route route_delay route_gateway \
 		route_metric route_up rport script_security secret server server_bridge setenv shaper sndbuf \
-		socks_proxy status status_version syslog tcp_queue_limit tls_auth \
+		socks_proxy status status_version syslog tcp_queue_limit tls_auth tls_version_min \
+		tls_version_max key_direction \
 		tls_cipher tls_remote tls_timeout tls_verify tmp_dir topology tran_window \
 		tun_mtu tun_mtu_extra txqueuelen user verb down push up \
 		ifconfig_ipv6 route_ipv6 server_ipv6 ifconfig_ipv6_pool ifconfig_ipv6_push iroute_ipv6