From patchwork Thu Apr 23 13:06:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Darbyshire-Bryant X-Patchwork-Id: 463947 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from arrakis.dune.hu (arrakis.dune.hu [78.24.191.176]) (using TLSv1.1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 60D2514011D for ; Thu, 23 Apr 2015 23:08:21 +1000 (AEST) Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 484C62801B5; Thu, 23 Apr 2015 15:07:07 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on arrakis.dune.hu X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.2 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 81434280463 for ; Thu, 23 Apr 2015 15:06:33 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 HELO_IP_IN_CL_SUBNET=-1.2 (check from: .darbyshire-bryant. - helo: .emea01-am1-obe.outbound.protection.outlook. - helo-domain: .outlook.) FROM/MX_MATCHES_HELO(DOMAIN)=-2; rate: -7.7 Received: from emea01-am1-obe.outbound.protection.outlook.com (mail-am1on0094.outbound.protection.outlook.com [157.56.112.94]) by arrakis.dune.hu (Postfix) with ESMTPS for ; Thu, 23 Apr 2015 15:06:12 +0200 (CEST) Authentication-Results: lists.openwrt.org; dkim=none (message not signed) header.d=none; Received: from [10.102.59.33] (109.159.227.69) by DB5PR07MB0936.eurprd07.prod.outlook.com (25.161.200.143) with Microsoft SMTP Server (TLS) id 15.1.148.15; Thu, 23 Apr 2015 13:07:01 +0000 Message-ID: <5538EE70.4080307@darbyshire-bryant.me.uk> Date: Thu, 23 Apr 2015 14:06:56 +0100 From: Kevin Darbyshire-Bryant User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Felix Fietkau , OpenWrt Development List References: <5538C4D5.9060808@darbyshire-bryant.me.uk> <5538E3F7.9000002@openwrt.org> In-Reply-To: <5538E3F7.9000002@openwrt.org> X-Originating-IP: [109.159.227.69] X-ClientProxiedBy: DB3PR05CA0021.eurprd05.prod.outlook.com (25.160.41.149) To DB5PR07MB0936.eurprd07.prod.outlook.com (25.161.200.143) X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR07MB0936; X-Forefront-Antispam-Report: BMV:1; SFV:NSPM; SFS:(10009020)(6049001)(6009001)(24454002)(54534003)(288314003)(479174004)(51704005)(377424004)(54356999)(76176999)(40100003)(92566002)(59896002)(77156002)(62966003)(64126003)(77096005)(65816999)(87266999)(50986999)(15975445007)(1720100001)(5001770100001)(5890100001)(86362001)(36756003)(575784001)(33656002)(42186005)(83506001)(19580405001)(19580395003)(74482002)(568964001)(46102003)(107886001)(84326002)(87976001)(4001350100001)(66066001)(512944002)(80316001)(65956001)(2950100001)(65806001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR07MB0936; H:[10.102.59.33]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5002010)(5005006); SRVR:DB5PR07MB0936; BCL:0; PCL:0; RULEID:; SRVR:DB5PR07MB0936; X-Forefront-PRVS: 0555EC8317 X-OriginatorOrg: darbyshire-bryant.me.uk X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2015 13:07:01.5975 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR07MB0936 Subject: Re: [OpenWrt-Devel] [PATCH] dnsmasq: Bump to dnsmasq2.73rc6 - resend X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" On 23/04/2015 13:22, Felix Fietkau wrote: > On 2015-04-23 12:09, Kevin Darbyshire-Bryant wrote: >> Bump dnsmasq to v2.73rc6 >> >> Remove 001-fix-crash-in-auth-code.patch & >> 200-fix-dhcpv6-solicit-handling.patch as now included upstream. >> >> Signed-off-by: Kevin Darbyshire-Bryant > The patch is line wrapped and does not apply. > > - Felix > Grrrr, stoopid Thunderbird! Hidden setting found. Sorry. Try this Felix. Bump dnsmasq to v2.73rc6 Remove 001-fix-crash-in-auth-code.patch & 200-fix-dhcpv6-solicit-handling.patch as now included upstream. Signed-off-by: Kevin Darbyshire-Bryant diff --git a/package/network/services/dnsmasq/Makefile b/package/network/services/dnsmasq/Makefile index 9c90e0f..c5d37a4 100644 --- a/package/network/services/dnsmasq/Makefile +++ b/package/network/services/dnsmasq/Makefile @@ -8,12 +8,14 @@ include $(TOPDIR)/rules.mk PKG_NAME:=dnsmasq -PKG_VERSION:=2.73rc4 -PKG_RELEASE:=2 - -PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz -PKG_SOURCE_URL:=http://thekelleys.org.uk/dnsmasq/release-candidates -PKG_MD5SUM:=24569c7605059aee175b1776201afa93 +PKG_VERSION:=2.73rc6 +PKG_RELEASE:=1 + +PKG_SOURCE_PROTO:=git +PKG_SOURCE_URL:=git://thekelleys.org.uk/dnsmasq.git +PKG_SOURCE_SUBDIR:=$(PKG_NAME)-$(PKG_VERSION) +PKG_SOURCE_VERSION:=b8f16556d36924cd8dc7663cb4129d7b1f3fc2be +PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION)-$(PKG_SOURCE_VERSION).tar.gz PKG_LICENSE:=GPL-2.0 PKG_LICENSE_FILES:=COPYING diff --git a/package/network/services/dnsmasq/patches/001-fix-crash-in-auth-code.patch b/package/network/services/dnsmasq/patches/001-fix-crash-in-auth-code.patch deleted file mode 100644 index 9cba0cc..0000000 --- a/package/network/services/dnsmasq/patches/001-fix-crash-in-auth-code.patch +++ /dev/null @@ -1,113 +0,0 @@ -From 38440b204db65f9be16c4c3daa7e991e4356f6ed Mon Sep 17 00:00:00 2001 -From: Simon Kelley -Date: Sun, 12 Apr 2015 21:52:47 +0100 -Subject: [PATCH] Fix crash in auth code with odd configuration. - ---- - CHANGELOG | 32 +++++++++++++++++++++----------- - src/auth.c | 13 ++++++++----- - 2 files changed, 29 insertions(+), 16 deletions(-) - -diff --git a/CHANGELOG b/CHANGELOG -index 9af6170..f2142c7 100644 ---- a/CHANGELOG -+++ b/CHANGELOG -@@ -68,18 +68,31 @@ version 2.73 - Fix broken DNSSEC validation of ECDSA signatures. - - Add --dnssec-timestamp option, which provides an automatic -- way to detect when the system time becomes valid after boot -- on systems without an RTC, whilst allowing DNS queries before the -- clock is valid so that NTP can run. Thanks to -- Kevin Darbyshire-Bryant for developing this idea. -+ way to detect when the system time becomes valid after -+ boot on systems without an RTC, whilst allowing DNS -+ queries before the clock is valid so that NTP can run. -+ Thanks to Kevin Darbyshire-Bryant for developing this idea. - - Add --tftp-no-fail option. Thanks to Stefan Tomanek for - the patch. - -- Fix crash caused by looking up servers.bind, CHAOS text record, -- when more than about five --servers= lines are in the dnsmasq -- config. This causes memory corruption which causes a crash later. -- Thanks to Matt Coddington for sterling work chasing this down. -+ Fix crash caused by looking up servers.bind, CHAOS text -+ record, when more than about five --servers= lines are -+ in the dnsmasq config. This causes memory corruption -+ which causes a crash later. Thanks to Matt Coddington for -+ sterling work chasing this down. -+ -+ Fix crash on receipt of certain malformed DNS requests. -+ Thanks to Nick Sampanis for spotting the problem. -+ -+ Fix crash in authoritative DNS code, if a .arpa zone -+ is declared as authoritative, and then a PTR query which -+ is not to be treated as authoritative arrived. Normally, -+ directly declaring .arpa zone as authoritative is not -+ done, so this crash wouldn't be seen. Instead the -+ relevant .arpa zone should be specified as a subnet -+ in the auth-zone declaration. Thanks to Johnny S. Lee -+ for the bugreport and initial patch. - - - version 2.72 -@@ -125,10 +138,7 @@ version 2.72 - Fix problem with --local-service option on big-endian platforms - Thanks to Richard Genoud for the patch. - -- Fix crash on receipt of certain malformed DNS requests. Thanks -- to Nick Sampanis for spotting the problem. - -- - version 2.71 - Subtle change to error handling to help DNSSEC validation - when servers fail to provide NODATA answers for -diff --git a/src/auth.c b/src/auth.c -index 15721e5..4a5c39f 100644 ---- a/src/auth.c -+++ b/src/auth.c -@@ -141,7 +141,7 @@ size_t answer_auth(struct dns_header *header, char *limit, size_t qlen, time_t n - for (zone = daemon->auth_zones; zone; zone = zone->next) - if ((subnet = find_subnet(zone, flag, &addr))) - break; -- -+ - if (!zone) - { - auth = 0; -@@ -186,7 +186,7 @@ size_t answer_auth(struct dns_header *header, char *limit, size_t qlen, time_t n - - if (intr) - { -- if (in_zone(zone, intr->name, NULL)) -+ if (local_query || in_zone(zone, intr->name, NULL)) - { - found = 1; - log_query(flag | F_REVERSE | F_CONFIG, intr->name, &addr, NULL); -@@ -208,8 +208,11 @@ size_t answer_auth(struct dns_header *header, char *limit, size_t qlen, time_t n - *p = 0; /* must be bare name */ - - /* add external domain */ -- strcat(name, "."); -- strcat(name, zone->domain); -+ if (zone) -+ { -+ strcat(name, "."); -+ strcat(name, zone->domain); -+ } - log_query(flag | F_DHCP | F_REVERSE, name, &addr, record_source(crecp->uid)); - found = 1; - if (add_resource_record(header, limit, &trunc, nameoffset, &ansp, -@@ -217,7 +220,7 @@ size_t answer_auth(struct dns_header *header, char *limit, size_t qlen, time_t n - T_PTR, C_IN, "d", name)) - anscount++; - } -- else if (crecp->flags & (F_DHCP | F_HOSTS) && in_zone(zone, name, NULL)) -+ else if (crecp->flags & (F_DHCP | F_HOSTS) && (local_query || in_zone(zone, name, NULL))) - { - log_query(crecp->flags & ~F_FORWARD, name, &addr, record_source(crecp->uid)); - found = 1; --- -2.1.4 - diff --git a/package/network/services/dnsmasq/patches/200-fix-dhcpv6-solicit-handling.patch b/package/network/services/dnsmasq/patches/200-fix-dhcpv6-solicit-handling.patch deleted file mode 100644 index 7c90028..0000000 --- a/package/network/services/dnsmasq/patches/200-fix-dhcpv6-solicit-handling.patch +++ /dev/null @@ -1,38 +0,0 @@ -From 35042c3ef61b3bc07f0f9418dff6be6ed78f4aa1 Mon Sep 17 00:00:00 2001 -From: Steven Barth -Date: Fri, 10 Apr 2015 10:46:57 +0200 -Subject: [PATCH] Revert "Don't reply to DHCPv6 SOLICIT messages when not - configured for statefull DHCPv6." - -This reverts commit 61b838dd574c51d96fef100285a0d225824534f9. ---- - src/rfc3315.c | 13 ------------- - 1 file changed, 13 deletions(-) - -diff --git a/src/rfc3315.c b/src/rfc3315.c -index c1ddc80..50131d8 100644 ---- a/src/rfc3315.c -+++ b/src/rfc3315.c -@@ -824,19 +824,6 @@ static int dhcp6_no_relay(struct state *state, int msg_type, void *inbuff, size_ - } - else - { -- /* Windows 8 always requests an address even if the Managed bit -- in RA is 0 and it keeps retrying if it receives a reply -- stating that no addresses are available. We solve this -- by not replying at all if we're not configured to give any -- addresses by DHCPv6. RFC 3315 17.2.1. appears to allow this. */ -- -- for (c = state->context; c; c = c->current) -- if (!(c->flags & CONTEXT_RA_STATELESS)) -- break; -- -- if (!c) -- return 0; -- - /* no address, return error */ - o1 = new_opt6(OPTION6_STATUS_CODE); - put_opt6_short(DHCP6NOADDRS); --- -2.1.4 -