diff mbox series

zram-swap: default to lzo instead of lzo-rle compression

Message ID 541cbfbd-76f2-59b3-a867-47b6f0fc7da9@gmail.com
State New
Headers show
Series zram-swap: default to lzo instead of lzo-rle compression | expand

Commit Message

e9hack Sept. 17, 2020, 9:38 a.m. UTC
Hi,

I think commit 419f149e482641ddc520f80a7ab2038f7e2ebc8a is not the proper fix for the described issue.

The kernel module lzo-rle is still missing. To solve this, it must be installed on the root-fs:



Since kernel 4.19 isn't longer used, @ge5.1 isn't necessary.

Regards,
Hartmut

Comments

Rui Salvaterra Sept. 17, 2020, 10:11 a.m. UTC | #1
On Thu, 17 Sep 2020 at 10:38, e9hack <e9hack@gmail.com> wrote:
>
> Hi,
>
> I think commit 419f149e482641ddc520f80a7ab2038f7e2ebc8a is not the proper fix for the described issue.
>
> The kernel module lzo-rle is still missing. To solve this, it must be installed on the root-fs:
>
> diff --git a/package/kernel/linux/modules/lib.mk b/package/kernel/linux/modules/lib.mk
> index 1289cc1f25..fade8a5cfd 100644
> --- a/package/kernel/linux/modules/lib.mk
> +++ b/package/kernel/linux/modules/lib.mk
> @@ -109,9 +109,10 @@ define KernelPackage/lib-lzo
>    HIDDEN:=1
>    FILES:= \
>         $(LINUX_DIR)/crypto/lzo.ko \
> +       $(LINUX_DIR)/crypto/lzo-rle.ko@ge5.1 \
>         $(LINUX_DIR)/lib/lzo/lzo_compress.ko \
>         $(LINUX_DIR)/lib/lzo/lzo_decompress.ko
> -  AUTOLOAD:=$(call AutoProbe,lzo lzo_compress lzo_decompress)
> +  AUTOLOAD:=$(call AutoProbe,lzo lzo-rle lzo_compress lzo_decompress)
>  endef
>
>  define KernelPackage/lib-lzo/description
>
>
> Since kernel 4.19 isn't longer used, @ge5.1 isn't necessary.
>
> Regards,
> Hartmut

Good catch. You're absolutely right, the lzo-rle is a separate module.
Now, what I don't understand is why the crypto layer advertises
lzo-rle support without the module being present. Sounds like an
upstream bug to me…

Thanks,
Rui
Adrian Schmutzler Sept. 17, 2020, 10:14 a.m. UTC | #2
Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org]
> On Behalf Of e9hack
> Sent: Donnerstag, 17. September 2020 11:39
> To: jo@mein.io; rsalvaterra@gmail.com
> Cc: openwrt-devel@lists.openwrt.org
> Subject: zram-swap: default to lzo instead of lzo-rle compression
> 
> Hi,
> 
> I think commit 419f149e482641ddc520f80a7ab2038f7e2ebc8a is not the
> proper fix for the described issue.
> 
> The kernel module lzo-rle is still missing. To solve this, it must be installed on
> the root-fs:
> 
> diff --git a/package/kernel/linux/modules/lib.mk
> b/package/kernel/linux/modules/lib.mk
> index 1289cc1f25..fade8a5cfd 100644
> --- a/package/kernel/linux/modules/lib.mk
> +++ b/package/kernel/linux/modules/lib.mk
> @@ -109,9 +109,10 @@ define KernelPackage/lib-lzo
>    HIDDEN:=1
>    FILES:= \
>         $(LINUX_DIR)/crypto/lzo.ko \
> +       $(LINUX_DIR)/crypto/lzo-rle.ko@ge5.1 \
>         $(LINUX_DIR)/lib/lzo/lzo_compress.ko \
>         $(LINUX_DIR)/lib/lzo/lzo_decompress.ko
> -  AUTOLOAD:=$(call AutoProbe,lzo lzo_compress lzo_decompress)
> +  AUTOLOAD:=$(call AutoProbe,lzo lzo-rle lzo_compress lzo_decompress)
>  endef
> 
>  define KernelPackage/lib-lzo/description
> 
> 
> Since kernel 4.19 isn't longer used, @ge5.1 isn't necessary.

Kernel 4.19 support is still present in master (for regression testing), so we should properly implement the switches until it is removed entirely.

Best

Adrian

> 
> Regards,
> Hartmut
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Sven Roederer Sept. 17, 2020, 11:38 p.m. UTC | #3
Am Donnerstag, 17. September 2020, 11:38:42 CEST schrieb e9hack:
>The kernel module lzo-rle is still missing. To solve this, it must be
> installed on the root-fs:
> 
> diff --git a/package/kernel/linux/modules/lib.mk
> b/package/kernel/linux/modules/lib.mk index 1289cc1f25..fade8a5cfd 100644
> --- a/package/kernel/linux/modules/lib.mk
> +++ b/package/kernel/linux/modules/lib.mk
> @@ -109,9 +109,10 @@ define KernelPackage/lib-lzo
>    HIDDEN:=1
>    FILES:= \
>         $(LINUX_DIR)/crypto/lzo.ko \
> +       $(LINUX_DIR)/crypto/lzo-rle.ko@ge5.1 \
>         $(LINUX_DIR)/lib/lzo/lzo_compress.ko \
>         $(LINUX_DIR)/lib/lzo/lzo_decompress.ko
> -  AUTOLOAD:=$(call AutoProbe,lzo lzo_compress lzo_decompress)
> +  AUTOLOAD:=$(call AutoProbe,lzo lzo-rle lzo_compress lzo_decompress)
>  endef
> 

Hartmut,

I had a short test wit zram-swap these days and also saw this. 
I fixed this by changing the default compression-algo to lzo via etc/config/
system. My intention was not to use an additional kernel-module which will 
consume additional RAM which I just won by using zram ... (Indeed I did not 
check the numbers and only assumed)


Sven
diff mbox series

Patch

diff --git a/package/kernel/linux/modules/lib.mk b/package/kernel/linux/modules/lib.mk
index 1289cc1f25..fade8a5cfd 100644
--- a/package/kernel/linux/modules/lib.mk
+++ b/package/kernel/linux/modules/lib.mk
@@ -109,9 +109,10 @@  define KernelPackage/lib-lzo
   HIDDEN:=1
   FILES:= \
        $(LINUX_DIR)/crypto/lzo.ko \
+       $(LINUX_DIR)/crypto/lzo-rle.ko@ge5.1 \
        $(LINUX_DIR)/lib/lzo/lzo_compress.ko \
        $(LINUX_DIR)/lib/lzo/lzo_decompress.ko
-  AUTOLOAD:=$(call AutoProbe,lzo lzo_compress lzo_decompress)
+  AUTOLOAD:=$(call AutoProbe,lzo lzo-rle lzo_compress lzo_decompress)
 endef

 define KernelPackage/lib-lzo/description