diff mbox series

[2/2] firmware-utils: tplink-safeloader: set EAP235-Wall v1 soft-version

Message ID 287cb6448768da477f05c8ec31b7160a45f7356f.1630057027.git.sander@svanheule.net
State Superseded
Headers show
Series TP-Link safeloader custom soft-version support | expand

Commit Message

Sander Vanheule Aug. 27, 2021, 9:38 a.m. UTC
Starting with v3 of the vendor firmware for the TP-Link EAP235-Wall v1,
downgrades to firmware versions below v3 as not allowed.  Since OpenWrt
uses version 0.0.0 as a default, this causes the factory install to fail
on devices with a recent firmware. This failure is associated by the
following message on the device's serial console:

    EAP235/230-Wall forbid fw reverted from 3.x.x to lower version!

Vendor firmware (v3) also uses build and release numbers to compare
images, so identical version numbers are very unlikely to cause issues.
Bump the firmware version to 3.0.0 to ensure users can install OpenWrt
on their devices.

Signed-off-by: Sander Vanheule <sander@svanheule.net>
---
 tools/firmware-utils/src/tplink-safeloader.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sander Vanheule Aug. 31, 2021, 8:01 p.m. UTC | #1
On Fri, 2021-08-27 at 11:38 +0200, Sander Vanheule wrote:
> Starting with v3 of the vendor firmware for the TP-Link EAP235-Wall v1,
> downgrades to firmware versions below v3 as not allowed.  Since OpenWrt
> uses version 0.0.0 as a default, this causes the factory install to fail
> on devices with a recent firmware. This failure is associated by the
> following message on the device's serial console:
> 
>     EAP235/230-Wall forbid fw reverted from 3.x.x to lower version!
> 
> Vendor firmware (v3) also uses build and release numbers to compare
> images, so identical version numbers are very unlikely to cause issues.
> Bump the firmware version to 3.0.0 to ensure users can install OpenWrt
> on their devices.
> 
> Signed-off-by: Sander Vanheule <sander@svanheule.net>

With permission to add these:

Reported-by: Colton Conor <colton.conor@gmail.com>
Tested-by: Colton Conor <colton.conor@gmail.com>

> ---
>  tools/firmware-utils/src/tplink-safeloader.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/firmware-utils/src/tplink-safeloader.c b/tools/firmware-utils/src/tplink-
> safeloader.c
> index 9349173e59..0b3ec41d3c 100644
> --- a/tools/firmware-utils/src/tplink-safeloader.c
> +++ b/tools/firmware-utils/src/tplink-safeloader.c
> @@ -1560,7 +1560,7 @@ static struct device_info boards[] = {
>                         "SupportList:\r\n"
>                         "EAP235-Wall(TP-Link|UN|AC1200-D):1.0\r\n",
>                 .part_trail = PART_TRAIL_NONE,
> -               .soft_ver = SOFT_VER_DEFAULT,
> +               .soft_ver = SOFT_VER_NUMERIC(3, 0, 0),
>                 .soft_ver_compat_level = 1,
>  
>                 .partitions = {
diff mbox series

Patch

diff --git a/tools/firmware-utils/src/tplink-safeloader.c b/tools/firmware-utils/src/tplink-safeloader.c
index 9349173e59..0b3ec41d3c 100644
--- a/tools/firmware-utils/src/tplink-safeloader.c
+++ b/tools/firmware-utils/src/tplink-safeloader.c
@@ -1560,7 +1560,7 @@  static struct device_info boards[] = {
 			"SupportList:\r\n"
 			"EAP235-Wall(TP-Link|UN|AC1200-D):1.0\r\n",
 		.part_trail = PART_TRAIL_NONE,
-		.soft_ver = SOFT_VER_DEFAULT,
+		.soft_ver = SOFT_VER_NUMERIC(3, 0, 0),
 		.soft_ver_compat_level = 1,
 
 		.partitions = {