From patchwork Mon Dec 22 12:05:13 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vittorio Gambaletta X-Patchwork-Id: 423372 X-Patchwork-Delegate: nbd@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from arrakis.dune.hu (arrakis.dune.hu [78.24.191.176]) (using TLSv1.1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5D4081400B7 for ; Mon, 22 Dec 2014 23:06:35 +1100 (AEDT) Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 28A5D28BE99; Mon, 22 Dec 2014 13:04:34 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on arrakis.dune.hu X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,T_DKIM_INVALID, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 6E54528433F for ; Mon, 22 Dec 2014 13:04:28 +0100 (CET) X-policyd-weight: using cached result; rate: -7.6 Received: from mail.vittgam.net (server1.vittgam.net [213.239.197.142]) by arrakis.dune.hu (Postfix) with ESMTPS for ; Mon, 22 Dec 2014 13:04:27 +0100 (CET) X-DKIM: OpenDKIM Filter v2.4.2 mail.vittgam.net sBMC6IPV050091 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=vittgam.net; s=20110809; t=1419249979; bh=DKhLTzY5ZgxgobjilXwr/R8iLih2BKXW8pnx5uNzzZY=; h=Date:Content-Type:Subject:From:Message-Id:To:Cc; b=y38Mc9guu0AiNvP6LF3Bv24Q4aFP056Oe8teGu8CVQMqM5Tjq1rY9Ask5g02v4RUL vAdrlOiwge5if1kdoL/v6/kePURpyPNEQGXR73TKPKVGVs2nk5HfbVho5bLdGaewAu ZL6AY2rx6QXTZV/mysEv2KjoFJgJeJenKH7pLhmk= Received: from mail2.vittgam.net ([10.48.0.5]) by mail.vittgam.net (8.14.4/8.14.4/Debian-2ubuntu2) with ESMTP id sBMC6IPV050091 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 22 Dec 2014 13:06:19 +0100 Received: from VittGamLaptop2 (VittGamLaptop2.router1net.VittGam.net [10.48.3.146]) by mail2.vittgam.net (8.14.4/8.14.4/Debian-2ubuntu2) with SMTP id sBMC5DYF030398; Mon, 22 Dec 2014 13:05:27 +0100 Date: Mon, 22 Dec 2014 13:05:13 +0100 From: Vittorio Gambaletta Message-Id: <248664759f09b9c7d7f37592009ef792dbfce33bv3@vittgam.net> To: Cc: openwrt-devel@lists.openwrt.org Subject: [OpenWrt-Devel] [PATCH] [v3] hostapd: Add uapsd option to netifd.sh X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" The uapsd option sets the uapsd_advertisement_enabled flag in hostapd. The check for phy support is already implemented here in hostapd since 2011: http://w1.fi/cgit/hostap/commit/?id=70619a5d8a3d32faa43d66bcb1b670cacf0c243e So this can be safely set to 1 as default. Signed-off-by: Vittorio Gambaletta --- a/package/network/services/hostapd/files/netifd.sh +++ b/package/network/services/hostapd/files/netifd.sh @@ -100,7 +100,7 @@ hostapd_common_add_bss_config() { config_add_string 'bssid:macaddr' 'ssid:string' - config_add_boolean wds wmm hidden + config_add_boolean wds wmm uapsd hidden config_add_int maxassoc max_inactivity config_add_boolean disassoc_low_ack isolate short_preamble @@ -163,7 +163,7 @@ maxassoc max_inactivity disassoc_low_ack isolate auth_cache \ wps_pushbutton wps_label ext_registrar wps_pbc_in_m1 \ wps_device_type wps_device_name wps_manufacturer wps_pin \ - macfilter ssid wmm hidden short_preamble rsn_preauth \ + macfilter ssid wmm uapsd hidden short_preamble rsn_preauth \ iapp_interface set_default isolate 0 @@ -173,6 +173,7 @@ set_default disassoc_low_ack 1 set_default hidden 0 set_default wmm 1 + set_default uapsd 1 append bss_conf "ctrl_interface=/var/run/hostapd" if [ "$isolate" -gt 0 ]; then @@ -189,6 +190,7 @@ append bss_conf "preamble=$short_preamble" "$N" append bss_conf "wmm_enabled=$wmm" "$N" append bss_conf "ignore_broadcast_ssid=$hidden" "$N" + append bss_conf "uapsd_advertisement_enabled=$uapsd" "$N" [ "$wpa" -gt 0 ] && { [ -n "$wpa_group_rekey" ] && append bss_conf "wpa_group_rekey=$wpa_group_rekey" "$N"