diff mbox series

[18.06,1/2] bcm63xx: VH4032N: backport, add missing pinctrl

Message ID 2309354.TybQBtaM6T@tool
State Rejected
Headers show
Series [18.06,1/2] bcm63xx: VH4032N: backport, add missing pinctrl | expand

Commit Message

Daniel González Cabanelas Jan. 21, 2021, 9:06 p.m. UTC
Backport 5af04f0d94a229 commit:
Add missing pin controls for the Observa VH4032N router.

This fixes the wifi radio and ethernet LAN LEDs.

Problem reported at forum post: 
https://forum.openwrt.org/t/openwrt-wifi-issue-in-observa-vh4032n

Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail.com>
---
 target/linux/brcm63xx/dts/vh4032n.dts | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Adrian Schmutzler Jan. 21, 2021, 10:12 p.m. UTC | #1
Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org]
> On Behalf Of Daniel González Cabanelas
> Sent: Donnerstag, 21. Januar 2021 22:06
> To: openwrt-devel@lists.openwrt.org
> Cc: ynezz@true.cz; noltari@gmail.com
> Subject: [PATCH 18.06 1/2] bcm63xx: VH4032N: backport, add missing pinctrl

OpenWrt 18.06 is EOL and will not receive any patches anymore.

Best

Adrian

> 
> Backport 5af04f0d94a229 commit:
> Add missing pin controls for the Observa VH4032N router.
> 
> This fixes the wifi radio and ethernet LAN LEDs.
> 
> Problem reported at forum post:
> https://forum.openwrt.org/t/openwrt-wifi-issue-in-observa-vh4032n
> 
> Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail.com>
> ---
>  target/linux/brcm63xx/dts/vh4032n.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/target/linux/brcm63xx/dts/vh4032n.dts
> b/target/linux/brcm63xx/dts/vh4032n.dts
> index 1296fbf..a17db77 100644
> --- a/target/linux/brcm63xx/dts/vh4032n.dts
> +++ b/target/linux/brcm63xx/dts/vh4032n.dts
> @@ -72,6 +72,10 @@
>  };
> 
>  &pinctrl {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_pci &pinctrl_ephy0_led &pinctrl_ephy1_led
> +		    &pinctrl_ephy2_led &pinctrl_ephy3_led>;
> +
>  	usb_hub_reset {
>  		gpio-hog;
>  		gpios = <27 0>;
> --
> 2.30.0
> 
> 
> 
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Daniel González Cabanelas Jan. 21, 2021, 10:20 p.m. UTC | #2
Hi, Adrian

El jue, 21 ene 2021 a las 23:13, Adrian Schmutzler
(<mail@adrianschmutzler.de>) escribió:
>
> Hi,
>
> > -----Original Message-----
> > From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org]
> > On Behalf Of Daniel González Cabanelas
> > Sent: Donnerstag, 21. Januar 2021 22:06
> > To: openwrt-devel@lists.openwrt.org
> > Cc: ynezz@true.cz; noltari@gmail.com
> > Subject: [PATCH 18.06 1/2] bcm63xx: VH4032N: backport, add missing pinctrl
>
> OpenWrt 18.06 is EOL and will not receive any patches anymore.
>

And that's because I asked at the IRC dev channel before sending the
patches. There are still chances for accepting new patches was the
answer I got.

Regards

> Best
>
> Adrian
>
> >
> > Backport 5af04f0d94a229 commit:
> > Add missing pin controls for the Observa VH4032N router.
> >
> > This fixes the wifi radio and ethernet LAN LEDs.
> >
> > Problem reported at forum post:
> > https://forum.openwrt.org/t/openwrt-wifi-issue-in-observa-vh4032n
> >
> > Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail.com>
> > ---
> >  target/linux/brcm63xx/dts/vh4032n.dts | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/target/linux/brcm63xx/dts/vh4032n.dts
> > b/target/linux/brcm63xx/dts/vh4032n.dts
> > index 1296fbf..a17db77 100644
> > --- a/target/linux/brcm63xx/dts/vh4032n.dts
> > +++ b/target/linux/brcm63xx/dts/vh4032n.dts
> > @@ -72,6 +72,10 @@
> >  };
> >
> >  &pinctrl {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&pinctrl_pci &pinctrl_ephy0_led &pinctrl_ephy1_led
> > +                 &pinctrl_ephy2_led &pinctrl_ephy3_led>;
> > +
> >       usb_hub_reset {
> >               gpio-hog;
> >               gpios = <27 0>;
> > --
> > 2.30.0
> >
> >
> >
> >
> >
> > _______________________________________________
> > openwrt-devel mailing list
> > openwrt-devel@lists.openwrt.org
> > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
diff mbox series

Patch

diff --git a/target/linux/brcm63xx/dts/vh4032n.dts b/target/linux/brcm63xx/dts/vh4032n.dts
index 1296fbf..a17db77 100644
--- a/target/linux/brcm63xx/dts/vh4032n.dts
+++ b/target/linux/brcm63xx/dts/vh4032n.dts
@@ -72,6 +72,10 @@ 
 };
 
 &pinctrl {
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_pci &pinctrl_ephy0_led &pinctrl_ephy1_led
+		    &pinctrl_ephy2_led &pinctrl_ephy3_led>;
+
 	usb_hub_reset {
 		gpio-hog;
 		gpios = <27 0>;