diff mbox series

iperf3/libiperf3 build issue

Message ID 20cc3526-3eb9-5a6a-3c2f-da336d072cd8@gmail.com
State Not Applicable
Delegated to: Petr Štetiar
Headers show
Series iperf3/libiperf3 build issue | expand

Commit Message

e9hack Sept. 14, 2022, 3:12 p.m. UTC
Hi,

commit "ae48be8e2157bc7c352b3b6d30c026fafdae4867 / iperf3: add shared libiperf library and link iperf3 dynamically" is wrong. The install rule for libiperf3 overrides the rule for iperf3. Iperf3 itself will not be installed.
  

Regards,
Hartmut

Comments

Nick Sept. 14, 2022, 9:26 p.m. UTC | #1
Sorry, I did a typo when creating the PR. Fixed with:
https://github.com/openwrt/packages/pull/19368

Bests
Nick

On 9/14/22 17:12, e9hack wrote:
> Hi,
>
> commit "ae48be8e2157bc7c352b3b6d30c026fafdae4867 / iperf3: add shared 
> libiperf library and link iperf3 dynamically" is wrong. The install 
> rule for libiperf3 overrides the rule for iperf3. Iperf3 itself will 
> not be installed.
>
> diff --git a/net/iperf3/Makefile b/net/iperf3/Makefile
> index db3b6e432..a5f465f99 100644
> --- a/net/iperf3/Makefile
> +++ b/net/iperf3/Makefile
> @@ -97,7 +97,7 @@ define Package/iperf3-ssl/install
>      $(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/iperf3 $(1)/usr/bin/
>  endef
>
> -define Package/iperf3/install
> +define Package/libiperf3/install
>      $(INSTALL_DIR) $(1)/usr/lib
>      $(CP) $(PKG_INSTALL_DIR)/usr/lib/libiperf.so.* $(1)/usr/lib
>  endef
>
> Regards,
> Hartmut
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
diff mbox series

Patch

diff --git a/net/iperf3/Makefile b/net/iperf3/Makefile
index db3b6e432..a5f465f99 100644
--- a/net/iperf3/Makefile
+++ b/net/iperf3/Makefile
@@ -97,7 +97,7 @@  define Package/iperf3-ssl/install
  	$(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/iperf3 $(1)/usr/bin/
  endef
  
-define Package/iperf3/install
+define Package/libiperf3/install
  	$(INSTALL_DIR) $(1)/usr/lib
  	$(CP) $(PKG_INSTALL_DIR)/usr/lib/libiperf.so.* $(1)/usr/lib
  endef