diff mbox series

uboot-mediatek: lower eMMC frequency for GL.iNet GL-X3000

Message ID 20250616072136.12710-1-mrkiko.rs@gmail.com
State New
Headers show
Series uboot-mediatek: lower eMMC frequency for GL.iNet GL-X3000 | expand

Commit Message

Enrico Mioso June 16, 2025, 7:21 a.m. UTC
Lower the max-frequency property, aligning it with the current value used
in the kernel DTS.

Signed-off-by: Enrico Mioso <mrkiko.rs@gmail.com>
---
 package/boot/uboot-mediatek/patches/454-add-glinet-x3000.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chris Webb June 18, 2025, 9:08 a.m. UTC | #1
On 16/06/2025 08:21, Enrico Mioso wrote:

> Lower the max-frequency property, aligning it with the current value used
> in the kernel DTS.

Hi. I agree it's likely that this is correct if the kernel fix is 
correct. The impact of slowing eMMC transfers in the bootloader is less 
important than slowing every runtime access in the kernel too. If 
there's any place to be conservative, it's here.

Did GL.iNet ever reply about what specific problem this fix is supposed 
to correct? As far as I can guess from their vague waffle, it's a 
workaround for eMMC issues on a small number of early boards, but they 
haven't actually said that.

Best wishes,

Chris.
diff mbox series

Patch

diff --git a/package/boot/uboot-mediatek/patches/454-add-glinet-x3000.patch b/package/boot/uboot-mediatek/patches/454-add-glinet-x3000.patch
index 253939a2be..fe89b63441 100644
--- a/package/boot/uboot-mediatek/patches/454-add-glinet-x3000.patch
+++ b/package/boot/uboot-mediatek/patches/454-add-glinet-x3000.patch
@@ -106,7 +106,7 @@ 
 +&mmc0 {
 +	pinctrl-names = "default";
 +	pinctrl-0 = <&mmc0_pins_default>;
-+	max-frequency = <52000000>;
++	max-frequency = <26000000>;
 +	bus-width = <8>;
 +	cap-mmc-hw-highspeed;
 +	cap-mmc-hw-reset;