diff mbox series

[v3,9/9] config: set RFC defaults for preferred lifetime

Message ID 20240409030540.77576-10-newtwen+github@gmail.com
State New
Headers show
Series odhcpd patchset | expand

Commit Message

Paul Donald April 9, 2024, 3:04 a.m. UTC
From: Paul Donald <newtwen@gmail.com>

set them in accordance with RFC4861

Signed-off-by: Paul Donald <newtwen@gmail.com>
---
 README       | 2 +-
 src/config.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/README b/README
index 243ae24..c8f2eb4 100644
--- a/README
+++ b/README
@@ -116,7 +116,7 @@  domain			list	<local search domain>	Search domains to announce
 leasetime		string	12h			DHCPv4 address leasetime
 start			integer	100			DHCPv4 pool start
 limit			integer	150			DHCPv4 pool size
-preferred_lifetime	string	12h			Value for the preferred lifetime
+preferred_lifetime	string	7d			Value for the preferred lifetime
 							for a prefix
 ra_default		integer	0			Override default route
 			0: default, 1: ignore no public address, 2: ignore all
diff --git a/src/config.c b/src/config.c
index 7fe31a1..5a32c10 100644
--- a/src/config.c
+++ b/src/config.c
@@ -215,7 +215,7 @@  static void set_interface_defaults(struct interface *iface)
 	iface->ndp = MODE_DISABLED;
 	iface->learn_routes = 1;
 	iface->dhcp_leasetime = 43200;
-	iface->preferred_lifetime = 43200;
+	iface->preferred_lifetime = 604800; // rfc4861#section-6.2.1: AdvPreferredLifetime 7 days
 	iface->dhcpv4_start.s_addr = htonl(START_DEFAULT);
 	iface->dhcpv4_end.s_addr = htonl(START_DEFAULT + LIMIT_DEFAULT - 1);
 	iface->dhcpv6_assignall = true;