From patchwork Fri Apr 5 11:06:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paul Donald X-Patchwork-Id: 1920245 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=v5Q1T/dY; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=dq0kZ9O5; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V9yJP5dhfz1yZQ for ; Fri, 5 Apr 2024 23:21:09 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:To:From:Reply-To: Cc:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vDt+ecOivwGi9/PX3ylhOBxGveptvu0JensqOhkgy8A=; b=v5Q1T/dYZA9DLV935axDD144SZ 35zySag9I7Ofj0znrNr5aShWTEhasqysv/RU+FfwR35RRWHO3tYLJ+nU3tnG4lCqLog2EKtaNAFFq AXmqy/BV4QLPkZmvTU5dHpXWiKlW6hkOxdPQwQzhOVk4c3WTNWqJOEpkOXSFV/UKm17S3VYqnaLr+ tcLvENXFFdOf9BahSMODfJtp3l/HgBCf2sLEnEHFIrlJEAOzS4hS/SeO9ewgWDWSmDDniOyUwdndR 7INQN9ZUwymZI7yfmJRwLqU0lwGC5THItphnsjCSIAzyzRxN8n/M5FrrejIdvwwkzu6niCHLvm6x9 A1+JrY1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsiY1-00000006tL0-1TzY; Fri, 05 Apr 2024 12:19:57 +0000 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rshSq-00000006be0-2ru8 for openwrt-devel@lists.openwrt.org; Fri, 05 Apr 2024 11:10:35 +0000 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2d6ff0422a2so23425011fa.2 for ; Fri, 05 Apr 2024 04:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712315429; x=1712920229; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=vvBPx8MUGYzVwXyoNgcGbGFqkf+iBbUdBp+yGv6X7ag=; b=dq0kZ9O5IY4A9R4HtYGg1YvGVD/xE4HjxBM8hgAWLi6hw/5Rt/ots7iA3VKX+L0yVI t4a4FdPZD4cI1g/GSyfJOyNaDcXOffyYiDlRbX68xnDE8y/RLE+ty+8PqcC+HX+KLIli 2PGKwG0f5i3VPHoJiKcUwEJWDIkGZ3rjdNgaRkdBQPTCOgPTl79VxfkW93MvBkjG1uLx U+Coa3zWHq0mWWO5jhEXiywt2i3lwDQXZ1+lQYWJ/ccFaz8bPXbOnZFfn7vH+ngxYUEP zg68HStfJyLSUiVbfUEsCT8cZfr/fY16s1dDknX9WgitP7hBeXcx07USIG/qqGpYie+v UtBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712315429; x=1712920229; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vvBPx8MUGYzVwXyoNgcGbGFqkf+iBbUdBp+yGv6X7ag=; b=jMfeQgDPcSvG4RjubbXphZbQCEgNr+WS0W4mldSBSnfcnqVLHotH8vZDUbSFXWpapa 8Hb7cdL9L5KD8srODbmzir9+Gnd+5bEG9Adw+CAJdWP4AK7QKJiJokRO2T9qXMCO3Tnt gOJU7zJZTbJYNDPhdBTmhbNys7KQxH5E+EF/jrYlrsrnGnIchlSlgT17nGkeJtwYlYKc NBJkbp5/s3b2W6jhWYxLIPyRpNgj7JZn20zdN+O8Uu+r2vEYTgW7EuvNo6NxQHZ84115 flSsjA0Lh0EHwWn4cvSz1GTKvFan4FD11nnmTyLzsTsc/5GlyZI7dW/dHxg+82JbBq6W vkvg== X-Gm-Message-State: AOJu0YyruDx0/o20E5G6g7t4xT/S8AKQMext0kcuRTPFFYrVB5yY0x2T C9LWz8AVh2a0vsowO0bWOTXRSuKbXyDpBJTIThbLZ2FxNC706mGkn7TuW2O2cc0KoA== X-Google-Smtp-Source: AGHT+IFiAoR4NCsHt2rEaR/te9c6KwlJ9mkRGkF+ihHUeoOtr+ptTnZoHgCbuJXnTMsYU2VGNp4GFw== X-Received: by 2002:a05:6512:3c8e:b0:516:d15e:88a4 with SMTP id h14-20020a0565123c8e00b00516d15e88a4mr967968lfv.49.1712315428938; Fri, 05 Apr 2024 04:10:28 -0700 (PDT) Received: from blackhol3 ([2001:9b0:40::cae3:cb03]) by smtp.gmail.com with ESMTPSA id g21-20020ac24d95000000b00516cdadf377sm163719lfe.137.2024.04.05.04.10.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 04:10:28 -0700 (PDT) From: Paul Donald To: OpenWrt Development List Subject: [PATCH v2 3/9] various: Comment spell-fixes and clarification Date: Fri, 5 Apr 2024 13:06:47 +0200 Message-ID: <20240405111025.26478-4-newtwen+github@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240405111025.26478-1-newtwen+github@gmail.com> References: <20240405005510.19778-1-newtwen+github@gmail.com> <20240405111025.26478-1-newtwen+github@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_041032_838367_C92174B9 X-CRM114-Status: GOOD ( 14.64 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Paul Donald Signed-off-by: Paul Donald Reviewed-by: Daniel Golle --- src/dhcpv4.c | 2 +- src/dhcpv6-ia.c | 6 +++--- src/netlink.c | 2 +- src/router.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:234 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [newtwen+github(at)gmail.com] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org From: Paul Donald Signed-off-by: Paul Donald Reviewed-by: Daniel Golle --- src/dhcpv4.c | 2 +- src/dhcpv6-ia.c | 6 +++--- src/netlink.c | 2 +- src/router.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/dhcpv4.c b/src/dhcpv4.c index 3191ff2..cb0484f 100644 --- a/src/dhcpv4.c +++ b/src/dhcpv4.c @@ -893,7 +893,7 @@ void dhcpv4_handle_msg(void *addr, void *data, size_t len, struct arpreq arp = {.arp_flags = ATF_COM}; /* - * send reply to the newly (in this proccess) allocated IP + * send reply to the newly (in this process) allocated IP */ dest.sin_addr = reply.yiaddr; dest.sin_port = htons(DHCPV4_CLIENT_PORT); diff --git a/src/dhcpv6-ia.c b/src/dhcpv6-ia.c index 39a316a..dde224d 100644 --- a/src/dhcpv6-ia.c +++ b/src/dhcpv6-ia.c @@ -1142,11 +1142,11 @@ static size_t build_ia(uint8_t *buf, size_t buflen, uint16_t status, } if (!INFINITE_VALID(a->valid_until)) - /* UINT32_MAX is considered as infinite leasetime */ + /* UINT32_MAX is RFC defined as infinite lease-time */ a->valid_until = (valid_lt == UINT32_MAX) ? 0 : valid_lt + now; if (!INFINITE_VALID(a->preferred_until)) - /* UINT32_MAX is considered as infinite leasetime */ + /* UINT32_MAX is RFC defined as infinite lease-time */ a->preferred_until = (preferred_lt == UINT32_MAX) ? 0 : preferred_lt + now; o_ia.t1 = htonl((preferred_lt == UINT32_MAX) ? preferred_lt : preferred_lt * 5 / 10); @@ -1570,7 +1570,7 @@ ssize_t dhcpv6_ia_handle_IAs(uint8_t *buf, size_t buflen, struct interface *ifac /* Set error status */ status = (is_pd) ? DHCPV6_STATUS_NOPREFIXAVAIL : DHCPV6_STATUS_NOADDRSAVAIL; else if (hdr->msg_type == DHCPV6_MSG_REQUEST && !dhcpv6_ia_on_link(ia, a, iface)) { - /* Send NOTONLINK staus for the IA */ + /* Send NOTONLINK status for the IA */ status = DHCPV6_STATUS_NOTONLINK; assigned = false; } else if (accept_reconf && assigned && !first && diff --git a/src/netlink.c b/src/netlink.c index c33e3ea..368e69c 100644 --- a/src/netlink.c +++ b/src/netlink.c @@ -213,7 +213,7 @@ static void refresh_iface_addr6(int ifindex) if (change) { /* - * Keep track on removed prefixes, so we could advertise them as invalid + * Keep track of removed prefixes, so we could advertise them as invalid * for at least a couple of times. * * RFC7084 § 4.3 : diff --git a/src/router.c b/src/router.c index 6a9e19d..335218f 100644 --- a/src/router.c +++ b/src/router.c @@ -709,7 +709,7 @@ static int send_router_advert(struct interface *iface, const struct in6_addr *fr iov[IOV_RA_SEARCH].iov_len = search_sz; if (iface->pref64_length) { - /* RFC 8781 § 4.1 rounding up lifetime to multiply of 8 */ + /* RFC 8781 § 4.1 rounding up lifetime to multiple of 8 */ uint16_t pref64_lifetime = lifetime < (UINT16_MAX - 7) ? lifetime + 7 : UINT16_MAX; uint8_t prefix_length_code; uint32_t mask_a1, mask_a2;