diff mbox series

[2/2] mvebu: cortexa72: enable USB PHY

Message ID 20230907151548.15143-2-tmn505@terefe.re
State Accepted
Delegated to: Hauke Mehrtens
Headers show
Series [1/2] mvebu: refresh 6.1 configs | expand

Commit Message

Tomasz Maciej Nowak Sept. 7, 2023, 3:06 p.m. UTC 
From: Tomasz Maciej Nowak <tmn505@gmail.com>

Since kernel 5.13 this is needed to enable USB ports on all devices in
subtarget. Previously TF-A and COMPHY driver might have set up this PHY,
but not anymore.

Signed-off-by: Tomasz Maciej Nowak <tmn505@gmail.com>
---
Please backport config-5.15 changes to 23.05 and 22.03 branches.

 target/linux/mvebu/cortexa72/config-5.15 | 1 +
 target/linux/mvebu/cortexa72/config-6.1  | 1 +
 2 files changed, 2 insertions(+)

Comments

Robert Marko Sept. 8, 2023, 9:35 p.m. UTC | #1 
On Thu, 7 Sept 2023 at 17:16, Tomasz Maciej Nowak <tmn505@terefe.re> wrote:
>
> From: Tomasz Maciej Nowak <tmn505@gmail.com>
>
> Since kernel 5.13 this is needed to enable USB ports on all devices in
> subtarget. Previously TF-A and COMPHY driver might have set up this PHY,
> but not anymore.
>
> Signed-off-by: Tomasz Maciej Nowak <tmn505@gmail.com>

I tested this on MOchabin and it seems to be working after I actually
enable the UTMI PHY-s,
hence why USB was working fine on MOchabin without this driver.
And yeah, this should be backported to anything using 5.15 or newer as
Machiatobin has broken
USB for sure.

Tested-by: Robert Marko <robimarko@gmail.com>
> ---
> Please backport config-5.15 changes to 23.05 and 22.03 branches.
>
>  target/linux/mvebu/cortexa72/config-5.15 | 1 +
>  target/linux/mvebu/cortexa72/config-6.1  | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/target/linux/mvebu/cortexa72/config-5.15 b/target/linux/mvebu/cortexa72/config-5.15
> index cb27e0285faa..978208f1cb5a 100644
> --- a/target/linux/mvebu/cortexa72/config-5.15
> +++ b/target/linux/mvebu/cortexa72/config-5.15
> @@ -72,6 +72,7 @@ CONFIG_PCIE_DW_HOST=y
>  CONFIG_PGTABLE_LEVELS=3
>  CONFIG_PHYS_ADDR_T_64BIT=y
>  CONFIG_PHY_MVEBU_CP110_COMPHY=y
> +CONFIG_PHY_MVEBU_CP110_UTMI=y
>  CONFIG_PINCTRL_ARMADA_37XX=y
>  CONFIG_PINCTRL_ARMADA_AP806=y
>  CONFIG_PINCTRL_ARMADA_CP110=y
> diff --git a/target/linux/mvebu/cortexa72/config-6.1 b/target/linux/mvebu/cortexa72/config-6.1
> index 5a3dcc66f720..535b67225e70 100644
> --- a/target/linux/mvebu/cortexa72/config-6.1
> +++ b/target/linux/mvebu/cortexa72/config-6.1
> @@ -76,6 +76,7 @@ CONFIG_PCIE_DW_HOST=y
>  CONFIG_PGTABLE_LEVELS=3
>  CONFIG_PHYS_ADDR_T_64BIT=y
>  CONFIG_PHY_MVEBU_CP110_COMPHY=y
> +CONFIG_PHY_MVEBU_CP110_UTMI=y
>  CONFIG_PINCTRL_AC5=y
>  CONFIG_PINCTRL_ARMADA_37XX=y
>  CONFIG_PINCTRL_ARMADA_AP806=y
> --
> 2.42.0
>
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
diff mbox series

Patch

diff --git a/target/linux/mvebu/cortexa72/config-5.15 b/target/linux/mvebu/cortexa72/config-5.15
index cb27e0285faa..978208f1cb5a 100644
--- a/target/linux/mvebu/cortexa72/config-5.15
+++ b/target/linux/mvebu/cortexa72/config-5.15
@@ -72,6 +72,7 @@  CONFIG_PCIE_DW_HOST=y
 CONFIG_PGTABLE_LEVELS=3
 CONFIG_PHYS_ADDR_T_64BIT=y
 CONFIG_PHY_MVEBU_CP110_COMPHY=y
+CONFIG_PHY_MVEBU_CP110_UTMI=y
 CONFIG_PINCTRL_ARMADA_37XX=y
 CONFIG_PINCTRL_ARMADA_AP806=y
 CONFIG_PINCTRL_ARMADA_CP110=y
diff --git a/target/linux/mvebu/cortexa72/config-6.1 b/target/linux/mvebu/cortexa72/config-6.1
index 5a3dcc66f720..535b67225e70 100644
--- a/target/linux/mvebu/cortexa72/config-6.1
+++ b/target/linux/mvebu/cortexa72/config-6.1
@@ -76,6 +76,7 @@  CONFIG_PCIE_DW_HOST=y
 CONFIG_PGTABLE_LEVELS=3
 CONFIG_PHYS_ADDR_T_64BIT=y
 CONFIG_PHY_MVEBU_CP110_COMPHY=y
+CONFIG_PHY_MVEBU_CP110_UTMI=y
 CONFIG_PINCTRL_AC5=y
 CONFIG_PINCTRL_ARMADA_37XX=y
 CONFIG_PINCTRL_ARMADA_AP806=y