diff mbox series

[1/3] target.mk: silence CPU_TYPE doesn't correspond to a known type

Message ID 20230615141127.2462701-1-ynezz@true.cz
State Under Review
Delegated to: Petr Štetiar
Headers show
Series [1/3] target.mk: silence CPU_TYPE doesn't correspond to a known type | expand

Commit Message

Petr Štetiar June 15, 2023, 2:11 p.m. UTC
Following command:

 $ ./scripts/dump-target-info.pl targets

currently generates bunch of following warnings:

 include/target.mk:269: CPU_TYPE "cortex-a15" doesn't correspond to a known type

just because there is no CPU_CFLAGS_cortexa-15 defined for that CPU and
there is no value in this warning, so lets acknowledge such CPU_TYPEs
and do not print those warnings.

Signed-off-by: Petr Štetiar <ynezz@true.cz>
---
 include/target.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Florian Eckert June 16, 2023, 6:16 a.m. UTC | #1
Hello Petr

On 2023-06-15 16:11, Petr Štetiar wrote:
> Following command:
> 
>  $ ./scripts/dump-target-info.pl targets
> 
> currently generates bunch of following warnings:
> 
>  include/target.mk:269: CPU_TYPE "cortex-a15" doesn't correspond to a 
> known type

I've noticed that too. Could you please explain why does this happen?
And why do we suppress the message now?

I would expect to add the missing CPU_TYPS and not suppress the warning.

---
Best regards

Florian
diff mbox series

Patch

diff --git a/include/target.mk b/include/target.mk
index b5e3e7ff6fde..1783f8f94f9d 100644
--- a/include/target.mk
+++ b/include/target.mk
@@ -264,9 +264,13 @@  ifeq ($(DUMP),1)
     CPU_TYPE ?= riscv64
     CPU_CFLAGS_riscv64:=-mabi=lp64d -march=rv64imafdc
   endif
+  DONOT_WARN_CPU_TYPES=arm1176jzf-s arm926ej-s cortex-a15 cortex-a5 cortex-a7 cortex-a72 \
+    cortex-a8 cortex-a9 fa526 mpcore xscale
   ifneq ($(CPU_TYPE),)
     ifndef CPU_CFLAGS_$(CPU_TYPE)
-      $(warning CPU_TYPE "$(CPU_TYPE)" doesn't correspond to a known type)
+      ifeq (,$(findstring $(CPU_TYPE),$(DONOT_WARN_CPU_TYPES)))
+        $(warning CPU_TYPE "$(CPU_TYPE)" doesn't correspond to a known type)
+      endif
     endif
   endif
   DEFAULT_CFLAGS=$(strip $(CPU_CFLAGS) $(CPU_CFLAGS_$(CPU_TYPE)) $(CPU_CFLAGS_$(CPU_SUBTYPE)))