From patchwork Sun Feb 19 15:20:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hauke Mehrtens X-Patchwork-Id: 1744701 X-Patchwork-Delegate: hauke@hauke-m.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=o+hTqUOY; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=hauke-m.de header.i=@hauke-m.de header.a=rsa-sha256 header.s=MBO0001 header.b=XQG+rcIL; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PKTpq62SLz23j7 for ; Mon, 20 Feb 2023 02:23:47 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k8qsf5DLmOL95i6wLEdxAGfPMZlg8YSyAFFI8U7mY6Q=; b=o+hTqUOY2pEqD4 26eSYOfKwGm3oMwChq2HL4eFhkSc72okkEmxLOdi5TdMWuSNtbhc2d6RixdklrcGnLhqx74g7a5AW 3yJeAU4THglpt7em2Al+CGRPHSwfDlhhWRKLnD6iK0MafRLclMBwN5BLxsHLaiQpu/oHnkTvnqP0M pnoD/hPe13/xx59ZJ8Ug4mBwi0cHVEGpV/AN/1bJNXkbXWJ0FMA7IpcYZ7I7f1iobH32my37WFPA9 WXIoM3ivf5eTtBgEtmJFmKeOR7zXsD/FAkdnBD5zbDB6VB/Vq5z4of1kuv8J/mkrioScqXOwFdbPI kLbvsuMJjlksEMuSHmlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pTlVX-001mdl-O7; Sun, 19 Feb 2023 15:21:43 +0000 Received: from mout-p-202.mailbox.org ([80.241.56.172]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pTlUm-001mX8-SQ for openwrt-devel@lists.openwrt.org; Sun, 19 Feb 2023 15:20:58 +0000 Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4PKTlL6PkRz9sPy; Sun, 19 Feb 2023 16:20:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hauke-m.de; s=MBO0001; t=1676820046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i1KK0HsOA90Dx7ruk644w0+9d1oGAhmbfuwTvBjnk/M=; b=XQG+rcILWIiCt699PZNLKVbO9PJliEBfdg9F1FvET+Y6gxG6bzeE8LRrZfK0Z+CydMKPMV JxMHEs8juoi9UzMwXbRW+X5n8cB6cbhXkJw/7BRaEUM7PzKA1PemuMp0ZjroHvtZjMegiZ CYMPxviaAMGBWgRRCTh06mQptEPNV+1lP/eNC4q5mEcqohgg216gm4XQc3yALt7G40m/6M DDUFZxjvug0H+wdafr8Nqiacmox7cNLy5wKVfK73d5OEKYdSHoycjHqj8wPcu+wqQtAetZ 8ncw02A3Nw/hNPAL9qV6TDccBsYmgeZS88MC0Lk5Hj+KzaU0imekaPy5+8KEFw== From: Hauke Mehrtens To: openwrt-devel@lists.openwrt.org Cc: Hauke Mehrtens Subject: [PATCH netifd 5/5] netifd: Activate -Wextra compile warnings Date: Sun, 19 Feb 2023 16:20:27 +0100 Message-Id: <20230219152027.3417324-6-hauke@hauke-m.de> In-Reply-To: <20230219152027.3417324-1-hauke@hauke-m.de> References: <20230219152027.3417324-1-hauke@hauke-m.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230219_072057_217914_071D0F58 X-CRM114-Status: UNSURE ( 6.79 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This activates some more compile warnings. -pedantic is not yet activated, then we see too many errors which I do not know how to mitigate. Signed-off-by: Hauke Mehrtens --- CMakeLists.txt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) Content analysis details: (-0.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.172 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org This activates some more compile warnings. -pedantic is not yet activated, then we see too many errors which I do not know how to mitigate. Signed-off-by: Hauke Mehrtens --- CMakeLists.txt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index b3bf411..b87c300 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -7,7 +7,11 @@ IF(NOT ${CMAKE_VERSION} LESS 3.0) check_c_compiler_flag(-Wimplicit-fallthrough HAS_IMPLICIT_FALLTHROUGH) ENDIF() -ADD_DEFINITIONS(-Os -Wall -Werror --std=gnu99 -Wmissing-declarations -Wno-unknown-warning-option -Wno-format-truncation) +ADD_DEFINITIONS(-Os -Wall -Werror --std=gnu99 -Wmissing-declarations -Wno-unused-parameter -Wno-unused-but-set-parameter) +IF(CMAKE_C_COMPILER_VERSION VERSION_GREATER 6) + add_definitions(-Wextra -Werror=implicit-function-declaration) + add_definitions(-Wformat -Werror=format-security -Werror=format-nonliteral) +ENDIF() IF(HAS_IMPLICIT_FALLTHROUGH) ADD_DEFINITIONS(-Wimplicit-fallthrough)