From patchwork Tue Aug 23 14:33:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Swanson X-Patchwork-Id: 1669310 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=suBuYDZB; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MBsHY03nGz1ygF for ; Wed, 24 Aug 2022 00:36:38 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=LNIZ8vgMWb/J+GTmzkBISB7vTbWUj7qt9rC/BO5Do94=; b=suBuYDZB6W2Qvd Z2HYxxZuO3UDd+eTgAO2ZAJaum9e6i9uo0ozRYKk5WLPADOsDkHb5M3kia0SlS+/soQZfx+9s/ChG 1MmAVzS5F4fjkjN8SutgagVMwmSyNb3S1JIVcQGu3JY+zWVxvsPcpths5pvNMtvmElSLWCxd9T5Xl MATs9GKxosz4DQVZRaMhVq3hlnEpXqC7s8eT8kDBiWtTb2b1AZTeeRWq6sBExiV/2Qe4mdxDJldoC TmYSU/N8MTx2ZsnsV/a1kiHvp7sJnZwB0PZnshpzZbYSHJtUMvAh2PEQVkJcLQxLvyo5oOOs/U9Sc +1bzeGfP8P4YG11PC0Kg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQUyS-006eLG-9v; Tue, 23 Aug 2022 14:33:48 +0000 Received: from relay2.stackmail.com ([185.151.28.66]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQUyO-006eJH-51 for openwrt-devel@lists.openwrt.org; Tue, 23 Aug 2022 14:33:45 +0000 Received: from [10.4.4.89] (helo=smtp2.lhr.stackcp.net) by relay2.stackmail.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1oQUyE-0001Qr-2a for openwrt-devel@lists.openwrt.org; Tue, 23 Aug 2022 15:33:34 +0100 Received: from slartibartfast.improbability.net ([51.155.134.81]) by smtp2.lhr.stackcp.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1oQUyE-00073O-1O for openwrt-devel@lists.openwrt.org; Tue, 23 Aug 2022 15:33:34 +0100 Received: from trillian.improbability.net (trillian.improbability.net [192.168.1.20]) by slartibartfast.improbability.net (Postfix) with ESMTPSA id 791C542; Tue, 23 Aug 2022 15:33:33 +0100 (BST) From: Alan Swanson To: openwrt-devel@lists.openwrt.org Cc: Alan Swanson Subject: [PATCH] interface-ip: stop setting prefix indicator flag when IPv6 prefix lifetime changes Date: Tue, 23 Aug 2022 15:33:28 +0100 Message-Id: <20220823143328.9456-1-reiver@improbability.net> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Authenticated-Sender: alan@improbability.net X-Scan-Signature: 46fe28550ff1317636d5d77b2ec0e146 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220823_073344_212286_ADC957AB X-CRM114-Status: UNSURE ( 6.81 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.0 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Since hnetd has now been dead for years we can safely revert commit a03216660797173fbe67866f75564e3fec9c1e8d which was causing unnecessarily frequent interface triggers and service reloads for IPv6 pr [...] Content analysis details: (-0.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [185.151.28.66 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [185.151.28.66 listed in wl.mailspike.net] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Since hnetd has now been dead for years we can safely revert commit a03216660797173fbe67866f75564e3fec9c1e8d which was causing unnecessarily frequent interface triggers and service reloads for IPv6 prefix lifetime changes. Fixes: FS#713 https://github.com/openwrt/openwrt/issues/5723 Fixes: FS#1492 https://github.com/openwrt/openwrt/issues/6454 Signed-off-by: Alan Swanson --- interface-ip.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/interface-ip.c b/interface-ip.c index ab4a5cf..fd2b2ab 100644 --- a/interface-ip.c +++ b/interface-ip.c @@ -1302,10 +1302,6 @@ interface_update_prefix(struct vlist_tree *tree, list_for_each_entry(c, &prefix_new->assignments, head) if ((iface = vlist_find(&interfaces, c->name, iface, node))) interface_set_prefix_address(c, prefix_new, iface, new_valid); - - if (prefix_new->preferred_until != prefix_old->preferred_until || - prefix_new->valid_until != prefix_old->valid_until) - ip->iface->updated |= IUF_PREFIX; } else if (node_new) { /* Set null-route to avoid routing loops */ system_add_route(NULL, &route);