| Message ID | 20220816170047.50642-1-hacks@slashdirt.org |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | build: always set CONFIG_IPV6 | expand |
On 16/08/2022 20:00, Thibaut VARÈNE wrote: > Disabling this build tunable breaks build and seems unrealistically > likely to be fixed. > > This patch sets the related CONFIG to always true and removes the > config prompt, keeping the change minimal, and, should !CONFIG_IPV6 ever > be fixed, easy to revert. If we're always going to set it to yes, just drop the option entirely and enable it in the generic kernel configs. Aside from that: Acked-by: Stijn Tintel <stijn@linux-ipv6.be>
> Le 18 août 2022 à 15:40, Stijn Tintel <stijn@linux-ipv6.be> a écrit : > > On 16/08/2022 20:00, Thibaut VARÈNE wrote: >> Disabling this build tunable breaks build and seems unrealistically >> likely to be fixed. >> >> This patch sets the related CONFIG to always true and removes the >> config prompt, keeping the change minimal, and, should !CONFIG_IPV6 ever >> be fixed, easy to revert. > > If we're always going to set it to yes, just drop the option entirely and enable it in the generic kernel configs. Aside from that: CONFIG_IPV6 is not a kernel config, it’s a tree-wide one. My idea was to keep the change as small as possible should we ever want to revert, while preventing further pointless bugreports[1]. Entirely removing the config option requires more invasive changes throughout the tree and the package repositories, which is significantly less trivial than this "first step". Cheers, Thibaut [1] https://github.com/openwrt/openwrt/issues/9580
On 18/08/2022 17:03, Thibaut wrote: >> Le 18 août 2022 à 15:40, Stijn Tintel <stijn@linux-ipv6.be> a écrit : >> >> On 16/08/2022 20:00, Thibaut VARÈNE wrote: >>> Disabling this build tunable breaks build and seems unrealistically >>> likely to be fixed. >>> >>> This patch sets the related CONFIG to always true and removes the >>> config prompt, keeping the change minimal, and, should !CONFIG_IPV6 ever >>> be fixed, easy to revert. >> If we're always going to set it to yes, just drop the option entirely and enable it in the generic kernel configs. Aside from that: > CONFIG_IPV6 is not a kernel config, it’s a tree-wide one. > > My idea was to keep the change as small as possible should we ever want to revert, while preventing further pointless bugreports[1]. > > Entirely removing the config option requires more invasive changes throughout the tree and the package repositories, which is significantly less trivial than this "first step". > > Cheers, > Thibaut > > [1] https://github.com/openwrt/openwrt/issues/9580 OK, in that case, let's await at least one more ACK and we can start with this. Thanks, Stijn
> On 18. Aug 2022, at 16:07, Stijn Tintel <stijn@linux-ipv6.be> wrote: > > On 18/08/2022 17:03, Thibaut wrote: >>> Le 18 août 2022 à 15:40, Stijn Tintel <stijn@linux-ipv6.be> a écrit : >>> >>> On 16/08/2022 20:00, Thibaut VARÈNE wrote: >>>> Disabling this build tunable breaks build and seems unrealistically >>>> likely to be fixed. >>>> >>>> This patch sets the related CONFIG to always true and removes the >>>> config prompt, keeping the change minimal, and, should !CONFIG_IPV6 ever >>>> be fixed, easy to revert. >>> If we're always going to set it to yes, just drop the option entirely and enable it in the generic kernel configs. Aside from that: >> CONFIG_IPV6 is not a kernel config, it’s a tree-wide one. >> >> My idea was to keep the change as small as possible should we ever want to revert, while preventing further pointless bugreports[1]. >> >> Entirely removing the config option requires more invasive changes throughout the tree and the package repositories, which is significantly less trivial than this "first step". >> >> Cheers, >> Thibaut >> >> [1] https://github.com/openwrt/openwrt/issues/9580 > > OK, in that case, let's await at least one more ACK and we can start > with this. ACK > > Thanks, > Stijn > > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
> On 18. Aug 2022, at 16:07, Stijn Tintel <stijn@linux-ipv6.be> wrote: > > On 18/08/2022 17:03, Thibaut wrote: >>> Le 18 août 2022 à 15:40, Stijn Tintel <stijn@linux-ipv6.be> a écrit : >>> >>> On 16/08/2022 20:00, Thibaut VARÈNE wrote: >>>> Disabling this build tunable breaks build and seems unrealistically >>>> likely to be fixed. >>>> >>>> This patch sets the related CONFIG to always true and removes the >>>> config prompt, keeping the change minimal, and, should !CONFIG_IPV6 ever >>>> be fixed, easy to revert. >>> If we're always going to set it to yes, just drop the option entirely and enable it in the generic kernel configs. Aside from that: >> CONFIG_IPV6 is not a kernel config, it’s a tree-wide one. >> >> My idea was to keep the change as small as possible should we ever want to revert, while preventing further pointless bugreports[1]. >> >> Entirely removing the config option requires more invasive changes throughout the tree and the package repositories, which is significantly less trivial than this "first step". >> >> Cheers, >> Thibaut >> >> [1] https://github.com/openwrt/openwrt/issues/9580 > > OK, in that case, let's await at least one more ACK and we can start > with this. Per request: Acked-by: Paul Spooren <mail@aparcar.org> > > Thanks, > Stijn > > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Hello all!! In my opinion, it would be better to try keeping this option available. Surely, !IPV6 is not a common scenario these days. But I think OpenWrt might be useful to catch bugs like the one fixed in commit 77fc73ac89be96ec8f39e8efa53885caa7cb3645 in the Linux kernel's git tree. So, for what it's worth, a NACKfrom me. Enrico On Thu, 18 Aug 2022, Paul Spooren wrote: > Date: Thu, 18 Aug 2022 17:33:42 > From: Paul Spooren <mail@aparcar.org> > To: Stijn Tintel <stijn@linux-ipv6.be> > Cc: Thibaut <hacks@slashdirt.org>, > openwrt-devel <openwrt-devel@lists.openwrt.org> > Subject: Re: [PATCH] build: always set CONFIG_IPV6 > > > >> On 18. Aug 2022, at 16:07, Stijn Tintel <stijn@linux-ipv6.be> wrote: >> >> On 18/08/2022 17:03, Thibaut wrote: >>>> Le 18 août 2022 à 15:40, Stijn Tintel <stijn@linux-ipv6.be> a écrit : >>>> >>>> On 16/08/2022 20:00, Thibaut VARÈNE wrote: >>>>> Disabling this build tunable breaks build and seems unrealistically >>>>> likely to be fixed. >>>>> >>>>> This patch sets the related CONFIG to always true and removes the >>>>> config prompt, keeping the change minimal, and, should !CONFIG_IPV6 ever >>>>> be fixed, easy to revert. >>>> If we're always going to set it to yes, just drop the option entirely and enable it in the generic kernel configs. Aside from that: >>> CONFIG_IPV6 is not a kernel config, it’s a tree-wide one. >>> >>> My idea was to keep the change as small as possible should we ever want to revert, while preventing further pointless bugreports[1]. >>> >>> Entirely removing the config option requires more invasive changes throughout the tree and the package repositories, which is significantly less trivial than this "first step". >>> >>> Cheers, >>> Thibaut >>> >>> [1] https://github.com/openwrt/openwrt/issues/9580 >> >> OK, in that case, let's await at least one more ACK and we can start >> with this. > > Per request: > > Acked-by: Paul Spooren <mail@aparcar.org> > >> >> Thanks, >> Stijn >> >> >> _______________________________________________ >> openwrt-devel mailing list >> openwrt-devel@lists.openwrt.org >> https://lists.openwrt.org/mailman/listinfo/openwrt-devel > > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
On Thu, 18 Aug 2022 at 20:07, Enrico Mioso <mrkiko.rs@gmail.com> wrote: > > Hello all!! > > In my opinion, it would be better to try keeping this option available. > Surely, !IPV6 is not a common scenario these days. But I think OpenWrt might be useful to catch bugs like the one fixed in commit 77fc73ac89be96ec8f39e8efa53885caa7cb3645 > in the Linux kernel's git tree. > > So, for what it's worth, a NACKfrom me. It's becoming increasingly hard to impossible to disable IPv6 in all of the SW that OpenWrt ships, that is the reason for this. More and more SW just doesn't have a way to disable IPv6 at all, so unless we want to carry even more patches this is kind of inevitable. It is 2022 after all, so ACK from me for what it's worth. Regards, Robert > > Enrico > > > On Thu, 18 Aug 2022, Paul Spooren wrote: > > > Date: Thu, 18 Aug 2022 17:33:42 > > From: Paul Spooren <mail@aparcar.org> > > To: Stijn Tintel <stijn@linux-ipv6.be> > > Cc: Thibaut <hacks@slashdirt.org>, > > openwrt-devel <openwrt-devel@lists.openwrt.org> > > Subject: Re: [PATCH] build: always set CONFIG_IPV6 > > > > > > > >> On 18. Aug 2022, at 16:07, Stijn Tintel <stijn@linux-ipv6.be> wrote: > >> > >> On 18/08/2022 17:03, Thibaut wrote: > >>>> Le 18 août 2022 à 15:40, Stijn Tintel <stijn@linux-ipv6.be> a écrit : > >>>> > >>>> On 16/08/2022 20:00, Thibaut VARÈNE wrote: > >>>>> Disabling this build tunable breaks build and seems unrealistically > >>>>> likely to be fixed. > >>>>> > >>>>> This patch sets the related CONFIG to always true and removes the > >>>>> config prompt, keeping the change minimal, and, should !CONFIG_IPV6 ever > >>>>> be fixed, easy to revert. > >>>> If we're always going to set it to yes, just drop the option entirely and enable it in the generic kernel configs. Aside from that: > >>> CONFIG_IPV6 is not a kernel config, it’s a tree-wide one. > >>> > >>> My idea was to keep the change as small as possible should we ever want to revert, while preventing further pointless bugreports[1]. > >>> > >>> Entirely removing the config option requires more invasive changes throughout the tree and the package repositories, which is significantly less trivial than this "first step". > >>> > >>> Cheers, > >>> Thibaut > >>> > >>> [1] https://github.com/openwrt/openwrt/issues/9580 > >> > >> OK, in that case, let's await at least one more ACK and we can start > >> with this. > > > > Per request: > > > > Acked-by: Paul Spooren <mail@aparcar.org> > > > >> > >> Thanks, > >> Stijn > >> > >> > >> _______________________________________________ > >> openwrt-devel mailing list > >> openwrt-devel@lists.openwrt.org > >> https://lists.openwrt.org/mailman/listinfo/openwrt-devel > > > > > > _______________________________________________ > > openwrt-devel mailing list > > openwrt-devel@lists.openwrt.org > > https://lists.openwrt.org/mailman/listinfo/openwrt-devel_______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
On 18. 08. 22 20:32, Robert Marko wrote: > On Thu, 18 Aug 2022 at 20:07, Enrico Mioso <mrkiko.rs@gmail.com> wrote: >> Hello all!! >> >> In my opinion, it would be better to try keeping this option available. >> Surely, !IPV6 is not a common scenario these days. But I think OpenWrt might be useful to catch bugs like the one fixed in commit 77fc73ac89be96ec8f39e8efa53885caa7cb3645 >> in the Linux kernel's git tree. >> >> So, for what it's worth, a NACKfrom me. > It's becoming increasingly hard to impossible to disable IPv6 in all > of the SW that OpenWrt ships, that is the reason for this. > More and more SW just doesn't have a way to disable IPv6 at all, so > unless we want to carry even more patches this is > kind of inevitable. > > It is 2022 after all, so ACK from me for what it's worth. +1 ACK from me as well. Thus: Acked-by: Josef.Schlehofer <pepe.schlehofer@gmail.com> > Regards, > Robert >> Enrico >> >> >> On Thu, 18 Aug 2022, Paul Spooren wrote: >> >>> Date: Thu, 18 Aug 2022 17:33:42 >>> From: Paul Spooren <mail@aparcar.org> >>> To: Stijn Tintel <stijn@linux-ipv6.be> >>> Cc: Thibaut <hacks@slashdirt.org>, >>> openwrt-devel <openwrt-devel@lists.openwrt.org> >>> Subject: Re: [PATCH] build: always set CONFIG_IPV6 >>> >>> >>> >>>> On 18. Aug 2022, at 16:07, Stijn Tintel <stijn@linux-ipv6.be> wrote: >>>> >>>> On 18/08/2022 17:03, Thibaut wrote: >>>>>> Le 18 août 2022 à 15:40, Stijn Tintel <stijn@linux-ipv6.be> a écrit : >>>>>> >>>>>> On 16/08/2022 20:00, Thibaut VARÈNE wrote: >>>>>>> Disabling this build tunable breaks build and seems unrealistically >>>>>>> likely to be fixed. >>>>>>> >>>>>>> This patch sets the related CONFIG to always true and removes the >>>>>>> config prompt, keeping the change minimal, and, should !CONFIG_IPV6 ever >>>>>>> be fixed, easy to revert. >>>>>> If we're always going to set it to yes, just drop the option entirely and enable it in the generic kernel configs. Aside from that: >>>>> CONFIG_IPV6 is not a kernel config, it’s a tree-wide one. >>>>> >>>>> My idea was to keep the change as small as possible should we ever want to revert, while preventing further pointless bugreports[1]. >>>>> >>>>> Entirely removing the config option requires more invasive changes throughout the tree and the package repositories, which is significantly less trivial than this "first step". >>>>> >>>>> Cheers, >>>>> Thibaut >>>>> >>>>> [1] https://github.com/openwrt/openwrt/issues/9580 >>>> OK, in that case, let's await at least one more ACK and we can start >>>> with this. >>> Per request: >>> >>> Acked-by: Paul Spooren <mail@aparcar.org> >>> >>>> Thanks, >>>> Stijn
Hi, > [...] > This patch sets the related CONFIG to always true and removes the > config prompt, keeping the change minimal, and, should !CONFIG_IPV6 ever > be fixed, easy to revert. > > Signed-off-by: Thibaut VARÈNE <hacks@slashdirt.org> Acked-by: Jo-Philipp Wich <jo@mein.io>
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software. On 8/18/22 20:32, Robert Marko wrote: > On Thu, 18 Aug 2022 at 20:07, Enrico Mioso <mrkiko.rs@gmail.com> wrote: >> >> Hello all!! >> >> In my opinion, it would be better to try keeping this option available. >> Surely, !IPV6 is not a common scenario these days. But I think OpenWrt might be useful to catch bugs like the one fixed in commit 77fc73ac89be96ec8f39e8efa53885caa7cb3645 >> in the Linux kernel's git tree. >> >> So, for what it's worth, a NACKfrom me. > > It's becoming increasingly hard to impossible to disable IPv6 in all > of the SW that OpenWrt ships, that is the reason for this. > More and more SW just doesn't have a way to disable IPv6 at all, so > unless we want to carry even more patches this is > kind of inevitable. > > It is 2022 after all, so ACK from me for what it's worth. Would it make sense to simply always build with IPV6 support and have the CONFIG_IPV6 flag repurposed to have the defaults for the network interfaces and kernel sysctls set to disable IPV6 as much as possible? This might make sense in environments where any IPV6 support is unwanted. Still many people have no IPV6 at home or at work and hence better not have it configured at their local network nor router. Rewgards, Bas. > Regards, > Robert >> >> Enrico >> >> >> On Thu, 18 Aug 2022, Paul Spooren wrote: >> >>> Date: Thu, 18 Aug 2022 17:33:42 >>> From: Paul Spooren <mail@aparcar.org> >>> To: Stijn Tintel <stijn@linux-ipv6.be> >>> Cc: Thibaut <hacks@slashdirt.org>, >>> openwrt-devel <openwrt-devel@lists.openwrt.org> >>> Subject: Re: [PATCH] build: always set CONFIG_IPV6 >>> >>> >>> >>>> On 18. Aug 2022, at 16:07, Stijn Tintel <stijn@linux-ipv6.be> wrote: >>>> >>>> On 18/08/2022 17:03, Thibaut wrote: >>>>>> Le 18 août 2022 à 15:40, Stijn Tintel <stijn@linux-ipv6.be> a écrit : >>>>>> >>>>>> On 16/08/2022 20:00, Thibaut VARÈNE wrote: >>>>>>> Disabling this build tunable breaks build and seems unrealistically >>>>>>> likely to be fixed. >>>>>>> >>>>>>> This patch sets the related CONFIG to always true and removes the >>>>>>> config prompt, keeping the change minimal, and, should !CONFIG_IPV6 ever >>>>>>> be fixed, easy to revert. >>>>>> If we're always going to set it to yes, just drop the option entirely and enable it in the generic kernel configs. Aside from that: >>>>> CONFIG_IPV6 is not a kernel config, it’s a tree-wide one. >>>>> >>>>> My idea was to keep the change as small as possible should we ever want to revert, while preventing further pointless bugreports[1]. >>>>> >>>>> Entirely removing the config option requires more invasive changes throughout the tree and the package repositories, which is significantly less trivial than this "first step". >>>>> >>>>> Cheers, >>>>> Thibaut >>>>> >>>>> [1] https://github.com/openwrt/openwrt/issues/9580 >>>> >>>> OK, in that case, let's await at least one more ACK and we can start >>>> with this. >>> >>> Per request: >>> >>> Acked-by: Paul Spooren <mail@aparcar.org> >>> >>>> >>>> Thanks, >>>> Stijn >>>> >>>> >>>> _______________________________________________ >>>> openwrt-devel mailing list >>>> openwrt-devel@lists.openwrt.org >>>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel >>> >>> >>> _______________________________________________ >>> openwrt-devel mailing list >>> openwrt-devel@lists.openwrt.org >>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel_______________________________________________ >> openwrt-devel mailing list >> openwrt-devel@lists.openwrt.org >> https://lists.openwrt.org/mailman/listinfo/openwrt-devel > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
I find strange any conversation around disabling IPv6 these days, regardless the reason. It should be mandatory even if some ISPs don't have it enabled yet. How can one say that IPv6 may be unwanted ? If there is such scenario there is something very wrong there. What should be fixed is the lack of IPv6 in the network or from the ISP, not to remove it from any builds, specially in a OpenWrt build. There is not harm to keep it as is and if there is no IPv6 from the ISP nothing bad will happen to the router and everything else will remain working as expected in IPv4. If there was a reason in the past people were removing it was for devices with limited amount of flash (4MB generally), but I believe that any device with a minimal of 8MB it is already enough to not have to remove IPv6 from the build. Fernando On 22/08/2022 18:18, Bas Mevissen via openwrt-devel wrote: > The sender domain has a DMARC Reject/Quarantine policy which disallows > sending mailing list messages using the original "From" header. > > To mitigate this problem, the original message has been wrapped > automatically by the mailing list software. > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
diff --git a/config/Config-build.in b/config/Config-build.in index ef1a10c28d..400bf15665 100644 --- a/config/Config-build.in +++ b/config/Config-build.in @@ -150,11 +150,7 @@ menu "Global build settings" Adds -g3 to the CFLAGS. config IPV6 - bool - prompt "Enable IPv6 support in packages" - default y - help - Enables IPv6 support in kernel (builtin) and packages. + def_bool y comment "Stripping options"
Disabling this build tunable breaks build and seems unrealistically likely to be fixed. This patch sets the related CONFIG to always true and removes the config prompt, keeping the change minimal, and, should !CONFIG_IPV6 ever be fixed, easy to revert. Signed-off-by: Thibaut VARÈNE <hacks@slashdirt.org> --- config/Config-build.in | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)