Message ID | 20220220161718.730712-2-sander@svanheule.net |
---|---|
State | Accepted |
Headers | show
Return-Path: <openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ZatS+ndF; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=svanheule.net header.i=@svanheule.net header.a=rsa-sha256 header.s=mail1707 header.b=HrL35z6H; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=<UNKNOWN>) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4K1rHp35pJz9sFq for <incoming@patchwork.ozlabs.org>; Mon, 21 Feb 2022 03:20:06 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=06+QhObmIzSisSMYZy7xscMz4ER1AqcFcut4jdIeQEo=; b=ZatS+ndFHTyhcu tFYLlv8re7kDyEXZRlj/6/CJCkVBfENvxmjtgfLrSMski3QDDL1BrJsCQMFLZLBIIK7JNvjhXSwMd B7hO7M6ncpDGmlLLtBcx0eCgoBuR4sLzCpe43RFPgbyAh6+tmkSbjVwirJXXBYzbTP+eaKQlxoZto cyfQ148mrtfzjWWd4DXryJZwvNY2IABxXy32BRLpXNyxKynlA7j2u5JTjV1jgbcPOvpG58IvDzoTI UKQpUp+vovprvpGrndHyPDhVjD1MCxmbpgUkKgEplTqgb75E0JbPQt7x1hlD1pwIgHbOv4qcCYrGw drOFJiKHd5TGwZpZYweg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nLots-001ob9-QX; Sun, 20 Feb 2022 16:17:28 +0000 Received: from polaris.svanheule.net ([2a00:c98:2060:a004:1::200]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nLotp-001oZt-MI for openwrt-devel@lists.openwrt.org; Sun, 20 Feb 2022 16:17:27 +0000 Received: from terra.local.svanheule.net (104.153-136-217.adsl-dyn.isp.belgacom.be [217.136.153.104]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sander@svanheule.net) by polaris.svanheule.net (Postfix) with ESMTPSA id AAEEE2A5834; Sun, 20 Feb 2022 17:17:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svanheule.net; s=mail1707; t=1645373843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LdEH0z4rY1MIUPGakilu4we8/Kb7BdruSUKPAvd6B2o=; b=HrL35z6Hik4q75nePE9VvjxZWWgA5vFFgopMjewFY8pke2MuFYD+ITwA9Ij0dKgRQ1AwRK sE02QiIsVuMqkajCYut5zoRS4/jMklLEY7CeqEV6YedIl3w3YtCQ0Cbvyr4M6tO7nnvsEI 55xZicCApsQEHtV6CvipCxpJi8yCYGIOM2AQJ0qE6ubgttSH0zuJt4zz1GF7on+ScQTjAB jk1P6lcLo6xcVIdo9IrbPg5tpAP+XemkQkEHTDHMA6dSMunEHMhB/z7Vw64+BNdJT+6s7B dw03ClDQ6QW6jDuG896tb3F0bvro9AiU3A+sTNlf/ZNP1NWBvEFM7U7OVybjwA== From: Sander Vanheule <sander@svanheule.net> To: openwrt-devel@lists.openwrt.org Cc: Birger Koblitz <git@birger-koblitz.de>, Daniel Golle <daniel@makrotopia.org>, Sander Vanheule <sander@svanheule.net> Subject: [PATCH 1/3] realtek: clean up RTL930x timer DT node Date: Sun, 20 Feb 2022 17:17:16 +0100 Message-Id: <20220220161718.730712-2-sander@svanheule.net> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220220161718.730712-1-sander@svanheule.net> References: <20220220161718.730712-1-sander@svanheule.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220220_081725_899053_148DDA33 X-CRM114-Status: UNSURE ( 8.96 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.5 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The Realtek timer node for RTL930x doesn't have any child nodes, making the use of '#address-cells' quite pointless. It is also not an interrupt controller, meaning it makes no sense to define '#inter [...] Content analysis details: (-2.5 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [2a00:c98:2060:a004:1:0:0:200 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List <openwrt-devel.lists.openwrt.org> List-Unsubscribe: <https://lists.openwrt.org/mailman/options/openwrt-devel>, <mailto:openwrt-devel-request@lists.openwrt.org?subject=unsubscribe> List-Archive: <http://lists.openwrt.org/pipermail/openwrt-devel/> List-Post: <mailto:openwrt-devel@lists.openwrt.org> List-Help: <mailto:openwrt-devel-request@lists.openwrt.org?subject=help> List-Subscribe: <https://lists.openwrt.org/mailman/listinfo/openwrt-devel>, <mailto:openwrt-devel-request@lists.openwrt.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "openwrt-devel" <openwrt-devel-bounces@lists.openwrt.org> Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org |
Series |
realtek: Clean up RTL930x event timer
|
expand
|
diff --git a/target/linux/realtek/dts-5.10/rtl930x.dtsi b/target/linux/realtek/dts-5.10/rtl930x.dtsi index 31c021134261..0ac613454f58 100644 --- a/target/linux/realtek/dts-5.10/rtl930x.dtsi +++ b/target/linux/realtek/dts-5.10/rtl930x.dtsi @@ -59,9 +59,7 @@ rtl9300clock: rtl9300clock@3200 { compatible = "realtek,rtl9300clock"; - reg = <0xb8003200 0x10>; - #address-cells = <0>; - #interrupt-cells = <1>; + reg = <0x3200 0x10>; interrupt-parent = <&intc>; interrupts = <7 5>, <8 5>;
The Realtek timer node for RTL930x doesn't have any child nodes, making the use of '#address-cells' quite pointless. It is also not an interrupt controller, meaning it makes no sense to define '#interrupt-cells'. The I/O address for this node is also wrong, but this is hidden by the fact that the driver associated with this node bypasses the usual DT machinery and does it's own thing. Correct the address to have a sane value, even though it isn't actually used. Fixes: a75b9e3ecb61 ("realtek: Adding RTL930X sub-target") Signed-off-by: Sander Vanheule <sander@svanheule.net> --- target/linux/realtek/dts-5.10/rtl930x.dtsi | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)