From patchwork Wed Dec 8 21:42:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sander Vanheule X-Patchwork-Id: 1565500 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Xmx8rE5Y; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=svanheule.net header.i=@svanheule.net header.a=rsa-sha256 header.s=mail1707 header.b=3qyNtZjG; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4J8W412GwGz9sXS for ; Thu, 9 Dec 2021 08:47:43 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iptBCWxMVqkXbSh9SqqnsCb89rnlvYU0RAEBxsVkJVo=; b=Xmx8rE5YD4vbIK TVfQ+5anqXNMFBZKfLeHC03Wu2C9yvIYmEjAArZGnqDc1Z9WSYrx/R8+z+ZjZlyh6uKOQoXpHnigX m5Lf70LSnbg9mQ2/BJ0VfR+1rfJ/JGDxwMjTBdbCzd+ZLit1qC8qXFdUYowWMUNGwRjVJFIS5OdVf Ykjkr0wb3mikaQN8j+4ON9Rs8x48tzPH7o7SJs2zGJxCyOFoWncoRR95Hrg9zpoQfYA6vNcfOOnrs lT27yO3dF2RFC4AmzaIq1h7YXKzd46QqAPSrzlzp6aGWg9IOt/aXA3Ki8JmzvEmuw3UynJ5jVa4Vu 17TmBwhr3zthtCneNklg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mv4jh-00EHZX-PN; Wed, 08 Dec 2021 21:44:25 +0000 Received: from polaris.svanheule.net ([84.16.241.116]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mv4in-00EHPf-QY for openwrt-devel@lists.openwrt.org; Wed, 08 Dec 2021 21:43:32 +0000 Received: from terra.local.svanheule.net (unknown [IPv6:2a02:a03f:eafe:c901:4e6f:a4e9:6d71:a770]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sander@svanheule.net) by polaris.svanheule.net (Postfix) with ESMTPSA id 4FB9E27E13C; Wed, 8 Dec 2021 22:43:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svanheule.net; s=mail1707; t=1638999801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=swVO1E4vHoxbGY7OumgBfxBp9Mtph3i6uDvHHDsMI5M=; b=3qyNtZjGwyGKcuuzaXh/M+hBtpyEoELAORkD6um0hZfH5aCFG32OSXboC9c9/npHe1awMk VdsNcXX+MEJO3ZlDmzvizBnW+PxEvlBSQDtJnIqYkQj3fwaNga/GjY8mBAdhDM3Ch1XkWU rCMLeMK6NUYhqv+8K3QRXE1L9JEz40xkQWeCrkoAQmYsoCZPycJVcVZDjy6ekQ/3zPRQ1l ZGcRPuqbcm4KTU+hJpPC1AFJJcZ8iIbLyUgjK69aIUwuoW5G3QKPHhMeMzEMQVKA6wp7fy /JoSizrhibc+fLe8n2Wszd2RujkIdhmfUo51AA/TK6+dm0OZVxhBlJCAt2++1g== From: Sander Vanheule To: openwrt-devel@lists.openwrt.org Cc: INAGAKI Hiroshi , Birger Koblitz , John Crispin , Sander Vanheule Subject: [PATCH 03/13] realtek: remove hardcoded sys-led configurations Date: Wed, 8 Dec 2021 22:42:59 +0100 Message-Id: <20211208214309.233041-4-sander@svanheule.net> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211208214309.233041-1-sander@svanheule.net> References: <20211208214309.233041-1-sander@svanheule.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211208_134330_032658_B197BD3B X-CRM114-Status: UNSURE ( 7.49 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.5 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Disabling the sys-led peripheral should be done via a pin controller, for which pinctrl-single nodes are present in the platform DTSI files. Drop the hardcoded per-platform sys-led configurations, and [...] Content analysis details: (-2.5 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [84.16.241.116 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Disabling the sys-led peripheral should be done via a pin controller, for which pinctrl-single nodes are present in the platform DTSI files. Drop the hardcoded per-platform sys-led configurations, and require things to be set up in the devicetree. Co-developed-by: INAGAKI Hiroshi Signed-off-by: INAGAKI Hiroshi Signed-off-by: Sander Vanheule --- .../files-5.10/arch/mips/rtl838x/setup.c | 40 ------------------- 1 file changed, 40 deletions(-) diff --git a/target/linux/realtek/files-5.10/arch/mips/rtl838x/setup.c b/target/linux/realtek/files-5.10/arch/mips/rtl838x/setup.c index 55419c7b0b7a..df29b76bbf0f 100644 --- a/target/linux/realtek/files-5.10/arch/mips/rtl838x/setup.c +++ b/target/linux/realtek/files-5.10/arch/mips/rtl838x/setup.c @@ -28,31 +28,6 @@ extern struct rtl83xx_soc_info soc_info; -static void __init rtl838x_setup(void) -{ - /* Setup System LED. Bit 15 then allows to toggle it */ - sw_w32_mask(0, 3 << 16, RTL838X_LED_GLB_CTRL); -} - -static void __init rtl839x_setup(void) -{ - /* Setup System LED. Bit 14 of RTL839X_LED_GLB_CTRL then allows to toggle it */ - sw_w32_mask(0, 3 << 15, RTL839X_LED_GLB_CTRL); -} - -static void __init rtl930x_setup(void) -{ - if (soc_info.id == 0x9302) - sw_w32_mask(0, 3 << 13, RTL9302_LED_GLB_CTRL); - else - sw_w32_mask(0, 3 << 13, RTL930X_LED_GLB_CTRL); -} - -static void __init rtl931x_setup(void) -{ - sw_w32_mask(0, 3 << 12, RTL931X_LED_GLB_CTRL); -} - void __init plat_mem_setup(void) { void *dtb; @@ -71,21 +46,6 @@ void __init plat_mem_setup(void) * parsed resulting in our memory appearing */ __dt_setup_arch(dtb); - - switch (soc_info.family) { - case RTL8380_FAMILY_ID: - rtl838x_setup(); - break; - case RTL8390_FAMILY_ID: - rtl839x_setup(); - break; - case RTL9300_FAMILY_ID: - rtl930x_setup(); - break; - case RTL9310_FAMILY_ID: - rtl931x_setup(); - break; - } } void __init plat_time_init(void)