diff mbox series

layerscape: mkits-multiple-config: fail on invalid arguments

Message ID 20211025081715.16080-1-zajec5@gmail.com
State Accepted
Delegated to: Rafał Miłecki
Headers show
Series layerscape: mkits-multiple-config: fail on invalid arguments | expand

Commit Message

Rafał Miłecki Oct. 25, 2021, 8:17 a.m. UTC 
From: Rafał Miłecki <rafal@milecki.pl>

Fail if arguments couldn't be parsed and print unrecognized part. It's
important when running it from script with dynamic values. Missing value
could result in skipping argument and silent failures (unexpected its).

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 target/linux/layerscape/image/mkits-multiple-config.sh | 5 +++++
 1 file changed, 5 insertions(+)
diff mbox series

Patch

diff --git a/target/linux/layerscape/image/mkits-multiple-config.sh b/target/linux/layerscape/image/mkits-multiple-config.sh
index 68870686c5..b2d8f4ef7f 100755
--- a/target/linux/layerscape/image/mkits-multiple-config.sh
+++ b/target/linux/layerscape/image/mkits-multiple-config.sh
@@ -198,6 +198,11 @@  parse_args() {
 			usage;;
 		esac
 	done
+	shift $(($OPTIND - 1))
+	[ $# -gt 0 ] && {
+		echo "Failed to parse all passed arguments (unrecognized: \"$@\")"
+		exit 1
+	}
 	[ -n "${OUTPUT}" ] || OUTPUT=fitimage.its
 	[ -n "${VERSION}" ] || VERSION="Unknown"
 	[ -n "${ARCH}" ] || ARCH=arm