| Message ID | 20211023195640.7991-1-arinc.unal@arinc9.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/2] bcm53xx: remove extsw interface on Linksys EA9500 | expand |
On 2021-10-23 21:56, Arınç ÜNAL wrote: > Remove extsw interface from the bridge as it's used as a master > interface by the DSA driver. According to Vivek it's required, I explicitly asked about it: https://forum.openwrt.org/t/build-for-linksys-ea9500/1817/984
On 23/10/2021 23:35, Rafał Miłecki wrote: > On 2021-10-23 21:56, Arınç ÜNAL wrote: >> Remove extsw interface from the bridge as it's used as a master >> interface by the DSA driver. > > According to Vivek it's required, I explicitly asked about it: > https://forum.openwrt.org/t/build-for-linksys-ea9500/1817/984 I suspect the reason for this happening is: > # For kernels earlier than v5.12, the master interface needs to be > # brought up manually before the slave ports.https://www.kernel.org/doc/html/latest/networking/dsa/configuration.html#configuration-with-tagging-support I have a branch running kernel 5.15 on bcm53xx on Asus RT-AC88U. All interfaces work fine without adding extsw to the bridge. https://github.com/arinc9/openwrt/commit/26019530962967079c3772dc3a2ee57b68662bab A fix should be implemented in a different way than including the extsw interface on the bridge (an initscript would do). Arınç
On 2021-10-23 23:09, Arınç ÜNAL wrote: > On 23/10/2021 23:35, Rafał Miłecki wrote: >> On 2021-10-23 21:56, Arınç ÜNAL wrote: >>> Remove extsw interface from the bridge as it's used as a master >>> interface by the DSA driver. >> >> According to Vivek it's required, I explicitly asked about it: >> https://forum.openwrt.org/t/build-for-linksys-ea9500/1817/984 > > I suspect the reason for this happening is: >> # For kernels earlier than v5.12, the master interface needs to be >> # brought up manually before the slave >> ports.https://www.kernel.org/doc/html/latest/networking/dsa/configuration.html#configuration-with-tagging-support > > I have a branch running kernel 5.15 on bcm53xx on Asus RT-AC88U. All > interfaces work fine without adding extsw to the bridge. > https://github.com/arinc9/openwrt/commit/26019530962967079c3772dc3a2ee57b68662bab > > A fix should be implemented in a different way than including the > extsw interface on the bridge (an initscript would do). I think we have backported related commit, unless it's a different one. See commit 2e17c710954b ("kernel: Backport patch to automatically bring up DSA master when opening user port") I prefer the right fix of course, but you need to point me to it first :)
On 24/10/2021 00:14, Rafał Miłecki wrote: > On 2021-10-23 23:09, Arınç ÜNAL wrote: >> On 23/10/2021 23:35, Rafał Miłecki wrote: >>> On 2021-10-23 21:56, Arınç ÜNAL wrote: >>>> Remove extsw interface from the bridge as it's used as a master >>>> interface by the DSA driver. >>> >>> According to Vivek it's required, I explicitly asked about it: >>> https://forum.openwrt.org/t/build-for-linksys-ea9500/1817/984 >> >> I suspect the reason for this happening is: >>> # For kernels earlier than v5.12, the master interface needs to be >>> # brought up manually before the slave >>> ports.https://www.kernel.org/doc/html/latest/networking/dsa/configuration.html#configuration-with-tagging-support >>> >> >> I have a branch running kernel 5.15 on bcm53xx on Asus RT-AC88U. All >> interfaces work fine without adding extsw to the bridge. >> https://github.com/arinc9/openwrt/commit/26019530962967079c3772dc3a2ee57b68662bab >> >> >> A fix should be implemented in a different way than including the >> extsw interface on the bridge (an initscript would do). > > I think we have backported related commit, unless it's a different one. > > See commit 2e17c710954b ("kernel: Backport patch to automatically bring > up DSA master when opening user port") > > I prefer the right fix of course, but you need to point me to it first :) I'm going to investigate further with Vivek. Should I send the second patch in the series as a single one?
On 23/10/2021 22:31, Arınç ÜNAL wrote: > On 24/10/2021 00:14, Rafał Miłecki wrote: >> On 2021-10-23 23:09, Arınç ÜNAL wrote: >>> On 23/10/2021 23:35, Rafał Miłecki wrote: >>>> On 2021-10-23 21:56, Arınç ÜNAL wrote: >>>>> Remove extsw interface from the bridge as it's used as a master >>>>> interface by the DSA driver. >>>> >>>> According to Vivek it's required, I explicitly asked about it: >>>> https://forum.openwrt.org/t/build-for-linksys-ea9500/1817/984 >>> >>> I suspect the reason for this happening is: >>>> # For kernels earlier than v5.12, the master interface needs to be >>>> # brought up manually before the slave >>>> ports.https://www.kernel.org/doc/html/latest/networking/dsa/configuration.html#configuration-with-tagging-support >>>> >>> >>> I have a branch running kernel 5.15 on bcm53xx on Asus RT-AC88U. All >>> interfaces work fine without adding extsw to the bridge. >>> https://github.com/arinc9/openwrt/commit/26019530962967079c3772dc3a2ee57b68662bab >>> >>> >>> A fix should be implemented in a different way than including the >>> extsw interface on the bridge (an initscript would do). >> >> I think we have backported related commit, unless it's a different one. >> >> See commit 2e17c710954b ("kernel: Backport patch to automatically >> bring up DSA master when opening user port") >> >> I prefer the right fix of course, but you need to point me to it first :) > > I'm going to investigate further with Vivek. Should I send the second > patch in the series as a single one? For reference, no additional config is needed for the MX65. sw0/sw1 come up by themselves[1]. https://github.com/clayface/openwrt/commit/41203464f26ac93d06d5134e899dfd47bd4aa6a4#diff-52f037ccd42c5073f1aec02c5e0b33768c675b39cf04f244319db09e7a03539f
This patch series can be disregarded as the first patch in this series causes a bigger issue than the one it fixes. Ref: https://forum.openwrt.org/t/build-for-linksys-ea9500/1817/999 Arınç On 23/10/2021 22:56, Arınç ÜNAL wrote: > Remove extsw interface from the bridge as it's used as a master interface by the DSA driver. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- > target/linux/bcm53xx/base-files/etc/board.d/02_network | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/linux/bcm53xx/base-files/etc/board.d/02_network b/target/linux/bcm53xx/base-files/etc/board.d/02_network > index 6d970e1d0e3a..0f391f5e2d38 100644 > --- a/target/linux/bcm53xx/base-files/etc/board.d/02_network > +++ b/target/linux/bcm53xx/base-files/etc/board.d/02_network > @@ -14,7 +14,7 @@ bcm53xx_setup_interfaces() > ucidef_set_interfaces_lan_wan "lan1 lan2 lan3" "wan" > ;; > linksys,panamera) > - ucidef_set_interfaces_lan_wan "lan1 lan2 lan3 lan4 lan5 lan6 lan7 lan8 extsw" "wan" > + ucidef_set_interfaces_lan_wan "lan1 lan2 lan3 lan4 lan5 lan6 lan7 lan8" "wan" > ;; > luxul,xap-1610-v1) > ucidef_set_interface_lan "poe lan" "dhcp" >
diff --git a/target/linux/bcm53xx/base-files/etc/board.d/02_network b/target/linux/bcm53xx/base-files/etc/board.d/02_network index 6d970e1d0e3a..0f391f5e2d38 100644 --- a/target/linux/bcm53xx/base-files/etc/board.d/02_network +++ b/target/linux/bcm53xx/base-files/etc/board.d/02_network @@ -14,7 +14,7 @@ bcm53xx_setup_interfaces() ucidef_set_interfaces_lan_wan "lan1 lan2 lan3" "wan" ;; linksys,panamera) - ucidef_set_interfaces_lan_wan "lan1 lan2 lan3 lan4 lan5 lan6 lan7 lan8 extsw" "wan" + ucidef_set_interfaces_lan_wan "lan1 lan2 lan3 lan4 lan5 lan6 lan7 lan8" "wan" ;; luxul,xap-1610-v1) ucidef_set_interface_lan "poe lan" "dhcp"
Remove extsw interface from the bridge as it's used as a master interface by the DSA driver. Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> --- target/linux/bcm53xx/base-files/etc/board.d/02_network | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)