diff mbox series

fstools: libblkid-tiny: fix invalid open syscall return check

Message ID 20210802095000.3601969-1-daniel@dd-wrt.com
State Accepted
Delegated to: Daniel Golle
Headers show
Series fstools: libblkid-tiny: fix invalid open syscall return check | expand

Commit Message

Daniel Danzberger Aug. 2, 2021, 9:50 a.m. UTC 
open() returns -1 on error, not 0 (stdin).

Signed-off-by: Daniel Danzberger <daniel@dd-wrt.com>
---
 libblkid-tiny/libblkid-tiny.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/libblkid-tiny/libblkid-tiny.c b/libblkid-tiny/libblkid-tiny.c
index 18db4ef..6e8cd81 100644
--- a/libblkid-tiny/libblkid-tiny.c
+++ b/libblkid-tiny/libblkid-tiny.c
@@ -196,7 +196,7 @@  int probe_block(char *block, struct blkid_struct_probe *pr)
 
 	pr->err = -1;
 	pr->fd = open(block, O_RDONLY);
-	if (!pr->fd)
+	if (pr->fd == -1)
 		return -1;
 
 	for (i = 0; i < ARRAY_SIZE(idinfos); i++) {