Message ID | 20210730175609.4172518-1-stijn@linux-ipv6.be |
---|---|
State | Changes Requested, archived |
Delegated to: | Stijn Tintel |
Headers | show |
Series | kernel: set CONFIG_RCU_FANOUT=64 for 64bit targets | expand |
On 30/07/2021 20:56, Stijn Tintel wrote: > The generic config has CONFIG_RCU_EXPERT=y, which exposes > CONFIG_RCU_FANOUT. This is set to 32 in the generic config, but the > default for 64bit kernels is 64. This causes a warning during boot: > > [ 0.000000] rcu: CONFIG_RCU_FANOUT set to non-default value of 32. > > Set CONFIG_RCU_FANOUT=64 in kernel configs of 64bit targets, unless the > target config has disabled CONFIG_RCU_EXPERT. Alternatively we could disable CONFIG_RCU_EXPERT entirely. Not sure why it was enabled in the first place. If anyone knows, please do share. Stijn
Hi, Stijn, On Sat, 31 Jul 2021 at 11:01, Stijn Tintel <stijn@linux-ipv6.be> wrote: > > Alternatively we could disable CONFIG_RCU_EXPERT entirely. Not sure why > it was enabled in the first place. If anyone knows, please do share. Yes, please! Personal note, CONFIG_RCU_EXPERT is one of those things I don't even touch. The (performance) breakage potential is big and I really trust the defaults are sane. Just disable it. Thanks, Rui
diff --git a/target/linux/armvirt/64/config-5.10 b/target/linux/armvirt/64/config-5.10 index 51f3c3c952..7cd542fc81 100644 --- a/target/linux/armvirt/64/config-5.10 +++ b/target/linux/armvirt/64/config-5.10 @@ -130,6 +130,7 @@ CONFIG_POWER_RESET_VEXPRESS=y CONFIG_POWER_SUPPLY=y CONFIG_QUEUED_RWLOCKS=y CONFIG_QUEUED_SPINLOCKS=y +CONFIG_RCU_FANOUT=64 CONFIG_REGMAP=y CONFIG_REGMAP_MMIO=y CONFIG_RODATA_FULL_DEFAULT_ENABLED=y diff --git a/target/linux/armvirt/64/config-5.4 b/target/linux/armvirt/64/config-5.4 index 2317dcd39d..464c7bfaa3 100644 --- a/target/linux/armvirt/64/config-5.4 +++ b/target/linux/armvirt/64/config-5.4 @@ -134,6 +134,7 @@ CONFIG_POWER_RESET_VEXPRESS=y CONFIG_POWER_SUPPLY=y CONFIG_QUEUED_RWLOCKS=y CONFIG_QUEUED_SPINLOCKS=y +CONFIG_RCU_FANOUT=64 CONFIG_REGMAP=y CONFIG_REGMAP_MMIO=y CONFIG_RODATA_FULL_DEFAULT_ENABLED=y diff --git a/target/linux/bcm27xx/bcm2710/config-5.4 b/target/linux/bcm27xx/bcm2710/config-5.4 index 27884a0567..b0718a5f8d 100644 --- a/target/linux/bcm27xx/bcm2710/config-5.4 +++ b/target/linux/bcm27xx/bcm2710/config-5.4 @@ -364,6 +364,7 @@ CONFIG_RASPBERRYPI_POWER=y CONFIG_RATIONAL=y # CONFIG_RAVE_SP_CORE is not set CONFIG_RAW_DRIVER=y +CONFIG_RCU_FANOUT=64 CONFIG_RCU_NEED_SEGCBLIST=y CONFIG_RCU_STALL_COMMON=y CONFIG_REFCOUNT_FULL=y diff --git a/target/linux/bcm27xx/bcm2711/config-5.4 b/target/linux/bcm27xx/bcm2711/config-5.4 index c82ae44942..40af97965f 100644 --- a/target/linux/bcm27xx/bcm2711/config-5.4 +++ b/target/linux/bcm27xx/bcm2711/config-5.4 @@ -376,6 +376,7 @@ CONFIG_RASPBERRYPI_POWER=y CONFIG_RATIONAL=y # CONFIG_RAVE_SP_CORE is not set CONFIG_RAW_DRIVER=y +CONFIG_RCU_FANOUT=64 CONFIG_RCU_NEED_SEGCBLIST=y CONFIG_RCU_STALL_COMMON=y CONFIG_REFCOUNT_FULL=y diff --git a/target/linux/bcm4908/config-5.4 b/target/linux/bcm4908/config-5.4 index 6f43a822c8..9076ae8cc2 100644 --- a/target/linux/bcm4908/config-5.4 +++ b/target/linux/bcm4908/config-5.4 @@ -183,6 +183,7 @@ CONFIG_POWER_SUPPLY=y CONFIG_QUEUED_RWLOCKS=y CONFIG_QUEUED_SPINLOCKS=y CONFIG_RATIONAL=y +CONFIG_RCU_FANOUT=64 CONFIG_RCU_NEED_SEGCBLIST=y CONFIG_RCU_STALL_COMMON=y CONFIG_REFCOUNT_FULL=y diff --git a/target/linux/malta/be64/config-default b/target/linux/malta/be64/config-default index ef044bb8ca..7d22120c14 100644 --- a/target/linux/malta/be64/config-default +++ b/target/linux/malta/be64/config-default @@ -7,3 +7,4 @@ CONFIG_CPU_MIPS64_R2=y # CONFIG_MIPS32_N32 is not set # CONFIG_MIPS32_O32 is not set # CONFIG_MIPS_VA_BITS_48 is not set +CONFIG_RCU_FANOUT=64 diff --git a/target/linux/malta/le64/config-default b/target/linux/malta/le64/config-default index 69e5387a1f..72ed33365f 100644 --- a/target/linux/malta/le64/config-default +++ b/target/linux/malta/le64/config-default @@ -6,3 +6,4 @@ CONFIG_CPU_MIPS64_R2=y # CONFIG_MIPS32_N32 is not set # CONFIG_MIPS32_O32 is not set # CONFIG_MIPS_VA_BITS_48 is not set +CONFIG_RCU_FANOUT=64 diff --git a/target/linux/mediatek/mt7622/config-5.10 b/target/linux/mediatek/mt7622/config-5.10 index caf0293f41..9d039212b0 100644 --- a/target/linux/mediatek/mt7622/config-5.10 +++ b/target/linux/mediatek/mt7622/config-5.10 @@ -368,6 +368,7 @@ CONFIG_QUEUED_SPINLOCKS=y CONFIG_RAS=y CONFIG_RATIONAL=y # CONFIG_RAVE_SP_CORE is not set +CONFIG_RCU_FANOUT=64 CONFIG_RCU_NEED_SEGCBLIST=y CONFIG_RCU_STALL_COMMON=y CONFIG_REALTEK_PHY=y diff --git a/target/linux/mvebu/cortexa53/config-5.10 b/target/linux/mvebu/cortexa53/config-5.10 index 24f26474bc..6b343d4658 100644 --- a/target/linux/mvebu/cortexa53/config-5.10 +++ b/target/linux/mvebu/cortexa53/config-5.10 @@ -66,6 +66,7 @@ CONFIG_POWER_RESET=y CONFIG_POWER_SUPPLY=y CONFIG_QUEUED_RWLOCKS=y CONFIG_QUEUED_SPINLOCKS=y +CONFIG_RCU_FANOUT=64 CONFIG_REGULATOR_GPIO=y CONFIG_RODATA_FULL_DEFAULT_ENABLED=y CONFIG_SPARSEMEM=y diff --git a/target/linux/mvebu/cortexa53/config-5.4 b/target/linux/mvebu/cortexa53/config-5.4 index b88de78ee4..00943648f5 100644 --- a/target/linux/mvebu/cortexa53/config-5.4 +++ b/target/linux/mvebu/cortexa53/config-5.4 @@ -75,6 +75,7 @@ CONFIG_POWER_RESET=y CONFIG_POWER_SUPPLY=y CONFIG_QUEUED_RWLOCKS=y CONFIG_QUEUED_SPINLOCKS=y +CONFIG_RCU_FANOUT=64 CONFIG_REGULATOR_GPIO=y CONFIG_RODATA_FULL_DEFAULT_ENABLED=y CONFIG_SPARSEMEM=y diff --git a/target/linux/mvebu/cortexa72/config-5.10 b/target/linux/mvebu/cortexa72/config-5.10 index 1d8affc290..f5a9881e25 100644 --- a/target/linux/mvebu/cortexa72/config-5.10 +++ b/target/linux/mvebu/cortexa72/config-5.10 @@ -74,6 +74,7 @@ CONFIG_POWER_SUPPLY=y CONFIG_QUEUED_RWLOCKS=y CONFIG_QUEUED_SPINLOCKS=y CONFIG_RAS=y +CONFIG_RCU_FANOUT=64 CONFIG_REGULATOR_GPIO=y # CONFIG_RODATA_FULL_DEFAULT_ENABLED is not set CONFIG_SPARSEMEM=y diff --git a/target/linux/mvebu/cortexa72/config-5.4 b/target/linux/mvebu/cortexa72/config-5.4 index 12b2ea399c..99c8cc2e40 100644 --- a/target/linux/mvebu/cortexa72/config-5.4 +++ b/target/linux/mvebu/cortexa72/config-5.4 @@ -83,6 +83,7 @@ CONFIG_POWER_SUPPLY=y CONFIG_QUEUED_RWLOCKS=y CONFIG_QUEUED_SPINLOCKS=y CONFIG_RAS=y +CONFIG_RCU_FANOUT=64 CONFIG_REGULATOR_GPIO=y # CONFIG_RODATA_FULL_DEFAULT_ENABLED is not set CONFIG_SPARSEMEM=y diff --git a/target/linux/octeon/config-5.10 b/target/linux/octeon/config-5.10 index 20c4a354d9..1f449a2773 100644 --- a/target/linux/octeon/config-5.10 +++ b/target/linux/octeon/config-5.10 @@ -198,6 +198,7 @@ CONFIG_POSIX_MQUEUE_SYSCTL=y CONFIG_QUEUED_RWLOCKS=y CONFIG_QUEUED_SPINLOCKS=y CONFIG_RAS=y +CONFIG_RCU_FANOUT=64 CONFIG_RCU_NEED_SEGCBLIST=y CONFIG_RCU_STALL_COMMON=y CONFIG_RELAY=y diff --git a/target/linux/octeon/config-5.4 b/target/linux/octeon/config-5.4 index f4fc948fcc..e2bc033db1 100644 --- a/target/linux/octeon/config-5.4 +++ b/target/linux/octeon/config-5.4 @@ -192,6 +192,7 @@ CONFIG_POSIX_MQUEUE_SYSCTL=y CONFIG_QUEUED_RWLOCKS=y CONFIG_QUEUED_SPINLOCKS=y CONFIG_RAS=y +CONFIG_RCU_FANOUT=64 CONFIG_RCU_NEED_SEGCBLIST=y CONFIG_RCU_STALL_COMMON=y CONFIG_RELAY=y diff --git a/target/linux/octeontx/config-5.4 b/target/linux/octeontx/config-5.4 index daecd33715..a3798bdbfc 100644 --- a/target/linux/octeontx/config-5.4 +++ b/target/linux/octeontx/config-5.4 @@ -480,6 +480,7 @@ CONFIG_QUEUED_SPINLOCKS=y CONFIG_RAS=y CONFIG_RATIONAL=y # CONFIG_RAVE_SP_CORE is not set +CONFIG_RCU_FANOUT=64 CONFIG_RCU_NEED_SEGCBLIST=y CONFIG_RCU_STALL_COMMON=y # CONFIG_READ_ONLY_THP_FOR_FS is not set diff --git a/target/linux/sunxi/cortexa53/config-5.4 b/target/linux/sunxi/cortexa53/config-5.4 index 1d8fd49d43..5bf05268b7 100644 --- a/target/linux/sunxi/cortexa53/config-5.4 +++ b/target/linux/sunxi/cortexa53/config-5.4 @@ -136,6 +136,7 @@ CONFIG_PINCTRL_SUN50I_H6=y CONFIG_PINCTRL_SUN50I_H6_R=y CONFIG_QUEUED_RWLOCKS=y CONFIG_QUEUED_SPINLOCKS=y +CONFIG_RCU_FANOUT=64 CONFIG_RODATA_FULL_DEFAULT_ENABLED=y # CONFIG_SND_SUN50I_CODEC_ANALOG is not set CONFIG_SOUND_OSS_CORE_PRECLAIM=y diff --git a/target/linux/uml/config/x86_64 b/target/linux/uml/config/x86_64 index 1d35dda2dc..9b0010b708 100644 --- a/target/linux/uml/config/x86_64 +++ b/target/linux/uml/config/x86_64 @@ -91,6 +91,7 @@ CONFIG_POSIX_MQUEUE_SYSCTL=y # CONFIG_PROCESSOR_SELECT is not set CONFIG_PROC_PAGE_MONITOR=y CONFIG_PTY_CHAN=y +CONFIG_RCU_FANOUT=64 CONFIG_RD_BZIP2=y CONFIG_RD_GZIP=y CONFIG_RELAY=y diff --git a/target/linux/x86/64/config-5.10 b/target/linux/x86/64/config-5.10 index 6804d83519..6c80aca13e 100644 --- a/target/linux/x86/64/config-5.10 +++ b/target/linux/x86/64/config-5.10 @@ -364,6 +364,7 @@ CONFIG_PVH=y CONFIG_QUEUED_RWLOCKS=y CONFIG_QUEUED_SPINLOCKS=y CONFIG_RAS=y +CONFIG_RCU_FANOUT=64 CONFIG_RCU_NEED_SEGCBLIST=y CONFIG_RCU_STALL_COMMON=y CONFIG_RELAY=y diff --git a/target/linux/x86/64/config-5.4 b/target/linux/x86/64/config-5.4 index 50521a5148..71fdb3953a 100644 --- a/target/linux/x86/64/config-5.4 +++ b/target/linux/x86/64/config-5.4 @@ -370,6 +370,7 @@ CONFIG_QUEUED_RWLOCKS=y CONFIG_QUEUED_SPINLOCKS=y # CONFIG_RANDOMIZE_BASE is not set CONFIG_RAS=y +CONFIG_RCU_FANOUT=64 CONFIG_RCU_NEED_SEGCBLIST=y CONFIG_RCU_STALL_COMMON=y CONFIG_REGMAP=y
The generic config has CONFIG_RCU_EXPERT=y, which exposes CONFIG_RCU_FANOUT. This is set to 32 in the generic config, but the default for 64bit kernels is 64. This causes a warning during boot: [ 0.000000] rcu: CONFIG_RCU_FANOUT set to non-default value of 32. Set CONFIG_RCU_FANOUT=64 in kernel configs of 64bit targets, unless the target config has disabled CONFIG_RCU_EXPERT. Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be> --- target/linux/armvirt/64/config-5.10 | 1 + target/linux/armvirt/64/config-5.4 | 1 + target/linux/bcm27xx/bcm2710/config-5.4 | 1 + target/linux/bcm27xx/bcm2711/config-5.4 | 1 + target/linux/bcm4908/config-5.4 | 1 + target/linux/malta/be64/config-default | 1 + target/linux/malta/le64/config-default | 1 + target/linux/mediatek/mt7622/config-5.10 | 1 + target/linux/mvebu/cortexa53/config-5.10 | 1 + target/linux/mvebu/cortexa53/config-5.4 | 1 + target/linux/mvebu/cortexa72/config-5.10 | 1 + target/linux/mvebu/cortexa72/config-5.4 | 1 + target/linux/octeon/config-5.10 | 1 + target/linux/octeon/config-5.4 | 1 + target/linux/octeontx/config-5.4 | 1 + target/linux/sunxi/cortexa53/config-5.4 | 1 + target/linux/uml/config/x86_64 | 1 + target/linux/x86/64/config-5.10 | 1 + target/linux/x86/64/config-5.4 | 1 + 19 files changed, 19 insertions(+)