| Message ID | 20210603061855.673698-1-alexhenrie24@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Bauer |
| Headers | show |
| Series | ipq806x: fix LAN and WAN port assignments on TP-Link AD7200 | expand |
Hi Alex, On 6/3/21 8:18 AM, Alex Henrie wrote: > LAN port 4 was swapped with the WAN port and the remaining three LAN > ports were numbered in reverse order from their labels on the case. > > Fixes: 1a775a4fd033 ("ipq806x: add support for TP-Link Talon AD7200") > Signed-off-by: Alex Henrie <alexhenrie24@gmail.com> > --- > target/linux/ipq806x/base-files/etc/board.d/02_network | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/target/linux/ipq806x/base-files/etc/board.d/02_network b/target/linux/ipq806x/base-files/etc/board.d/02_network > index abdab89857..f0a852ece8 100644 > --- a/target/linux/ipq806x/base-files/etc/board.d/02_network > +++ b/target/linux/ipq806x/base-files/etc/board.d/02_network > @@ -56,7 +56,6 @@ nec,wg2600hp3) > "2:lan" "3:lan" "4:lan" "5:lan" "0@eth1" "1:wan" "6@eth0" > ;; > netgear,r7800 |\ > -tplink,ad7200 |\ > tplink,c2600) > ucidef_add_switch "switch0" \ > "1:lan:4" "2:lan:3" "3:lan:2" "4:lan:1" "6@eth1" "5:wan" "0@eth0" > @@ -71,6 +70,10 @@ qcom,ipq8064-db149) > ucidef_add_switch "switch0" \ > "1:lan" "2:lan" "3:lan" "4:lan" "6u@eth1" "5:wan" "0u@eth0" > ;; > +tplink,ad7200) > + ucidef_add_switch "switch0" \ > + "2:lan" "3:lan" "4:lan" "5:lan" "6@eth1" "1:wan" "0@eth0" I'd suggest "2:lan:1" "3:lan:2" "4:lan:3" "5:lan:4" "6@eth1" "1:wan" "0@eth0" so the case port numbering is explicitly added to the definition here. Looks good otherwise. Best David > + ;; > ubnt,unifi-ac-hd) > ucidef_set_interface_lan "eth0 eth1" > ;; >
diff --git a/target/linux/ipq806x/base-files/etc/board.d/02_network b/target/linux/ipq806x/base-files/etc/board.d/02_network index abdab89857..f0a852ece8 100644 --- a/target/linux/ipq806x/base-files/etc/board.d/02_network +++ b/target/linux/ipq806x/base-files/etc/board.d/02_network @@ -56,7 +56,6 @@ nec,wg2600hp3) "2:lan" "3:lan" "4:lan" "5:lan" "0@eth1" "1:wan" "6@eth0" ;; netgear,r7800 |\ -tplink,ad7200 |\ tplink,c2600) ucidef_add_switch "switch0" \ "1:lan:4" "2:lan:3" "3:lan:2" "4:lan:1" "6@eth1" "5:wan" "0@eth0" @@ -71,6 +70,10 @@ qcom,ipq8064-db149) ucidef_add_switch "switch0" \ "1:lan" "2:lan" "3:lan" "4:lan" "6u@eth1" "5:wan" "0u@eth0" ;; +tplink,ad7200) + ucidef_add_switch "switch0" \ + "2:lan" "3:lan" "4:lan" "5:lan" "6@eth1" "1:wan" "0@eth0" + ;; ubnt,unifi-ac-hd) ucidef_set_interface_lan "eth0 eth1" ;;
LAN port 4 was swapped with the WAN port and the remaining three LAN ports were numbered in reverse order from their labels on the case. Fixes: 1a775a4fd033 ("ipq806x: add support for TP-Link Talon AD7200") Signed-off-by: Alex Henrie <alexhenrie24@gmail.com> --- target/linux/ipq806x/base-files/etc/board.d/02_network | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)