diff mbox series

[v2] tplink-safeloader: fix product_name of TP-Link AD7200

Message ID 20210504030717.1722000-1-alexhenrie24@gmail.com
State Accepted
Delegated to: Petr Štetiar
Headers show
Series [v2] tplink-safeloader: fix product_name of TP-Link AD7200 | expand

Commit Message

Alex Henrie May 4, 2021, 3:07 a.m. UTC
The stock firmware does not accept firmware with "Talon" in the name.

Fixes: 1a775a4fd033 ("ipq806x: add support for TP-Link Talon AD7200")
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
---
 tools/firmware-utils/src/tplink-safeloader.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Petr Štetiar May 4, 2021, 7:35 a.m. UTC | #1
Alex Henrie <alexhenrie24@gmail.com> [2021-05-03 21:07:17]:

Hi,

> The stock firmware does not accept firmware with "Talon" in the name.

can you provide information about your stock firmware? Something others could
be able to reproduce, for example:

 Tested on latest firmware version 1.1.2 Build 20210125 rel.37999 flashed from
 c7v5_us-up-ver1-1-2-P1[20210125-rel37999]_2021-01-25_10.33.55.bin filename.

No need to send v3, just send this information as a reply to this email,
thanks.

> Fixes: 1a775a4fd033 ("ipq806x: add support for TP-Link Talon AD7200")
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
>  tools/firmware-utils/src/tplink-safeloader.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/firmware-utils/src/tplink-safeloader.c b/tools/firmware-utils/src/tplink-safeloader.c
> index b3d5c9151d..8a47e6a58f 100644
> --- a/tools/firmware-utils/src/tplink-safeloader.c
> +++ b/tools/firmware-utils/src/tplink-safeloader.c
> @@ -676,7 +676,7 @@ static struct device_info boards[] = {
>  		.vendor = "",
>  		.support_list =
>  			"SupportList:\r\n"
> -			"{product_name:Talon AD7200,product_ver:1.0.0,special_id:00000000}\r\n",
> +			"{product_name:AD7200,product_ver:1.0.0,special_id:00000000}\r\n",
>  		.part_trail = 0x00,
>  		.soft_ver = NULL,

Cheers,

Petr
Alex Henrie May 5, 2021, 6:12 a.m. UTC | #2
Tested on firmware version 1.0.10 Build 20160902 rel. 57400 which came
preinstalled, as well as latest firmware version 2.0.1 Build 20170103
rel.71053 flashed from
AD7200v1-up-ver2-0-1-P1[20170103-rel71053]_2017-01-04_10.08.28.bin.
diff mbox series

Patch

diff --git a/tools/firmware-utils/src/tplink-safeloader.c b/tools/firmware-utils/src/tplink-safeloader.c
index b3d5c9151d..8a47e6a58f 100644
--- a/tools/firmware-utils/src/tplink-safeloader.c
+++ b/tools/firmware-utils/src/tplink-safeloader.c
@@ -676,7 +676,7 @@  static struct device_info boards[] = {
 		.vendor = "",
 		.support_list =
 			"SupportList:\r\n"
-			"{product_name:Talon AD7200,product_ver:1.0.0,special_id:00000000}\r\n",
+			"{product_name:AD7200,product_ver:1.0.0,special_id:00000000}\r\n",
 		.part_trail = 0x00,
 		.soft_ver = NULL,