| Message ID | 20210503103947.3527098-1-baptiste@bitsofnetworks.org |
|---|---|
| State | Accepted |
| Delegated to: | Baptiste Jonglez |
| Headers | show |
| Series | ipq40xx: fix hard_config partition size on MikroTik hAP-ac2 | expand |
ACK > On 3 May 2021, at 12:39, Baptiste Jonglez <baptiste@bitsofnetworks.org> wrote: > > From: Baptiste Jonglez <git@bitsofnetworks.org> > > The routerbootparts driver dynamically discovers the location of MikroTik > partitions, but it cannot determine their size (except by extending them > up to the start of the next discovered partition). > > The hard_config partition has a default size of 0x1000 in the driver, > while it actually takes 0x2000 on the hAP-ac2. Set the correct size in > the hAP-ac2 DTS. > > On most devices, this isn't a problem as the actual data fits in 0x1000 > bytes. However, some devices have larger data that doesn't fit in 0x1000 > bytes. In any case, all devices seen so far have enough space for a > 0x2000 hard_config partition before the start of the dtb_config partition. > With the current 0x1000 size: > > 0x00000000e000-0x00000000f000 : "hard_config" > 0x000000010000-0x000000017bbc : "dtb_config" > > With this patch extending the size to 0x2000: > > 0x00000000e000-0x000000010000 : "hard_config" > 0x000000010000-0x000000017bbc : "dtb_config" > > Other ipq40xx boards may need the same fix but it needs testing. > > References: https://forum.openwrt.org/t/support-for-mikrotik-hap-ac2/23333/324 > Signed-off-by: Baptiste Jonglez <git@bitsofnetworks.org> > --- > .../ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-hap-ac2.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-hap-ac2.dts b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-hap-ac2.dts > index e1e6326ae9..d03409b556 100644 > --- a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-hap-ac2.dts > +++ b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-hap-ac2.dts > @@ -191,6 +191,7 @@ > > hard_config { > read-only; > + size = <0x2000>; > }; > > dtb_config { > -- > 2.30.0 >
diff --git a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-hap-ac2.dts b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-hap-ac2.dts index e1e6326ae9..d03409b556 100644 --- a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-hap-ac2.dts +++ b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-hap-ac2.dts @@ -191,6 +191,7 @@ hard_config { read-only; + size = <0x2000>; }; dtb_config {