From patchwork Mon Apr 12 15:59:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Mentovai X-Patchwork-Id: 1465380 X-Patchwork-Delegate: ynezz@true.cz Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=jhytQZj1; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=moxienet.com header.i=@moxienet.com header.a=rsa-sha256 header.s=google header.b=i6qlDnfA; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FJtmS4tnsz9sVm for ; Tue, 13 Apr 2021 02:02:32 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gffjpw8pGHyc1PZ9Nh4EbTmf/SV8oTRWJsZRlkZxDV0=; b=jhytQZj1o4LiRVEQbnCnRTqZC VPtyA6uYHYQLBbX+WA7sE2ajDrQNNosutc4BmXUfbw2qqFErbzTvm4YwVOVHSZgpnp7S+CRzVJVMN 78WR+zs6SwmsLpP9TJTGqBj0wlKYAwEJgwnVR1seRunq8wBHhXN6CI0OXSuCMuplGSDPRvfDNMijR GFkXksXkVZ+hzgwf2mywQOCOVN1fxSSLlsaUFA6EhTicbLav9oi+Ddan4lJ3P09a0Yv2O9NewN+Mg ag8QLXraZr2jHKOyTI9pIRuAHZBf5yXct2SfYcvDaN2zvzikyp27bq9aFRXGpr+X7f3sE/XfXZ3Oc VHAMPKWJg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVyz5-007B9B-HO; Mon, 12 Apr 2021 16:00:19 +0000 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVyyU-007B0c-DZ for openwrt-devel@lists.openwrt.org; Mon, 12 Apr 2021 15:59:46 +0000 Received: by mail-qk1-x72f.google.com with SMTP id 130so293624qkm.4 for ; Mon, 12 Apr 2021 08:59:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=moxienet.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4YdHgzRj8c+FMSRrZZCp2v5F59hP91AlOCeMSmKhE54=; b=i6qlDnfAO9Q5uF4ZuFtiTkPhxoQrqfDhmgFhoid36i/5pdCmi6DFz7KT20/LJ/yQF3 F8kTOmqxd4a4JiNyNe+IfrOVxyhE4T7wuS7yGggn6SoHjY9C3k6aJQeRRfEX0k4NldTx 5wF8sqNlhkMEOJDtqucHP+B7BeCYbQM3gvrYQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4YdHgzRj8c+FMSRrZZCp2v5F59hP91AlOCeMSmKhE54=; b=eIl2ADUXvisR1SWZbUFJPy98nme1dzcYiEja2P5/8a79Mndeavgdx5iV2TNGCNs1tS ylk+IfZThXN3fKuPCDZF1C/XJUIdD3XU4R9s+jCEENRXF7JCOnK8ltQbN9PfPoNc3lAN Dx/9mnGd0k/p1G+Q3ZJtonR14RLWtQ24bbPDxgCBqsq08KaoU/g6RFvU+RvwusQdu8OY Bv8psIrwUvBmk4eXeltcWMHr/YJRgQzd0qQPbwUm77hEgNs5T8riIOXPM2yElqx+jfxx eClvr6Sz3pZQUwJc6bXZ4cg7sanAbPDvuafib9Pet1f0h+KvM4kigwz4s7p69FYEMBRj Slag== X-Gm-Message-State: AOAM533qUBuWmlsBVBSlyn47/G4ENODX5LDZCnI6bsXNvc1fY/TTjE3/ tFe6A6N2HwFX9bslnYFh0ckdsQbyqgnGVQ== X-Google-Smtp-Source: ABdhPJxMHND7+YVgvEcI9jbCT7VVUlB6YtJR3V4pMPyKWlcWC0r/y43ETWCGFftpwnrYpwNxNqBYhw== X-Received: by 2002:a37:6302:: with SMTP id x2mr5197508qkb.393.1618243173918; Mon, 12 Apr 2021 08:59:33 -0700 (PDT) Received: from redacted (pool-100-33-106-198.nycmny.fios.verizon.net. [100.33.106.198]) by smtp.gmail.com with ESMTPSA id e8sm734378qtp.31.2021.04.12.08.59.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 08:59:33 -0700 (PDT) From: Mark Mentovai To: OpenWrt Development List Cc: Jan Alexander Subject: [PATCH 2/3] ipq806x: ubnt,unifi-ac-hd: use on-board PHYs Date: Mon, 12 Apr 2021 11:59:19 -0400 Message-Id: <20210412155920.2658437-3-mark@moxienet.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210412155920.2658437-1-mark@moxienet.com> References: <20210412155920.2658437-1-mark@moxienet.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_165943_994443_79316770 X-CRM114-Status: GOOD ( 11.16 ) X-Spam-Score: 0.1 (/) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Unlike many ipq806x devices, Ubiquiti UniFi AC HD (UAP-AC-HD, UAP301) has no switch on board. Its two Ethernet ports are connected to Atheros AR8033 PHYs. It is not appropriate to use fixed-link in th [...] Content analysis details: (0.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:72f listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Unlike many ipq806x devices, Ubiquiti UniFi AC HD (UAP-AC-HD, UAP301) has no switch on board. Its two Ethernet ports are connected to Atheros AR8033 PHYs. It is not appropriate to use fixed-link in this configuration. Instead, configure the correct PHYs in the device tree configuration to allow the at803x driver to load. Signed-off-by: Mark Mentovai Build-tested: ipq806x/ubnt,unifi-ac-hd Run-tested: ipq806x/ubnt,unifi-ac-hd --- .../arm/boot/dts/qcom-ipq8064-unifi-ac-hd.dts | 38 +++++++++---------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/target/linux/ipq806x/files/arch/arm/boot/dts/qcom-ipq8064-unifi-ac-hd.dts b/target/linux/ipq806x/files/arch/arm/boot/dts/qcom-ipq8064-unifi-ac-hd.dts index 7c2d6c9d1307..70c51b90f316 100644 --- a/target/linux/ipq806x/files/arch/arm/boot/dts/qcom-ipq8064-unifi-ac-hd.dts +++ b/target/linux/ipq806x/files/arch/arm/boot/dts/qcom-ipq8064-unifi-ac-hd.dts @@ -16,6 +16,8 @@ led-running = &led_dome_blue; led-upgrade = &led_dome_blue; mdio-gpio0 = &mdio0; + ethernet0 = &gmac1; + ethernet1 = &gmac2; }; leds { @@ -229,38 +231,36 @@ pinctrl-0 = <&mdio0_pins>; pinctrl-names = "default"; -}; - -&gmac2 { - status = "okay"; - phy-mode = "sgmii"; - qcom,id = <2>; - qcom,emulation = <0>; - mdiobus = <&mdio0>; - - mtd-mac-address = <&eeprom 0x0>; + phy4: ethernet-phy@4 { + reg = <4>; + }; - fixed-link { - speed = <1000>; - full-duplex; + phy5: ethernet-phy@5 { + reg = <5>; }; }; &gmac1 { status = "okay"; + mdiobus = <&mdio0>; + phy-handle = <&phy5>; phy-mode = "sgmii"; qcom,id = <1>; - qcom,emulation = <0>; - mdiobus = <&mdio0>; mtd-mac-address = <&eeprom 0x6>; +}; - fixed-link { - speed = <1000>; - full-duplex; - }; +&gmac2 { + status = "okay"; + + mdiobus = <&mdio0>; + phy-handle = <&phy4>; + phy-mode = "sgmii"; + qcom,id = <2>; + + mtd-mac-address = <&eeprom 0x0>; }; &pcie0 {