diff mbox series

ramips: fix partition layout of xiaomi mi router 4a 100mbit

Message ID 20210108124246.1467019-1-lynxis@fe80.eu
State Under Review, archived
Delegated to: Alexander Couzens
Headers show
Series ramips: fix partition layout of xiaomi mi router 4a 100mbit | expand

Commit Message

Alexander 'lynxis' Couzens Jan. 8, 2021, 12:42 p.m. UTC
The partition layout doesn't match the partition layout read out by OEM
version. It's unclear to me if different firmware version have different
partition layouts.
---
 target/linux/ramips/dts/mt7628an_xiaomi_mi-router-4a-100m.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Rafał Miłecki Jan. 8, 2021, 1:57 p.m. UTC | #1
On 08.01.2021 13:42, Alexander Couzens wrote:
> The partition layout doesn't match the partition layout read out by OEM
> version. It's unclear to me if different firmware version have different
> partition layouts.

Missing Signed-off-by



> ---
>   target/linux/ramips/dts/mt7628an_xiaomi_mi-router-4a-100m.dts | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/linux/ramips/dts/mt7628an_xiaomi_mi-router-4a-100m.dts b/target/linux/ramips/dts/mt7628an_xiaomi_mi-router-4a-100m.dts
> index 37797fc368cb..ea7e99d0b3fc 100644
> --- a/target/linux/ramips/dts/mt7628an_xiaomi_mi-router-4a-100m.dts
> +++ b/target/linux/ramips/dts/mt7628an_xiaomi_mi-router-4a-100m.dts
> @@ -10,13 +10,13 @@
>   &partitions {
>   	partition@60000 {
>   		label = "overlay";
> -		reg = <0x60000 0x100000>;
> +		reg = <0x60000 0x200000>;
>   		read-only;
>   	};
>   
>   	partition@160000 {

You need to update address in the node name.


>   		label = "firmware";
> -		reg = <0x160000 0xea0000>;
> +		reg = <0x260000 0xda0000>;
>   		compatible = "denx,uimage";
>   	};
>   };
>
Adrian Schmutzler Jan. 8, 2021, 6:34 p.m. UTC | #2
Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org]
> On Behalf Of Alexander Couzens
> Sent: Freitag, 8. Januar 2021 13:43
> To: openwrt-devel@lists.openwrt.org
> Cc: Alexander Couzens <lynxis@fe80.eu>
> Subject: [PATCH] ramips: fix partition layout of xiaomi mi router 4a 100mbit
> 
> The partition layout doesn't match the partition layout read out by OEM
> version. It's unclear to me if different firmware version have different
> partition layouts.

There has been a similar discussion somewhere in the past (don't find it right now), and it appears that the names for these devices are either mixed or not strictly defined. This should definitely be investigated more closely before merging anything.

Best

Adrian

> ---
>  target/linux/ramips/dts/mt7628an_xiaomi_mi-router-4a-100m.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/linux/ramips/dts/mt7628an_xiaomi_mi-router-4a-100m.dts
> b/target/linux/ramips/dts/mt7628an_xiaomi_mi-router-4a-100m.dts
> index 37797fc368cb..ea7e99d0b3fc 100644
> --- a/target/linux/ramips/dts/mt7628an_xiaomi_mi-router-4a-100m.dts
> +++ b/target/linux/ramips/dts/mt7628an_xiaomi_mi-router-4a-100m.dts
> @@ -10,13 +10,13 @@
>  &partitions {
>  	partition@60000 {
>  		label = "overlay";
> -		reg = <0x60000 0x100000>;
> +		reg = <0x60000 0x200000>;
>  		read-only;
>  	};
> 
>  	partition@160000 {
>  		label = "firmware";
> -		reg = <0x160000 0xea0000>;
> +		reg = <0x260000 0xda0000>;
>  		compatible = "denx,uimage";
>  	};
>  };
> --
> 2.29.2
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
diff mbox series

Patch

diff --git a/target/linux/ramips/dts/mt7628an_xiaomi_mi-router-4a-100m.dts b/target/linux/ramips/dts/mt7628an_xiaomi_mi-router-4a-100m.dts
index 37797fc368cb..ea7e99d0b3fc 100644
--- a/target/linux/ramips/dts/mt7628an_xiaomi_mi-router-4a-100m.dts
+++ b/target/linux/ramips/dts/mt7628an_xiaomi_mi-router-4a-100m.dts
@@ -10,13 +10,13 @@ 
 &partitions {
 	partition@60000 {
 		label = "overlay";
-		reg = <0x60000 0x100000>;
+		reg = <0x60000 0x200000>;
 		read-only;
 	};
 
 	partition@160000 {
 		label = "firmware";
-		reg = <0x160000 0xea0000>;
+		reg = <0x260000 0xda0000>;
 		compatible = "denx,uimage";
 	};
 };