From patchwork Mon Jan 4 00:24:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosen Penev X-Patchwork-Id: 1421994 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.openwrt.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=merlin.20170209 header.b=1rKnuNPm; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Dj5SS/WB; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4D8Ml15lZjz9sSC for ; Mon, 4 Jan 2021 15:16:29 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:To:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fEREG+mpNRcx+7oPhly2KnNuT5PFGQ1mYJvcOPomcNw=; b=1rKnuNPmbF98bl1iZi9y1nt1sq FyR1fk3bC1ukEUs7Lj/N+TC01vApK4so88vPSN8cAWrPPGujnn+YXU5wY6xpy5htmB/WZ5+rf+FCj gfV9qESloQ93gJH4nb8Wb1ItU5moNd6exky6q53tk6yLlSCYIkdROJL8wochG2lMx/kCRoebpEKv/ 80So59krld+w8BfffqCHeKHfI1JqFM0zpd7LqLurBCFldx6g1wMOO95cdGXaR+jC1XcM7x6UPs4Wp zfhhahqYo66c/lkmoa6vbNZ3HOd2kRfceidPkZadPrkiSijvIBtH7zn68dks+dxg1moD5PXEAJEpq 3LU3rndQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwDfX-0006Jl-7D; Mon, 04 Jan 2021 00:24:19 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwDfS-0006I6-Us for openwrt-devel@lists.openwrt.org; Mon, 04 Jan 2021 00:24:16 +0000 Received: by mail-pj1-x102d.google.com with SMTP id z12so8754625pjn.1 for ; Sun, 03 Jan 2021 16:24:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=uq5nhf4v1Z7p3z/dvljyid7o588FOOxhRLY9kQ/vBa0=; b=Dj5SS/WBk4KXBqakcXdiF3YglGm8hi9no4kjOcF7sWulNBULlyoksi9DvPX1zN0a9o 6VwzBhH6Czh2B/fg4LOFW1sz1vChGaRf6LwjTCTx9BBVptm9ZDLc5UVyHf3paVghjSHh yjBb+W+z6ZQoJuDCHcbZS2bBfAqvWChpI5+kPmTfNJIUORQ44zRNGsy6hguqwRP/Ah61 +Uisq76/FD0S765GnctPt95JFAq7hXZDN5U2bVjn4sn0uig/+FWZFOSHyvKIq5vWD4ma bHUSBSVK2ZBUsDAGfhCXe2PSzgVM81gy8nadPoTkiMtQ4DKAOxAwNGP7QciU0xf39QMj GeWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uq5nhf4v1Z7p3z/dvljyid7o588FOOxhRLY9kQ/vBa0=; b=qiKcw6rlYZtk0rFJrBGAwTLwfOK2rAe0HVCo75EF5EqAzdmanNF1zdyNzvMdSwr1G0 Qw4o5j20+iWC4SEl8tGr87zKqEGLbLfcxNjvUvUlXqzXDvtaRqfYLgcTNMuOBhwVNrTR vgRgHFsxgrbYvADqNFx/yOuHLuO3MSJhejatDeEF0EnmMUG2RV4rn4tjc7tD5PXdvbrI X1RJODBS/kCzmI/WztZlGFb/nP34ncrTcqanuVokLD4KoWSNyBzQrdhyKX/2hgJNVoI6 nceauopBvFThJ36yTdrximFkWJ1Y9+GemKaWHuvZE7Q+RTPsM2HH/7CVcd7814rVj0LF frhQ== X-Gm-Message-State: AOAM530qpBXfvDikDJj75904hhsqlnZkKcBtfpW79Mfj+zRLxERP8fo1 EmTHT9erYZVBW+m5c46Egwv9zHOBrav30Q== X-Google-Smtp-Source: ABdhPJw8kOEjpchNGl1fjuQr8U47rf2i2cq2T91flnmU21ic7IWn0Pn/ZJWO6a09iCUV1FueaxwecQ== X-Received: by 2002:a17:902:7c8f:b029:dc:8e14:95a8 with SMTP id y15-20020a1709027c8fb02900dc8e1495a8mr5836914pll.52.1609719848258; Sun, 03 Jan 2021 16:24:08 -0800 (PST) Received: from mangix-trapnet.lan ([2001:470:1f05:79e::a89]) by smtp.gmail.com with ESMTPSA id d124sm56936111pgc.68.2021.01.03.16.24.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Jan 2021 16:24:07 -0800 (PST) From: Rosen Penev To: openwrt-devel@lists.openwrt.org Subject: [PATCH 2/3] busybox: remove useless busybox patches Date: Sun, 3 Jan 2021 16:24:04 -0800 Message-Id: <20210104002405.758959-2-rosenp@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210104002405.758959-1-rosenp@gmail.com> References: <20210104002405.758959-1-rosenp@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210103_192415_066928_104441F8 X-CRM114-Status: GOOD ( 11.92 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:102d listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [rosenp[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org The first two are useless as /bin/sh can execute those scripts just fine. Shellcheck reports no problems. Telnet patch is useless as telnet is no longer used in OpenWrt. Signed-off-by: Rosen Penev --- package/utils/busybox/patches/100-trylink_bash.patch | 8 -------- .../busybox/patches/101-gen_build_files_bash.patch | 8 -------- package/utils/busybox/patches/240-telnetd_intr.patch | 10 ---------- 3 files changed, 26 deletions(-) delete mode 100644 package/utils/busybox/patches/100-trylink_bash.patch delete mode 100644 package/utils/busybox/patches/101-gen_build_files_bash.patch delete mode 100644 package/utils/busybox/patches/240-telnetd_intr.patch diff --git a/package/utils/busybox/patches/100-trylink_bash.patch b/package/utils/busybox/patches/100-trylink_bash.patch deleted file mode 100644 index f9571fcbc8..0000000000 --- a/package/utils/busybox/patches/100-trylink_bash.patch +++ /dev/null @@ -1,8 +0,0 @@ ---- a/scripts/trylink -+++ b/scripts/trylink -@@ -1,4 +1,4 @@ --#!/bin/sh -+#!/usr/bin/env bash - - debug=false - diff --git a/package/utils/busybox/patches/101-gen_build_files_bash.patch b/package/utils/busybox/patches/101-gen_build_files_bash.patch deleted file mode 100644 index d258fb8bc4..0000000000 --- a/package/utils/busybox/patches/101-gen_build_files_bash.patch +++ /dev/null @@ -1,8 +0,0 @@ ---- a/scripts/gen_build_files.sh -+++ b/scripts/gen_build_files.sh -@@ -1,4 +1,4 @@ --#!/bin/sh -+#!/usr/bin/env bash - - # Note: was using sed OPTS CMD -- FILES - # but users complain that many sed implementations diff --git a/package/utils/busybox/patches/240-telnetd_intr.patch b/package/utils/busybox/patches/240-telnetd_intr.patch deleted file mode 100644 index 773ba44db5..0000000000 --- a/package/utils/busybox/patches/240-telnetd_intr.patch +++ /dev/null @@ -1,10 +0,0 @@ ---- a/networking/telnetd.c -+++ b/networking/telnetd.c -@@ -509,6 +509,7 @@ make_new_session( - - /* Restore default signal handling ASAP */ - bb_signals((1 << SIGCHLD) + (1 << SIGPIPE), SIG_DFL); -+ signal(SIGINT, SIG_DFL); - - pid = getpid(); -