From patchwork Thu Dec 10 13:28:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rui Salvaterra X-Patchwork-Id: 1414172 X-Patchwork-Delegate: rsalvaterra@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.openwrt.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=merlin.20170209 header.b=VD385yL0; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=jjPxg/Ft; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CsFCw3S5yz9sW8 for ; Fri, 11 Dec 2020 00:30:36 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=RKmzgY9k3xhhJc+h/2R7H3jfHDYJNpQKdJCBBr3e/o0=; b=VD385yL0Ba+BFMTKe96MTsck32 FzSdxq/ue5S8ruCWX5ETRcvGtxVJ+UPBu3RsHysf74TUtXqS+uvQRoyAq2mhlXYjzZevHWFXZPMxS aemlRwFIKMCqctfJcppLbc4a7Zss03AUvSnpf8c1FOIzRrrgFPpb2bTrKOE2Tao7G8BYj7g6xVoML sqMGRRpXE+EeKL/RZGiWiChPTzVgmrwsfB9Hn8SwnNGfR6PuIg5uXhzlr6RhQK3z/mWcpO2zWs93W W6NkdpO7Z2z7wFRPE7FZHY4cXNWXl0BdLAgHkHSSWN1FPNeuMQHDb1Y5PuetcvqjuOca0jhP1+fCO v5tH0JSQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1knLzp-00005S-Ad; Thu, 10 Dec 2020 13:28:37 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1knLzn-0008WU-HT for openwrt-devel@lists.openwrt.org; Thu, 10 Dec 2020 13:28:36 +0000 Received: by mail-wm1-x341.google.com with SMTP id g185so5307780wmf.3 for ; Thu, 10 Dec 2020 05:28:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yCJD//H38/x8l+kmnWVHLvXA4/ViCnxgPkL4Vcmas3A=; b=jjPxg/FtDZiDDu7iozx1PvM+bdlD8YruBsGaUB8DZC+8DeKvQcypfTqad0uykA4jSW DZKZGf7e8k2uC+DwryvcYAqeNYRti5A5hDSyuozNNxflvlxQQ1M5KvoQMbrCBkgysH9t nGlnunFj+U+jThyaCuWp2gQJTNLIMTY39S0bkf3XeeRvDXIXWyzMxYOUUHeew8QcfHEf XMOIFEbU0pjhdOhojs0VJtfpiS1ATFrUHj14QU0evxOtaBCKUMIa6x4Km0TSfgBZ/BR/ F+sQJ4uHEvoosPLq7TE6KdSP5nrfvMnOunPKOjU3DfaJDaGtyt9xQ+1eJol7IDwywPfo A62A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yCJD//H38/x8l+kmnWVHLvXA4/ViCnxgPkL4Vcmas3A=; b=iLD7V9Y5aqYn2Ufkrm1/oB6xUEflg0aTYMKB1hfiS3zXfcKkfUm3zjbMU8jxiEqQwZ nKtsP1FnbWF5LM3uuuNW9YiMwpMUNfcPiGa/TTXEW22rpvwbhlIcHrr8pXlxPP40Ggrx VnzzICkDGg4V6Wi/ZK8GSrWOuGpGh6N9P6wxcwaqF5aOUqbkneXFk++Zgr9iIKp/SnU5 QehvZ3e0djuamMllLmeTCfBcehddXIXjqPQMc0nyUJtcJmxMya/zHU46xjl+JXaXIikL SXTLQYDbbGHEb9EvB9wZwH4V6YsbFpB8TQESqYRw0/viut+4mxzFqbVf/q7TObmjZTMp hEHA== X-Gm-Message-State: AOAM532RSokMEKVesCuQlVQHSpDyUW/q6FQukAaDi8507wa+frKnFMtD pwsxHI+ztJNugpJ8VUcKptVUA2wqmYM0 X-Google-Smtp-Source: ABdhPJxbY8dh8vpFozocDxEICzfek4BvsqoMk4UKj9waje2Z0myWxFdAjuMIlDEafKsI5E0TLHnAxw== X-Received: by 2002:a05:600c:218a:: with SMTP id e10mr8171036wme.27.1607606912348; Thu, 10 Dec 2020 05:28:32 -0800 (PST) Received: from presler.lan (a95-94-74-213.cpe.netcabo.pt. [95.94.74.213]) by smtp.gmail.com with ESMTPSA id t184sm9715365wmt.13.2020.12.10.05.28.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Dec 2020 05:28:31 -0800 (PST) From: Rui Salvaterra To: openwrt-devel@lists.openwrt.org Subject: [PATCH] kernel/kmod-lib-lzo: include the lzo-rle kmod in the package Date: Thu, 10 Dec 2020 13:28:25 +0000 Message-Id: <20201210132825.2342-1-rsalvaterra@gmail.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201210_082835_591653_8328281A X-CRM114-Status: GOOD ( 10.27 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [rsalvaterra[at]gmail.com] -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: e9hack@gmail.com, Rui Salvaterra , devel-sven@geroedel.de Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Albeit a separate crypto module, lzo-rle uses the same kernel library as lzo. Crypto API users (zram, for example) expect both lzo and lzo-rle to be available, so let's include lzo-rle (about 5.5 kiB) in the lib-lzo package. Based on e9hack's original patch: https://patchwork.ozlabs.org/project/openwrt/patch/541cbfbd-76f2-59b3-a867-47b6f0fc7da9@gmail.com/ Signed-off-by: Rui Salvaterra Acked-by: Jo-Philipp Wich --- Sven, I read your original reply [1], but I don't think a less than 6 kiB difference is worth the violation of the principle of least surprise. Besides, at least for the zram use case, we'll soon be able to rely on a single compression algorithm, without a hard dependency on lzo [2] (zstd being the obvious candidate). Thoughts? [1] https://lists.openwrt.org/pipermail/openwrt-devel/2020-September/031434.html [2] https://lore.kernel.org/linux-block/20201207121245.50529-1-rsalvaterra@gmail.com/ package/kernel/linux/modules/lib.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package/kernel/linux/modules/lib.mk b/package/kernel/linux/modules/lib.mk index 9a341932bd..8dba905f50 100644 --- a/package/kernel/linux/modules/lib.mk +++ b/package/kernel/linux/modules/lib.mk @@ -109,9 +109,10 @@ define KernelPackage/lib-lzo HIDDEN:=1 FILES:= \ $(LINUX_DIR)/crypto/lzo.ko \ + $(LINUX_DIR)/crypto/lzo-rle.ko \ $(LINUX_DIR)/lib/lzo/lzo_compress.ko \ $(LINUX_DIR)/lib/lzo/lzo_decompress.ko - AUTOLOAD:=$(call AutoProbe,lzo lzo_compress lzo_decompress) + AUTOLOAD:=$(call AutoProbe,lzo lzo-rle lzo_compress lzo_decompress) endef define KernelPackage/lib-lzo/description