diff mbox series

kernel/kmod-lib-lzo: include the lzo-rle kmod in the package

Message ID 20201210132825.2342-1-rsalvaterra@gmail.com
State Under Review
Delegated to: Paul Spooren
Headers show
Series kernel/kmod-lib-lzo: include the lzo-rle kmod in the package | expand

Commit Message

Rui Salvaterra Dec. 10, 2020, 1:28 p.m. UTC
Albeit a separate crypto module, lzo-rle uses the same kernel library as lzo.
Crypto API users (zram, for example) expect both lzo and lzo-rle to be
available, so let's include lzo-rle (about 5.5 kiB) in the lib-lzo package.

Based on e9hack's original patch: https://patchwork.ozlabs.org/project/openwrt/patch/541cbfbd-76f2-59b3-a867-47b6f0fc7da9@gmail.com/

Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>

Sven, I read your original reply [1], but I don't think a less than 6 kiB
difference is worth the violation of the principle of least surprise. Besides,
at least for the zram use case, we'll soon be able to rely on a single
compression algorithm, without a hard dependency on lzo [2] (zstd being the
obvious candidate). Thoughts?

[1] https://lists.openwrt.org/pipermail/openwrt-devel/2020-September/031434.html
[2] https://lore.kernel.org/linux-block/20201207121245.50529-1-rsalvaterra@gmail.com/

 package/kernel/linux/modules/lib.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series


diff --git a/package/kernel/linux/modules/lib.mk b/package/kernel/linux/modules/lib.mk
index 9a341932bd..8dba905f50 100644
--- a/package/kernel/linux/modules/lib.mk
+++ b/package/kernel/linux/modules/lib.mk
@@ -109,9 +109,10 @@  define KernelPackage/lib-lzo
   FILES:= \
 	$(LINUX_DIR)/crypto/lzo.ko \
+	$(LINUX_DIR)/crypto/lzo-rle.ko \
 	$(LINUX_DIR)/lib/lzo/lzo_compress.ko \
-  AUTOLOAD:=$(call AutoProbe,lzo lzo_compress lzo_decompress)
+  AUTOLOAD:=$(call AutoProbe,lzo lzo-rle lzo_compress lzo_decompress)
 define KernelPackage/lib-lzo/description