diff mbox series

hostapd: enable airtime policy for the -basic variants

Message ID 20201125230348.536613-1-rsalvaterra@gmail.com
State New
Headers show
Series hostapd: enable airtime policy for the -basic variants | expand

Commit Message

Rui Salvaterra Nov. 25, 2020, 11:03 p.m. UTC
Airtime policy configuration is extremely useful in multiple BSS scenarios.
Since nowadays most people configure both private and guest networks (at
least), it makes sense to enable it by default, except for the most limited
of the variants.

Size of the hostapd-basic-openssl binary (mipsel 24Kc -O2):
543944 bytes (airtime policy disabled)
548040 bytes (airtime policy enabled)

Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
---
The -mesh variants are basically -full with extra mesh functionality, so they
already have airtime policy enabled by default.

 package/network/services/hostapd/files/hostapd-basic.config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniel Golle Nov. 27, 2020, 10:31 p.m. UTC | #1
On Wed, Nov 25, 2020 at 11:03:48PM +0000, Rui Salvaterra wrote:
> Airtime policy configuration is extremely useful in multiple BSS scenarios.
> Since nowadays most people configure both private and guest networks (at
> least), it makes sense to enable it by default, except for the most limited
> of the variants.
> 
> Size of the hostapd-basic-openssl binary (mipsel 24Kc -O2):
> 543944 bytes (airtime policy disabled)
> 548040 bytes (airtime policy enabled)
> 
> Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
Acked-by: Daniel Golle <daniel@makrotopia.org>

Are there any new UCI options to be added to make use of this?

> ---
> The -mesh variants are basically -full with extra mesh functionality, so they
> already have airtime policy enabled by default.
> 
>  package/network/services/hostapd/files/hostapd-basic.config | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/network/services/hostapd/files/hostapd-basic.config b/package/network/services/hostapd/files/hostapd-basic.config
> index 947e2fa200..33c38192b1 100644
> --- a/package/network/services/hostapd/files/hostapd-basic.config
> +++ b/package/network/services/hostapd/files/hostapd-basic.config
> @@ -384,7 +384,7 @@ CONFIG_TLS=internal
>  #CONFIG_OWE=y
>  
>  # Airtime policy support
> -#CONFIG_AIRTIME_POLICY=y
> +CONFIG_AIRTIME_POLICY=y
>  
>  # Override default value for the wpa_disable_eapol_key_retries configuration
>  # parameter. See that parameter in hostapd.conf for more details.
> -- 
> 2.29.2
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Rui Salvaterra Nov. 28, 2020, 11:07 a.m. UTC | #2
Hi, Daniel,

On Fri, 27 Nov 2020 at 22:31, Daniel Golle <daniel@makrotopia.org> wrote:
>
> On Wed, Nov 25, 2020 at 11:03:48PM +0000, Rui Salvaterra wrote:
> > Airtime policy configuration is extremely useful in multiple BSS scenarios.
> > Since nowadays most people configure both private and guest networks (at
> > least), it makes sense to enable it by default, except for the most limited
> > of the variants.
> >
> > Size of the hostapd-basic-openssl binary (mipsel 24Kc -O2):
> > 543944 bytes (airtime policy disabled)
> > 548040 bytes (airtime policy enabled)
> >
> > Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
> Acked-by: Daniel Golle <daniel@makrotopia.org>
>
> Are there any new UCI options to be added to make use of this?

They were added recently:
https://git.openwrt.org/?p=openwrt%2Fopenwrt.git&a=search&h=HEAD&st=commit&s=airtime+policy

However, I've been playing with them and I still wasn't able to see a
change in station airtime weight, in either of the three modes. I've
only tested mt76 hardware yet, but I'll soon test ath9k and ath10k.

Thanks,
Rui
diff mbox series

Patch

diff --git a/package/network/services/hostapd/files/hostapd-basic.config b/package/network/services/hostapd/files/hostapd-basic.config
index 947e2fa200..33c38192b1 100644
--- a/package/network/services/hostapd/files/hostapd-basic.config
+++ b/package/network/services/hostapd/files/hostapd-basic.config
@@ -384,7 +384,7 @@  CONFIG_TLS=internal
 #CONFIG_OWE=y
 
 # Airtime policy support
-#CONFIG_AIRTIME_POLICY=y
+CONFIG_AIRTIME_POLICY=y
 
 # Override default value for the wpa_disable_eapol_key_retries configuration
 # parameter. See that parameter in hostapd.conf for more details.