From patchwork Thu Oct 15 22:35:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rui Salvaterra X-Patchwork-Id: 1382961 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.openwrt.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=merlin.20170209 header.b=HoSLEyXD; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=jQsUDzG1; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CC41w0Hzkz9sTq for ; Fri, 16 Oct 2020 09:38:24 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=c9ClCKZ8Ktm1GAWZruCatXofHdnuBnVZ4Sd/e4d8bkw=; b=HoSLEyXDM8cPZ5MWMHjpz5Kc1 JfIQBD1Rbi7f1RZyCP+5LYPF1rlY2FmXCUdSbRUN1FbWrIkdTe2Pf4GAgWBewpkafS5KcmwKmFa9Q xyq3bigv8xg7h9GlFnfawtfkNruy1jrN5A3LsDzZGcR9QTBPOWuDuvfQKNZ3VcwEd8dkKbFLsLE7Q ozi4inrT2/FGL/OvO5Yb70dJaKn/GocPqfp/Po9uq1DCaI0hsFHB1HxNqRgxn33MnQF9DV6NsMqL8 pQ6Hkhs76XD1q82xkazRIb5Ui1XvASRJuuUpcvNSVovtwRXbGX0Uw5RZG1gq+6Cl82f5wQafiULPO STxdMwu1g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTBr4-0001DY-W2; Thu, 15 Oct 2020 22:36:15 +0000 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTBr0-0001Bm-QG for openwrt-devel@lists.openwrt.org; Thu, 15 Oct 2020 22:36:11 +0000 Received: by mail-ej1-x641.google.com with SMTP id c22so437303ejx.0 for ; Thu, 15 Oct 2020 15:36:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ERwUHIbf05sHW6Ky/hP1P1M9RHqVM17cZ+mbhDC2bBM=; b=jQsUDzG17i+1q04Xd6YganQzCoPCUksJFOA+6ijzVw+aC8O8RMbLB9iS56ZKvwE0CN pDiEXTRTWAYajxUuEI4aTBuzMz21wNhZthV+3JpNg62TA2NRNMMnjVVu7ufaiSrEqx2/ WZ8KLh73K+SMhgmgwFPMPj4VjiCesmKZTcLcKrXtNEdEPf/FE+b6xXYGT5Gq+WzdqWX8 iu1ieT8jQ0L1hSpk6g6cWUsn7Mw/AT9AWVio5SiWBhTMevYL/nfvWn3AqekCXm9vi1KQ 9Ro1HuVT6T7isoqkYC20UWz31vW+1OOVkjCUEj5d8M2f45v4FJcYGTYm7NOOq9EiYJvm YgVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ERwUHIbf05sHW6Ky/hP1P1M9RHqVM17cZ+mbhDC2bBM=; b=h4MPXtUeubbcAMtHcM0sL9Hd9HqnxTZaNcIsJEja2/nzvKob47NKQbzBXGvavAYd/2 naRnpSHKpPyqHdgGch870Jz4GUWCbMVo4n8CaFohBkOaSpWU0XHJoYXc4+KaAbqR3v6K 2iRQ7XJg+FrAswfDpFF5rseec/nI26NdfeqZiaZ1IDYOc58KV2pBEALCPWS0QdSGytZv kttBDXZMQ+veOOnps42S/1qeluDH7w6xcJFv1/ivv9b3tB39vlnUgHNDMCMYDour7EP1 0pGlQbQFLW/hFYkpQg0+9W8P4awdwsfA1iF5acTIIj+ln1CO0CdUSUYmpXQZjRgZ7PQj 4UsA== X-Gm-Message-State: AOAM532T+5MjO+TAgx5sUQh+ieGaeO424EqaEvRlFWS8Tv9fGQNyL8QB zj6XXTHZ6OKFcC5tEb9qD5xzKhRLWw== X-Google-Smtp-Source: ABdhPJzJNHHghhXuKFROmVvkcW5U5o5YU1viPA6xABQeRHvnydNxUoezM2rpLcm2G2YPo3RnyE4wgA== X-Received: by 2002:a17:906:c7d9:: with SMTP id dc25mr615322ejb.482.1602801367645; Thu, 15 Oct 2020 15:36:07 -0700 (PDT) Received: from presler.lan (a95-93-121-164.cpe.netcabo.pt. [95.93.121.164]) by smtp.gmail.com with ESMTPSA id yd18sm331756ejb.10.2020.10.15.15.36.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2020 15:36:07 -0700 (PDT) From: Rui Salvaterra To: openwrt-devel@lists.openwrt.org Subject: [PATCH 1/3] openssl: reorganise the config dependencies Date: Thu, 15 Oct 2020 23:35:57 +0100 Message-Id: <20201015223559.928435-2-rsalvaterra@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201015223559.928435-1-rsalvaterra@gmail.com> References: <20201015223559.928435-1-rsalvaterra@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201015_183610_854222_088F0048 X-CRM114-Status: GOOD ( 13.74 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:641 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [rsalvaterra[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rui Salvaterra Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org There's no technical reason for OPENSSL_OPTIMIZE_SPEED to imply OPENSSL_WITH_ASM, but it definitely makes sense to have OPENSSL_WITH_ASM selected by default if OPENSSL_OPTIMIZE_SPEED is enabled. No changes to the current defaults. Library sizes (in bytes): O3, 74kc, OPENSSL_OPTIMIZE_SPEED 2019956 libcrypto.so.1.1 443848 libssl.so.1.1 O3, 74kc, OPENSSL_OPTIMIZE_SPEED, OPENSSL_WITH_ASM 2010840 libcrypto.so.1.1 443848 libssl.so.1.1 O3, 74kc 1824148 libcrypto.so.1.1 428384 libssl.so.1.1 Signed-off-by: Rui Salvaterra --- package/libs/openssl/Config.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/package/libs/openssl/Config.in b/package/libs/openssl/Config.in index d1281ec6fa..8be6ee732a 100644 --- a/package/libs/openssl/Config.in +++ b/package/libs/openssl/Config.in @@ -6,7 +6,6 @@ config OPENSSL_OPTIMIZE_SPEED bool default y if x86_64 || i386 prompt "Enable optimization for speed instead of size" - select OPENSSL_WITH_ASM help Enabling this option increases code size (around 20%) and performance. The increase in performance and size depends on the @@ -18,7 +17,7 @@ config OPENSSL_WITH_ASM bool default y if !SMALL_FLASH || !arm prompt "Compile with optimized assembly code" - depends on !arc + depends on !arc && OPENSSL_OPTIMIZE_SPEED help Disabling this option will reduce code size and performance. The increase in performance and size depends on the target