From patchwork Thu Oct 15 05:58:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosen Penev X-Patchwork-Id: 1382462 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.openwrt.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=merlin.20170209 header.b=WE1iKy0J; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=bChQzFIf; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CBdtW1Vbjz9sV0 for ; Thu, 15 Oct 2020 17:00:35 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:Message-Id:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=R4wH4jrCrW4ag/fJHAHQ5dGCt7EG/S299/tKUhIkMrw=; b=WE1iKy0JzMewefZt1BPjLSpi5o v4fkLs5bXW4X9YkyRqmCvLVpfp388/HhNteKT7k5Z00lCSgvRfogpkH3r1woSAIvv8H9b2MMyDcTJ xK5fV0Sj5NRHexFe5cFkzSSf+vdF9adpyY23G4Fhluldtpr5d4l0bHEKor14LEJAMY4huxAmS5w+J o4gi1s4DWDhAAJkLfh+z0FC0Zu/XTd3dfsOZ8XLlFiRLgqrJn/r/UUyMJTeqarSAZ5ZnIhEb8MHAr expRJp46ZrAc/Rc0PMAsmy8mZ6Z/7dvzNaO65ToAVflXhy6y5TEmoadFLJOLWyUzuhXmbKd9EHu11 JsyUpG1A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSwHf-00005Q-JD; Thu, 15 Oct 2020 05:58:39 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSwHa-0008VK-QI for openwrt-devel@lists.openwrt.org; Thu, 15 Oct 2020 05:58:35 +0000 Received: by mail-pj1-x1031.google.com with SMTP id a17so1175715pju.1 for ; Wed, 14 Oct 2020 22:58:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=4Wh7GsmJUMOduLy7kV3Xqv5pHLrHoVw8EtB2lEtDjP0=; b=bChQzFIfVXnntwaAfcidJJXf7b1UoSV1aZJStRSSyC5cZFVqGPcmxjE31XJJf6P1Z7 OHOk2DDR/1N4jWj7ZJNTUgAYlFBkmaQRMATXtO6sKlAzTYjZHqCmgLh0Yvm3kt81gwY8 na/UQY1mcnE/pXhnBlHIqvs8TUNjGpBpA5oBzmSZMIWV7vDXgp+8lhPYWA9xyI1F+JDi 1su+olMcSqCUOv47MeR4AX9+8LpyiiXZzgijL5utgdtTRupG14ASHViF9cTYSdaiYvFm SU9CSApUtpZhFdN3j/B2nalaDAB2vztVz1GavlCjM2tVST5OX+yWGSfK0BVzo4BnMdYb O2RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=4Wh7GsmJUMOduLy7kV3Xqv5pHLrHoVw8EtB2lEtDjP0=; b=NBfdBxZjQKd/rBVjsnTlGDVOFfYcwBFnHHcoTlZeESJVVLsZHTJQckyXuotdF//bJS niSNdsQmRo31TybTW4HkEcRoMC4KfofQ9ycmQ4NhSFd//oCtRhmslqMpPdaREdge9h2P A7Ln2RgRXKC/kszvGoEgkck1bzmsRn95rusjulCC78w2Gn3KcXFQtPq4NScQhxfxqvyM bzJDC3KLnAX3UI/cg8b7szzWGKLw7xnX2LXEDIxwmqoov+mGl5M1usxAx5pnV4Wyx2YO FRwofzwYsrWwzUsE8bz8u8Rfn3ZB4WovXKPxnfgOEGb58h2hffiPbe11ZkLzkp6cL9KS dZ4g== X-Gm-Message-State: AOAM533hJp4HWIUtLUyfwpe0SqlZVuABfMdfzKw9cZr8joqn8JyU4MdP 9kfBmF0HBwR0YnB2NkJVQT0iSz9+j0S9Rw== X-Google-Smtp-Source: ABdhPJyt4LVNUPeNAezV483IJQfWOJjtu6OVf6p1+gXFm81WAUDowJSngIFRewvHVV7H88lK+DoLEQ== X-Received: by 2002:a17:902:6bc5:b029:d3:f10c:9449 with SMTP id m5-20020a1709026bc5b02900d3f10c9449mr2680905plt.54.1602741512414; Wed, 14 Oct 2020 22:58:32 -0700 (PDT) Received: from DESKTOP-VIRSTQA.lan ([2001:470:1f05:79e:e928:5c7b:bcee:fb01]) by smtp.gmail.com with ESMTPSA id p14sm1584404pjo.46.2020.10.14.22.58.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 22:58:31 -0700 (PDT) From: Rosen Penev To: openwrt-devel@lists.openwrt.org Subject: [PATCHv2 3/4] base-files/functions.sh: replace ^ with ! in [] Date: Wed, 14 Oct 2020 22:58:26 -0700 Message-Id: <20201015055827.29410-3-rosenp@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201015055827.29410-1-rosenp@gmail.com> References: <20201015055827.29410-1-rosenp@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201015_015834_863785_AE6BCC1A X-CRM114-Status: GOOD ( 13.03 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [rosenp[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1031 listed in] [list.dnswl.org] -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Strictly speaking, ash does not support it. From https://wiki.ubuntu.com/DashAsBinSh#A.5B.5E.5D Not to be confused by sed's and other program's regular expression syntax. Uses of [^] in case (parameter/word expansion in general) need to be replaced with [!]. Found with shellcheck: https://github.com/koalaman/shellcheck/wiki/SC2169 Signed-off-by: Rosen Penev --- package/base-files/files/lib/functions.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/base-files/files/lib/functions.sh b/package/base-files/files/lib/functions.sh index 61aa87b2dd..598e283b1e 100755 --- a/package/base-files/files/lib/functions.sh +++ b/package/base-files/files/lib/functions.sh @@ -108,7 +108,7 @@ config_unset() { # config_get