From patchwork Wed Oct 14 08:00:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rui Salvaterra X-Patchwork-Id: 1381854 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.openwrt.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=merlin.20170209 header.b=AiDx64g0; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Tuwn3lKq; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CB4dh0VQwz9sTv for ; Wed, 14 Oct 2020 19:02:32 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=f+fQDQEcys7AJ+ac2BWbgGX9dcqX3fHJ5vza3jj+uQw=; b=AiDx64g0Z1rbqzwkWMwLYNQ8q UjJaQ0xmzZJ+5z1u1vaQRs6tzuDD9LPByUszpaIvXEXpAf+iDHOpCGROmAcc2uQDA39RjV5Sw3e+f pPnQ6Hb8f8Q0C3kvVgSlO0ALWMwPhh36/RHMm6pDpSAzkcUhqp89Cy1x6RRnWGtHitn+e6hkBRhCg UWynbNosUIQh0Brm4gzHCs0vTy5aIh6palQnZIsNv9ssIQQGrnWe+scj3GfOetGo55QMqvyxE8skE /cglTMYYaj0LWCrq6VVYMBYgEIFZjQO7SPsR8RX3v5bEbERHzWqVSDB8kubvtiqHVuBKWIcSPFLju Nr5mLzGcw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSbij-0006rR-R9; Wed, 14 Oct 2020 08:01:13 +0000 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSbid-0006oW-6v for openwrt-devel@lists.openwrt.org; Wed, 14 Oct 2020 08:01:08 +0000 Received: by mail-io1-xd42.google.com with SMTP id 67so3916802iob.8 for ; Wed, 14 Oct 2020 01:01:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bkA7ntPUCHhruOUye8YSikGYB/DkypdIiOW1c7aitMs=; b=Tuwn3lKqEeUn92ens8Qi2FzP97i1z2Z02/B+cciVW9okDAnVNJGicNb+lKarIm6lix gz7tWBqjIJBxCeRgjdgnDdgB3AwmNYTORs/UsfwDSOcfezpi6JCJS8OtZbHAcxRO0l1j JwSGr3DGQm8takBG9aS/QOc2+E25hlZtTdmFYORMJzh6Nt29xGYnkyTIkwDwi3i++06W MIag9BmZPMccC2OvIkd3TShivI209kAKrtnZ9dXi29JqjNqjRLNi5h1H+g+IWwHqo9oL cQkg77olEH7MqSsgWYG3tNm4HF/6mZF44SVZBjx0YqusHbEFvll734w72XJC7TNtjViB AS2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bkA7ntPUCHhruOUye8YSikGYB/DkypdIiOW1c7aitMs=; b=Vog++XGRjyYv6mD8oSkkwbBOJ6/ABk/sYaX6GHwMkJmHXGtcgr11nH3pWsWzgaBKuc iUrnT5Q318qTlsCnWM5b4Mjprv1QVE9OwNdlguguy1mS+kng1vU/BSFI/wfK8aj8iBGx 4YFHbbDWwUIoJI88lwQ1t0lByfde4EBTplYHf1ivnHm8rYEykd0is25fePvjI34BfK+V lhJIH3j+YhAW4GxcidLCkU9tqnh0RpCo3W/xMficd9BEUuVOiSGB+wFksnd5K+zR5eyO SonBwOC9rk34Bwy8UpO0TjyFK7ind7fpR1K0KInRsoyxDpEjvL3e66wPCl4dPa0yiyrE xmnw== X-Gm-Message-State: AOAM531C1p1Jmecs6vWkDfVi6SMYoN+asg57bG7mQfVSmVxxG1j/vVgx 9NQFvPXVPEQk4ynVSdaNqACweX1vOjnY X-Google-Smtp-Source: ABdhPJyoWDzQ84VnDsFW0BruEYuHFnoC6pg4nfe4qy/a8Yv8lCSkPbcgTRTTpguQbmNGEgd/t800iQ== X-Received: by 2002:a5e:c70a:: with SMTP id f10mr1978825iop.178.1602662465368; Wed, 14 Oct 2020 01:01:05 -0700 (PDT) Received: from presler.lan (a95-93-122-112.cpe.netcabo.pt. [95.93.122.112]) by smtp.gmail.com with ESMTPSA id t26sm2056491ioi.11.2020.10.14.01.01.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 01:01:05 -0700 (PDT) From: Rui Salvaterra To: openwrt-devel@lists.openwrt.org Subject: [PATCH v2 3/3] dropbear: create a submenu for key exchange algorithms Date: Wed, 14 Oct 2020 09:00:51 +0100 Message-Id: <20201014080051.2324-4-rsalvaterra@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201014080051.2324-1-rsalvaterra@gmail.com> References: <20201014080051.2324-1-rsalvaterra@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_040107_333569_FCBD906A X-CRM114-Status: GOOD ( 11.94 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:d42 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [rsalvaterra[at]gmail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rui Salvaterra Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org This allows the user to select only the key exchange algorithms (s)he requires (e.g., disabling group 14 SHA-{1,256} and keeping only Curve25519). The default selection maintains the current functionality. Additionally, make sure at least one key exchange algorithm is selected, lest the build would fail. Signed-off-by: Rui Salvaterra --- package/network/services/dropbear/Config.in | 12 ++++++++++++ package/network/services/dropbear/Makefile | 13 ++++++++++--- 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/package/network/services/dropbear/Config.in b/package/network/services/dropbear/Config.in index 9cea6242a6..066dab0a9b 100644 --- a/package/network/services/dropbear/Config.in +++ b/package/network/services/dropbear/Config.in @@ -94,6 +94,16 @@ config DROPBEAR_AUTOSEL_EA endmenu +menu "Key exchange algorithm selection" + +config DROPBEAR_DH_GROUP14_SHA1 + bool "Group 14 SHA-1" + default y + +config DROPBEAR_DH_GROUP14_SHA256 + bool "Group 14 SHA-256" + default y + config DROPBEAR_CURVE25519 bool "Curve25519 support" default y @@ -103,6 +113,8 @@ config DROPBEAR_CURVE25519 Increases binary size by about 4 kB (MIPS). +endmenu + config DROPBEAR_ZLIB bool "Enable compression" default n diff --git a/package/network/services/dropbear/Makefile b/package/network/services/dropbear/Makefile index 768058718c..d0b0dbf3dc 100644 --- a/package/network/services/dropbear/Makefile +++ b/package/network/services/dropbear/Makefile @@ -32,6 +32,7 @@ PKG_CONFIG_DEPENDS:= \ CONFIG_DROPBEAR_RSA CONFIG_DROPBEAR_CURVE25519 CONFIG_DROPBEAR_ZLIB \ CONFIG_DROPBEAR_ED25519 CONFIG_DROPBEAR_AES128 CONFIG_DROPBEAR_AES256 \ CONFIG_DROPBEAR_CHACHA20POLY1305 CONFIG_DROPBEAR_UTMP \ + CONFIG_DROPBEAR_DH_GROUP14_SHA1 CONFIG_DROPBEAR_DH_GROUP14_SHA256 \ CONFIG_DROPBEAR_PUTUTLINE CONFIG_DROPBEAR_DBCLIENT CONFIG_DROPBEAR_SCP include $(INCLUDE_DIR)/package.mk @@ -110,9 +111,6 @@ define Build/Configure echo '#define DROPBEAR_RSA $(if $(CONFIG_DROPBEAR_RSA),1,0)' >> \ $(PKG_BUILD_DIR)/localoptions.h - echo '#define DROPBEAR_CURVE25519 $(if $(CONFIG_DROPBEAR_CURVE25519),1,0)' >> \ - $(PKG_BUILD_DIR)/localoptions.h - for OPTION in DROPBEAR_ECDSA DROPBEAR_ECDH; do \ echo "#define $$$$OPTION $(if $(CONFIG_DROPBEAR_ECC),1,0)" >> \ $(PKG_BUILD_DIR)/localoptions.h; \ @@ -130,6 +128,15 @@ define Build/Configure echo '#define DROPBEAR_CHACHA20POLY1305 $(if $(CONFIG_DROPBEAR_CHACHA20POLY1305),1,0)' >> \ $(PKG_BUILD_DIR)/localoptions.h + echo '#define DROPBEAR_DH_GROUP14_SHA1 $(if $(CONFIG_DROPBEAR_DH_GROUP14_SHA1),1,0)' >> \ + $(PKG_BUILD_DIR)/localoptions.h + + echo '#define DROPBEAR_DH_GROUP14_SHA256 $(if $(CONFIG_DROPBEAR_DH_GROUP14_SHA256),1,0)' >> \ + $(PKG_BUILD_DIR)/localoptions.h + + echo '#define DROPBEAR_CURVE25519 $(if $(CONFIG_DROPBEAR_CURVE25519),1,0)' >> \ + $(PKG_BUILD_DIR)/localoptions.h + # remove protocol idented software version number $(ESED) 's,^(#define LOCAL_IDENT) .*$$$$,\1 "SSH-2.0-dropbear",g' \ $(PKG_BUILD_DIR)/sysoptions.h