From patchwork Mon Oct 12 12:37:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Petr_=C5=A0tetiar?= X-Patchwork-Id: 1380887 X-Patchwork-Delegate: ynezz@true.cz Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.openwrt.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=true.cz Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=merlin.20170209 header.b=tvo/SaMt; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4C8ytG1Hn3z9sTs for ; Mon, 12 Oct 2020 23:39:34 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h5UFKg/5uUbMEN1QIFDJhzGM9ofrMLtH5tHHgZ65g3g=; b=tvo/SaMtyGVh6M6fBNiYk+JeX YRUnXaRmMOsUprOco2G6bP08Neut6mxubjVJS5krClVYQmMjxGGcFn1KoG7XMRYjhuxs2NOs9R452 lSWBb1gVkQ+5PG+dhAG5FrEXgNNQ3SDpB2nBYGAqI0gNqwFyyGcgtdfLE/+AEWRODvvFjqY4ITF0A ACYvHSIFLBQycyIjHFKiAN4JrLNMrcP4pyWCBeOSmxyYrglOCGEKCaBxf76NyhHcSsP8/WnX6E1sn qXHtbmY1xtXlwzYhkgq3UdomIB6g8ElKjEKrsdnSBPlS7zvvCHVzZqdpuc1tSUDKNx+Nsu/xFwlx+ k1+h71x9Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRx52-0002oQ-NZ; Mon, 12 Oct 2020 12:37:32 +0000 Received: from smtp-out.xnet.cz ([178.217.244.18]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRx4z-0002ly-B8 for openwrt-devel@lists.openwrt.org; Mon, 12 Oct 2020 12:37:30 +0000 Received: from meh.true.cz (meh.true.cz [108.61.167.218]) (Authenticated sender: petr@true.cz) by smtp-out.xnet.cz (Postfix) with ESMTPSA id BAB8A35DD; Mon, 12 Oct 2020 14:37:25 +0200 (CEST) Received: by meh.true.cz (OpenSMTPD) with ESMTP id 78d21945; Mon, 12 Oct 2020 14:37:09 +0200 (CEST) From: =?utf-8?q?Petr_=C5=A0tetiar?= To: openwrt-devel@lists.openwrt.org Subject: [PATCH cgi-io 03/12] Fix clang compiler errors Date: Mon, 12 Oct 2020 14:37:09 +0200 Message-Id: <20201012123718.25623-4-ynezz@true.cz> In-Reply-To: <20201012123718.25623-1-ynezz@true.cz> References: <20201012123718.25623-1-ynezz@true.cz> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201012_083729_568736_D35BD46D X-CRM114-Status: GOOD ( 16.25 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Petr_=C5=A0tetiar?= Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Fixes following errors as reported by clang compilers: cgi-io/src/main.c:723:12: error: unused variable 'post' [-Werror,-Wunused-variable] autochar *post = postdecode(fields, 4); ^ cgi-io/src/main.c:814:12: error: unused variable 'post' [-Werror,-Wunused-variable] autochar *post = postdecode(fields, 1); ^ cgi-io/src/main.c:996:12: error: unused variable 'post' [-Werror,-Wunused-variable] autochar *post = postdecode(fields, 4); Signed-off-by: Petr Štetiar --- main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/main.c b/main.c index 64f474f9283d..53c672836294 100644 --- a/main.c +++ b/main.c @@ -721,6 +721,7 @@ main_download(int argc, char **argv) int rfd; autochar *post = postdecode(fields, 4); + (void) post; if (!fields[1] || !session_access(fields[1], "cgi-io", "download", "read")) return failure(403, 0, "Download permission denied"); @@ -812,6 +813,7 @@ main_backup(int argc, char **argv) char *fields[] = { "sessionid", NULL }; autochar *post = postdecode(fields, 1); + (void) post; if (!fields[1] || !session_access(fields[1], "cgi-io", "backup", "read")) return failure(403, 0, "Backup permission denied"); @@ -999,6 +1001,7 @@ main_exec(int argc, char **argv) pid_t pid; autochar *post = postdecode(fields, 4); + (void) post; if (!fields[1] || !session_access(fields[1], "cgi-io", "exec", "read")) return failure(403, 0, "Exec permission denied");