diff mbox series

[cgi-io,02/12] Fix possible NULL dereference

Message ID 20201012123718.25623-3-ynezz@true.cz
State Accepted
Delegated to: Petr Štetiar
Headers show
Series fixes and improvements | expand

Commit Message

Petr Štetiar Oct. 12, 2020, 12:37 p.m. UTC 
Fixes following issue as reported by GCC-10 static analyzer:

 multipart_parser.c: In function ‘multipart_parser_init’:
 multipart_parser.c:88:22: error: dereference of possibly-NULL ‘p’ [CWE-690] [-Werror=analyzer-possible-null-dereference]

   88 |   p->boundary_length = strlen(boundary);
      |   ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
  ‘multipart_parser_init’: events 1-2
    |
    |   83 |   multipart_parser* p = malloc(sizeof(multipart_parser) +
    |      |   ^~~~~~~~~~~~~~~~
    |      |   |
    |      |   (1) this call could return NULL
    |......
    |   88 |   p->boundary_length = strlen(boundary);
    |      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    |      |                      |
    |      |                      (2) ‘p’ could be NULL: unchecked value from (1)

Signed-off-by: Petr Štetiar <ynezz@true.cz>
---
 multipart_parser.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series

Patch

diff --git a/multipart_parser.c b/multipart_parser.c
index ee82c82c8bfa..f1e1f38e1d71 100644
--- a/multipart_parser.c
+++ b/multipart_parser.c
@@ -84,6 +84,9 @@  multipart_parser* multipart_parser_init
                                strlen(boundary) +
                                strlen(boundary) + 9);
 
+  if (!p)
+	  return NULL;
+
   strcpy(p->multipart_boundary, boundary);
   p->boundary_length = strlen(boundary);