From patchwork Sun Sep 20 05:31:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosen Penev X-Patchwork-Id: 1367787 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.openwrt.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BvGTD381gz9sTH for ; Sun, 20 Sep 2020 15:33:52 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:To:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LbO30WVWSwIYtrzzDeqjKUycLFyBAB3DA5qM2lappwY=; b=ubNQVvEYiStaECxo10FsgeYhxE EbpwOyihDzC8tNiNYzoKtIvkPtxwwIoEdqcEOt+mtFgQmRXnOnTd4wAeCjxCET0LfHs9+nU16lzlF pUIOVtmIKSlNVUfUiPGVHC7kI1hjXW+s9hejlOZJW4wYLrshqgpWCe0lxtmvddz4hoP1r/+SLaCIh lyI1jxPUV5fOgvzVzGnr7DBbFD8LlNQA7FExOJ5DksKy3fZQbS7+Gc8mQME/hNMjhykwjQIDW3uoj 667nh+CY++x7Lqdf7ZufLuYwk/gAe7y61aLbX2feEt9eUmG24tRaNM3mbz/4wiU6PA6rK423J7i+e TZNFq7Ew==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJrx3-0004NE-6v; Sun, 20 Sep 2020 05:31:53 +0000 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJrww-0004Lh-Uu for openwrt-devel@lists.openwrt.org; Sun, 20 Sep 2020 05:31:48 +0000 Received: by mail-pj1-x102e.google.com with SMTP id s14so5649536pju.1 for ; Sat, 19 Sep 2020 22:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=h2d9aXO/DUnOtDT22fxM3vJJMaRukbTdYpEZkIff5QI=; b=jaXo48QeSjqGR3INeg2YjRDHIWXpuOZ0XPWTVpvMn9uP0lEJ+QXBjtcYnC967bADyf VMRseaW+wDhd9lE4n5fZZintCMTS2Lga/RVoTrQMYc4tMQPCBWcXA2/y6HWd/OCMGNvA f2Xu7ihA2qDwFQeCWISNxMycTbV8vDXnt+gYMnJw09CqV+QNeXdk6cz6et3mJnDhxb15 +fQ0w0yg3peJfCcXQsNQ3gQteJRjxiRZMK2ojMGnZZbqmUDcuMHIVZbxK9VRb2KttSAq nlyGnZ3xD1kZrX5wD8b2LYTlueEMlOzg97ZtnfcEDU4P0KNwA/roaRveuUjfdcv6d1B9 nmUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h2d9aXO/DUnOtDT22fxM3vJJMaRukbTdYpEZkIff5QI=; b=hSlqhufC5d/hmCcwNk5K1jC5FlB85dzG2IKoCMJBEZXOh4UZZ1HYTkt7Q/iv95Jt/J PjUMj88j69QQpm9Yum54lw4kzFtFaaDfDF4DPQ0x+WJ34NA8JdJzxl6mmfbAMRXrLGOn c55l0M6FNhFHmwlOW21gZshUjYghSrgQM30XvGX4y8ES8+/tFwPUu5Pzw9hLy0OfYZdd Towu/kslhtQajXTE1J+niLuCkqkhIfc8fldIXbNjmz4kfflzeA/VYf2ETjPb6uZ4Q9Bz /JMcK+r8L01fOwFOL33gKDCYJiYDRHiEYG86ASh6klImYUxONKDdF3iXKp4FBGPNNNGb 3tUw== X-Gm-Message-State: AOAM532pXNjcsZVxXiE4EmYNAVwZrDy7zJsxTFIhSWZB2ZqbM/RtbihR Kfw2g8SL7hd9XChgFm2TIVsmMZ7735QpWw== X-Google-Smtp-Source: ABdhPJxh0/GsblgXNfSlcv7fxVbDaIhxtAlXYApG0R8DFZ/U0K+rGQ1CnUpFAsk9RIwteJv9t4cb5w== X-Received: by 2002:a17:90a:2ecb:: with SMTP id h11mr18947300pjs.195.1600579904184; Sat, 19 Sep 2020 22:31:44 -0700 (PDT) Received: from mangix-trapnet.lan ([2001:470:1f05:79e::a89]) by smtp.gmail.com with ESMTPSA id 25sm8052450pfj.35.2020.09.19.22.31.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Sep 2020 22:31:43 -0700 (PDT) From: Rosen Penev To: openwrt-devel@lists.openwrt.org Subject: [PATCH 3/4] base-files/functions.sh: replace ^ with ! in [] Date: Sat, 19 Sep 2020 22:31:39 -0700 Message-Id: <20200920053140.35255-3-rosenp@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200920053140.35255-1-rosenp@gmail.com> References: <20200920053140.35255-1-rosenp@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200920_013146_994203_58D9A845 X-CRM114-Status: GOOD ( 13.31 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:102e listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [rosenp[at]gmail.com] -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Strictly speaking, ash does not support it. From https://wiki.ubuntu.com/DashAsBinSh#A.5B.5E.5D : Not to be confused by sed's and other program's regular expression syntax. Uses of [^] in case (parameter/word expansion in general) need to be replaced with [!]. Found with shellcheck: https://github.com/koalaman/shellcheck/wiki/SC2169 Signed-off-by: Rosen Penev --- package/base-files/files/lib/functions.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/base-files/files/lib/functions.sh b/package/base-files/files/lib/functions.sh index 0f56387244..a7ff50cb1a 100755 --- a/package/base-files/files/lib/functions.sh +++ b/package/base-files/files/lib/functions.sh @@ -108,7 +108,7 @@ config_unset() { # config_get