diff mbox series

build: Remove dependency of user space stack cookies from kernel

Message ID 20200717214939.19554-1-hauke@hauke-m.de
State Accepted
Delegated to: Hauke Mehrtens
Headers show
Series build: Remove dependency of user space stack cookies from kernel | expand

Commit Message

Hauke Mehrtens July 17, 2020, 9:49 p.m. UTC
Currently the user space stack cookies work well also when the kernel
stack cookies are not activated. This is handled completely in user
space and does not need kernel support.

This dependency was probably needed some years ago when the libc did not
support stack cookies.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
 config/Config-build.in | 2 --
 1 file changed, 2 deletions(-)

Comments

Ian Cooper July 19, 2020, 9:54 p.m. UTC | #1
On Fri, 17 Jul 2020 23:49:39 +0200 Hauke Mehrtens <hauke@hauke-m.de> wrote:

I've been using an identical patch for pushing two months already and
build and run tested on multiple different configurations.

This patch works fine.

> Currently the user space stack cookies work well also when the kernel
> stack cookies are not activated. This is handled completely in user
> space and does not need kernel support.
> 
> This dependency was probably needed some years ago when the libc did not
> support stack cookies.
> 
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Reviewed-by: Ian Cooper <iancooper@hotmail.com>
> ---
>  config/Config-build.in | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/config/Config-build.in b/config/Config-build.in
> index ac1e05d2ff49..199277167bf7 100644
> --- a/config/Config-build.in
> +++ b/config/Config-build.in
> @@ -256,10 +256,8 @@ menu "Global build settings"
>  			bool "None"
>  		config PKG_CC_STACKPROTECTOR_REGULAR
>  			bool "Regular"
> -			depends on KERNEL_CC_STACKPROTECTOR_REGULAR
>  		config PKG_CC_STACKPROTECTOR_STRONG
>  			bool "Strong"
> -			depends on KERNEL_CC_STACKPROTECTOR_STRONG
>  	endchoice
>  
>  	choice
diff mbox series

Patch

diff --git a/config/Config-build.in b/config/Config-build.in
index ac1e05d2ff49..199277167bf7 100644
--- a/config/Config-build.in
+++ b/config/Config-build.in
@@ -256,10 +256,8 @@  menu "Global build settings"
 			bool "None"
 		config PKG_CC_STACKPROTECTOR_REGULAR
 			bool "Regular"
-			depends on KERNEL_CC_STACKPROTECTOR_REGULAR
 		config PKG_CC_STACKPROTECTOR_STRONG
 			bool "Strong"
-			depends on KERNEL_CC_STACKPROTECTOR_STRONG
 	endchoice
 
 	choice