| Message ID | 20200708112742.6170-1-rsalvaterra@gmail.com |
|---|---|
| State | Not Applicable |
| Delegated to: | Petr Štetiar |
| Headers | show |
| Series | busybox: disable SUSv2 compatibility by default | expand |
What is the storage gain archived by changing this? On 08.07.20 01:27, Rui Salvaterra wrote: > The Single UNIX Specification, Version 3, came out on the 30th January 2002 [1]. > There's nothing in the OpenWrt userspace which needs support for legacy SUSv2 > compatibility. > > [1] http://www.unix.org/version3/pr.html > > Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com> > --- > package/utils/busybox/Config-defaults.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/utils/busybox/Config-defaults.in b/package/utils/busybox/Config-defaults.in > index 29724041f4..632a7fef45 100644 > --- a/package/utils/busybox/Config-defaults.in > +++ b/package/utils/busybox/Config-defaults.in > @@ -12,7 +12,7 @@ config BUSYBOX_DEFAULT_FEDORA_COMPAT > default n > config BUSYBOX_DEFAULT_INCLUDE_SUSv2 > bool > - default y > + default n > config BUSYBOX_DEFAULT_LONG_OPTS > bool > default y
On 08/07/2020 08:27, Rui Salvaterra wrote: > The Single UNIX Specification, Version 3, came out on the 30th January 2002 [1]. > There's nothing in the OpenWrt userspace which needs support for legacy SUSv2 > compatibility. As you found yourself ("head -1", "tail -1"...), this is hard to access, and it is going to introduce (sometimes subtle) bugs in scripts not just from openwrt upstream, but also downstream and users. Unless you're saving a very large amount of FLASH with this change, it *really* isn't worth it. Not even for the 4MiB targets. Please reconsider.
Hi, Henrique, On Thu, 9 Jul 2020 at 14:27, Henrique de Moraes Holschuh <henrique@nic.br> wrote: > > As you found yourself ("head -1", "tail -1"...), this is hard to access, > and it is going to introduce (sometimes subtle) bugs in scripts not just > from openwrt upstream, but also downstream and users. > > Unless you're saving a very large amount of FLASH with this change, it > *really* isn't worth it. Not even for the 4MiB targets. It's not worth it at all. On my config (-march=cortex-a9+neon -mthumb) the difference is exactly 0 bytes (yes, really). > Please reconsider. Already did, please drop this for good. Thanks, Rui
diff --git a/package/utils/busybox/Config-defaults.in b/package/utils/busybox/Config-defaults.in index 29724041f4..632a7fef45 100644 --- a/package/utils/busybox/Config-defaults.in +++ b/package/utils/busybox/Config-defaults.in @@ -12,7 +12,7 @@ config BUSYBOX_DEFAULT_FEDORA_COMPAT default n config BUSYBOX_DEFAULT_INCLUDE_SUSv2 bool - default y + default n config BUSYBOX_DEFAULT_LONG_OPTS bool default y
The Single UNIX Specification, Version 3, came out on the 30th January 2002 [1]. There's nothing in the OpenWrt userspace which needs support for legacy SUSv2 compatibility. [1] http://www.unix.org/version3/pr.html Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com> --- package/utils/busybox/Config-defaults.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)