diff mbox series

[OpenWrt-Devel,RFC] Revert "ramips: mt7621: disable image for mikrotik_rbm11g"

Message ID 20200407022721.249622-1-gch981213@gmail.com
State Superseded, archived
Delegated to: Chuanhong Guo
Headers show
Series [OpenWrt-Devel,RFC] Revert "ramips: mt7621: disable image for mikrotik_rbm11g" | expand

Commit Message

Chuanhong Guo April 7, 2020, 2:27 a.m. UTC
This reverts commit 838f1fbb50e91ebaf1d34f9666ae6b65eb49df5c.

It can be guessed from Mikrotik GPL kernel that this router uses port0.
And even if it doesn't, RBM11G has easy-to-use tftp recovery mechanism
for users to restore their firmware. Let's enable this image and see if
users complains.

Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
---
RFC: Should I do this?
If I don't do so, users will complain about missing image;
But if I do and brick users devices, users may also complain. That may
not be a big deal as users can recover their devices easily.
I have no idea what I should do at this moment.

It's even better if a developer with this device can spot this mail
and help testing the firmware :D

 target/linux/ramips/image/mt7621.mk | 1 -
 1 file changed, 1 deletion(-)

Comments

Adrian Schmutzler April 7, 2020, 8:20 a.m. UTC | #1
Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org]
> On Behalf Of Chuanhong Guo
> Sent: Dienstag, 7. April 2020 04:27
> To: openwrt-devel@lists.openwrt.org
> Cc: Chuanhong Guo <gch981213@gmail.com>
> Subject: [OpenWrt-Devel] [PATCH][RFC] Revert "ramips: mt7621: disable
> image for mikrotik_rbm11g"
> 
> This reverts commit 838f1fbb50e91ebaf1d34f9666ae6b65eb49df5c.
> 
> It can be guessed from Mikrotik GPL kernel that this router uses port0.
> And even if it doesn't, RBM11G has easy-to-use tftp recovery mechanism for
> users to restore their firmware. Let's enable this image and see if users
> complains.
> 
> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
> ---
> RFC: Should I do this?
> If I don't do so, users will complain about missing image; But if I do and brick
> users devices, users may also complain. That may not be a big deal as users
> can recover their devices easily.
> I have no idea what I should do at this moment.

IMO, if you have a chance for an educated guess, it's better to have the image available (just as you justified it in the actual commit message).
Due to the DSA introduction, users will have to do more conscious updates anyway.

Acked-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>

Best

Adrian

> 
> It's even better if a developer with this device can spot this mail and help
> testing the firmware :D
> 
>  target/linux/ramips/image/mt7621.mk | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target/linux/ramips/image/mt7621.mk
> b/target/linux/ramips/image/mt7621.mk
> index cdae42f3e4..a4484b408f 100644
> --- a/target/linux/ramips/image/mt7621.mk
> +++ b/target/linux/ramips/image/mt7621.mk
> @@ -497,7 +497,6 @@ TARGET_DEVICES += mikrotik_rb750gr3  define
> Device/mikrotik_rbm11g
>    $(Device/MikroTik)
>    DEVICE_MODEL := RouterBOARD M11G
> -  DEFAULT := n # disabled due to unknown port assignment  endef
> TARGET_DEVICES += mikrotik_rbm11g
> 
> --
> 2.25.1
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
diff mbox series

Patch

diff --git a/target/linux/ramips/image/mt7621.mk b/target/linux/ramips/image/mt7621.mk
index cdae42f3e4..a4484b408f 100644
--- a/target/linux/ramips/image/mt7621.mk
+++ b/target/linux/ramips/image/mt7621.mk
@@ -497,7 +497,6 @@  TARGET_DEVICES += mikrotik_rb750gr3
 define Device/mikrotik_rbm11g
   $(Device/MikroTik)
   DEVICE_MODEL := RouterBOARD M11G
-  DEFAULT := n # disabled due to unknown port assignment
 endef
 TARGET_DEVICES += mikrotik_rbm11g