diff mbox series

[OpenWrt-Devel] ar71xx & ath79: ew-dorin, fix the trigger level for WPS button

Message ID 20200311091000.22103-1-cc@80211.de
State Accepted
Delegated to: John Crispin
Headers show
Series [OpenWrt-Devel] ar71xx & ath79: ew-dorin, fix the trigger level for WPS button | expand

Commit Message

Catrinel Catrinescu March 11, 2020, 9:10 a.m. UTC
From: Catrinel Catrinescu <cc@80211.de>

Because the WPS button had the wrong trigger level,
the failsafe mode was triggered quite often,
after this commit:
https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=27f3f493de


Signed-off-by: Catrinel Catrinescu <cc@80211.de>
---
 target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c | 2 +-
 target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Adrian Schmutzler March 11, 2020, 10:54 a.m. UTC | #1
Hi,

please split this into separate commits for ar71xx and ath79.

Best

adrian

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org] On
> Behalf Of cc@80211.de
> Sent: Mittwoch, 11. März 2020 10:10
> To: openwrt-devel@lists.openwrt.org
> Cc: Catrinel Catrinescu <cc@80211.de>
> Subject: [OpenWrt-Devel] [PATCH] ar71xx & ath79: ew-dorin, fix the trigger
level
> for WPS button
> 
> From: Catrinel Catrinescu <cc@80211.de>
> 
> Because the WPS button had the wrong trigger level,
> the failsafe mode was triggered quite often,
> after this commit:
> https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=27f3f493de
> 
> 
> Signed-off-by: Catrinel Catrinescu <cc@80211.de>
> ---
>  target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c | 2 +-
>  target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c
> b/target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c
> index 575a976aec..5544596f91 100644
> --- a/target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c
> +++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c
> @@ -47,7 +47,7 @@ static struct gpio_keys_button dorin_gpio_keys[] __initdata
> = {
>  		.code		= KEY_WPS_BUTTON,
>  		.debounce_interval = DORIN_KEYS_DEBOUNCE_INTERVAL,
>  		.gpio		= DORIN_GPIO_BTN_JUMPSTART,
> -		.active_low	= 1,
> +		.active_low	= 0,
>  	},
>  	{
>  		.desc		= "reset button",
> diff --git a/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts
> b/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts
> index d0e0169f1b..88b48faf89 100644
> --- a/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts
> +++ b/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts
> @@ -34,7 +34,7 @@
>  		wps {
>  			label = "wps";
>  			linux,code = <KEY_WPS_BUTTON>;
> -			gpios = <&gpio 11 GPIO_ACTIVE_LOW>;
> +			gpios = <&gpio 11 GPIO_ACTIVE_HIGH>;
>  		};
> 
>  		reset {
> --
> 2.17.1
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Petr Štetiar March 11, 2020, 11:18 a.m. UTC | #2
Adrian Schmutzler <mail@adrianschmutzler.de> [2020-03-11 11:54:50]:

> please split this into separate commits for ar71xx and ath79.

FYI it was already pushed.

-- ynezz
diff mbox series

Patch

diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c b/target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c
index 575a976aec..5544596f91 100644
--- a/target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c
+++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-ew-dorin.c
@@ -47,7 +47,7 @@  static struct gpio_keys_button dorin_gpio_keys[] __initdata = {
 		.code		= KEY_WPS_BUTTON,
 		.debounce_interval = DORIN_KEYS_DEBOUNCE_INTERVAL,
 		.gpio		= DORIN_GPIO_BTN_JUMPSTART,
-		.active_low	= 1,
+		.active_low	= 0,
 	},
 	{
 		.desc		= "reset button",
diff --git a/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts b/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts
index d0e0169f1b..88b48faf89 100644
--- a/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts
+++ b/target/linux/ath79/dts/ar9331_embeddedwireless_dorin.dts
@@ -34,7 +34,7 @@ 
 		wps {
 			label = "wps";
 			linux,code = <KEY_WPS_BUTTON>;
-			gpios = <&gpio 11 GPIO_ACTIVE_LOW>;
+			gpios = <&gpio 11 GPIO_ACTIVE_HIGH>;
 		};
 
 		reset {