diff mbox series

[OpenWrt-Devel,4/4] scripts/clean-package.sh: Switch from -a in if to &&

Message ID 20191230034827.22185-4-rosenp@gmail.com
State Changes Requested
Delegated to: Petr Štetiar
Headers show
Series [OpenWrt-Devel,1/4] scripts/clean-package.sh: exit in case cd fails | expand

Commit Message

Rosen Penev Dec. 30, 2019, 3:48 a.m. UTC 
-a is not well defined.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 scripts/clean-package.sh | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
diff mbox series

Patch

diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh
index b64d7ad21a..2c9d4169ba 100755
--- a/scripts/clean-package.sh
+++ b/scripts/clean-package.sh
@@ -1,13 +1,14 @@ 
 #!/usr/bin/env bash
 IFS=$'\n'
-[ -n "$1" -a -n "$2" ] || {
+
+if [ -z "$1" ] || [ -z "$2" ]; then
 	echo "Usage: $0 <file> <directory>"
 	exit 1
-}
-[ -f "$1" -a -d "$2" ] || {
+fi
+if [ ! -f "$1" ] || [ ! -d "$2" ]; then
 	echo "File/directory not found"
 	exit 1
-}
+fi
 (
 	cd "$2" || exit 1
 	while read -r entry; do