From patchwork Thu Dec 19 22:04:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Petr_=C5=A0tetiar?= X-Patchwork-Id: 1213749 X-Patchwork-Delegate: ynezz@true.cz Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=true.cz Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Oo8VBY8K"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47f5Yy1JrVz9sPL for ; Fri, 20 Dec 2019 09:06:30 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:MIME-Version:References: In-Reply-To:Message-Id:Date:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6JJQmr6hVZRBBglRzm7KK/rzlRUjhPp7zI8UoGqCgmU=; b=Oo8VBY8KowBg3U 6D4hoCq32d3fK0rTJE1gr1bzXBE4ZYRNcMYtKTUj3VyoIbX2CRgpJ3Sl0O5W0nWcQRW3PEBuaMOtq +uB86o//fFLPnEC6aiY1XpNLZfeK4+FUle3fzc6zkYpSDwGHROZ5DFhEEmoTcMBsGCVqwxgeVRIAF dvRca8m6NDBhZo7vpeVBGKbfJr5qjrhHimWVmG88PYVXxnzhEBmnrq90KK4lY4o3uuB7I4785EEWB l9t5Gj3BjRH18jYusemx8qHMYqBis3sY27eg0Oxc9+PuZLzDzpZxiTtz6i202Loqkwc/QAwoKj+3P /IxyV/7ld027tXDFpQxA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ii3wB-0000HZ-Nq; Thu, 19 Dec 2019 22:06:27 +0000 Received: from smtp-out.xnet.cz ([178.217.244.18]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ii3uL-0003gj-Gg for openwrt-devel@lists.openwrt.org; Thu, 19 Dec 2019 22:04:41 +0000 Received: from meh.true.cz (meh.true.cz [108.61.167.218]) (Authenticated sender: petr@true.cz) by smtp-out.xnet.cz (Postfix) with ESMTPSA id 035574B97; Thu, 19 Dec 2019 23:04:30 +0100 (CET) Received: by meh.true.cz (OpenSMTPD) with ESMTP id 75dda45c; Thu, 19 Dec 2019 23:04:21 +0100 (CET) From: =?utf-8?q?Petr_=C5=A0tetiar?= To: openwrt-devel@lists.openwrt.org Date: Thu, 19 Dec 2019 23:04:19 +0100 Message-Id: <20191219220421.22206-8-ynezz@true.cz> In-Reply-To: <20191219220421.22206-1-ynezz@true.cz> References: <20191219220421.22206-1-ynezz@true.cz> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191219_140433_879554_2BAE4E63 X-CRM114-Status: UNSURE ( 8.97 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [178.217.244.18 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record Subject: [OpenWrt-Devel] [PATCH ucert 7/9] fix possibly garbage value returned in cert_process_revoker X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Petr_=C5=A0tetiar?= Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Fixes following warning reported by clang-9 scan-build analyzer: ucert.c:585:2: warning: Undefined or garbage value returned to caller return ret; ^~~~~~~~~~ Signed-off-by: Petr Štetiar --- ucert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ucert.c b/ucert.c index 8503eeb26cd8..b9c5c889ddfa 100644 --- a/ucert.c +++ b/ucert.c @@ -508,7 +508,7 @@ static int cert_process_revoker(const char *certfile, const char *pubkeydir) { char *fingerprint; char rfname[512]; - int ret; + int ret = -1; if (cert_load(certfile, &certchain)) { DPRINTF("cannot parse cert\n");