diff mbox series

[OpenWrt-Devel,v2,libubox,09/10] blobmsg_json: fix possible uninitialized struct member

Message ID 20191120214353.27652-10-ynezz@true.cz
State Accepted
Delegated to: Petr Štetiar
Headers show
Series fixes, unit tests and GitLab CI | expand

Commit Message

Petr Štetiar Nov. 20, 2019, 9:43 p.m. UTC 
clang-10 analyzer reports following:

 blobmsg_json.c:285:2: warning: The expression is an uninitialized value. The computed value will also be garbage
         s->indent_level++;
         ^~~~~~~~~~~~~~~~~

Signed-off-by: Petr Štetiar <ynezz@true.cz>
---
 blobmsg_json.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/blobmsg_json.c b/blobmsg_json.c
index a5980e8a2b62..18592111b4dd 100644
--- a/blobmsg_json.c
+++ b/blobmsg_json.c
@@ -315,7 +315,7 @@  static void setup_strbuf(struct strbuf *s, struct blob_attr *attr, blobmsg_json_
 
 char *blobmsg_format_json_with_cb(struct blob_attr *attr, bool list, blobmsg_json_format_t cb, void *priv, int indent)
 {
-	struct strbuf s;
+	struct strbuf s = {0};
 	bool array;
 	char *ret;
 
@@ -349,7 +349,7 @@  char *blobmsg_format_json_with_cb(struct blob_attr *attr, bool list, blobmsg_jso
 
 char *blobmsg_format_json_value_with_cb(struct blob_attr *attr, blobmsg_json_format_t cb, void *priv, int indent)
 {
-	struct strbuf s;
+	struct strbuf s = {0};
 	char *ret;
 
 	setup_strbuf(&s, attr, cb, priv, indent);