| Message ID | 20191105232348.4710-1-ynezz@true.cz |
|---|---|
| State | Accepted |
| Delegated to: | Petr Štetiar |
| Headers | show |
| Series | [OpenWrt-Devel] build: image: fix build breakage of some images | expand |
Thanks for debugging this! On 11/5/19 1:23 PM, Petr Štetiar wrote: > Commit 881ed09ee6e2 ("build: create JSON files containing image info") > has removed the crucial empty new line from the image copy step > resulting in the following errors during make function expansion: > > GZ_SUFFIX := > bash: GZ_SUFFIX: command not found > Makefile:86: recipe for target 'openwrt-ath79-generic-tplink_archer-c7-v5-squashfs-sysupgrade.bin' failed > > Fixes: 881ed09ee6e2 ("build: create JSON files containing image info") > Signed-off-by: Petr Štetiar <ynezz@true.cz> > --- > include/image.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/image.mk b/include/image.mk > index 940ae812ea95..77d456719711 100644 > --- a/include/image.mk > +++ b/include/image.mk > @@ -597,6 +597,7 @@ define Device/Build/image > SUPPORTED_DEVICES="$(SUPPORTED_DEVICES)" \ > $(TOPDIR)/scripts/json_add_image_info.py \ > ) > + > endef > > define Device/Build/artifact > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
diff --git a/include/image.mk b/include/image.mk index 940ae812ea95..77d456719711 100644 --- a/include/image.mk +++ b/include/image.mk @@ -597,6 +597,7 @@ define Device/Build/image SUPPORTED_DEVICES="$(SUPPORTED_DEVICES)" \ $(TOPDIR)/scripts/json_add_image_info.py \ ) + endef define Device/Build/artifact
Commit 881ed09ee6e2 ("build: create JSON files containing image info") has removed the crucial empty new line from the image copy step resulting in the following errors during make function expansion: GZ_SUFFIX := bash: GZ_SUFFIX: command not found Makefile:86: recipe for target 'openwrt-ath79-generic-tplink_archer-c7-v5-squashfs-sysupgrade.bin' failed Fixes: 881ed09ee6e2 ("build: create JSON files containing image info") Signed-off-by: Petr Štetiar <ynezz@true.cz> --- include/image.mk | 1 + 1 file changed, 1 insertion(+)