Message ID | 20191105003657.16540-17-ynezz@true.cz |
---|---|
State | Accepted |
Delegated to: | Petr Štetiar |
Headers | show
Return-Path: <openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=true.cz Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GfnJFTky"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 476W7420B1z9sNT for <incoming@patchwork.ozlabs.org>; Tue, 5 Nov 2019 11:41:04 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:MIME-Version:References: In-Reply-To:Message-Id:Date:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3OPtnRGSDUoT3qru+z9xOGrcg4WzZcY7or1+v6DKbPA=; b=GfnJFTkyY5AHwd hHJAhepfH7ppgurdYXd3uiGRtbIyoN+4bpgACxOgcBGa8bB0NnZqmVv95hz3kSwedM/bOmGkgffxj QH13mkQPYDft1vaBv5YVpsaubEZXs7vUqakapUhbkDM7gkVqBVr6ItvjuvCLjaxfQdh5Z30T4xmgx uTOQSfWwCotqN7kdO4DJe9nOlN+R0sUOEUvEZvmWwHliY3NDVdH+VfAQ+CwPDm0UGgTxSODb/smlO 8XCuUbwfu96y95eQEeYIIjaCc4ZijJdh/uG3RinGCiBmWSbwbPqSMdJeB00omoUik9hJWEWJ1ecYg iGOjF3nqf5CbOc68FTxg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRmtv-0005UI-B6; Tue, 05 Nov 2019 00:40:51 +0000 Received: from smtp-out.xnet.cz ([178.217.244.18]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRmqR-0008AC-JR for openwrt-devel@lists.openwrt.org; Tue, 05 Nov 2019 00:37:18 +0000 Received: from meh.true.cz (meh.true.cz [108.61.167.218]) (Authenticated sender: petr@true.cz) by smtp-out.xnet.cz (Postfix) with ESMTPSA id D213D4D8C; Tue, 5 Nov 2019 01:37:13 +0100 (CET) Received: by meh.true.cz (OpenSMTPD) with ESMTP id ffbe3675; Tue, 5 Nov 2019 01:37:04 +0100 (CET) From: =?utf-8?q?Petr_=C5=A0tetiar?= <ynezz@true.cz> To: openwrt-devel@lists.openwrt.org Date: Tue, 5 Nov 2019 01:36:55 +0100 Message-Id: <20191105003657.16540-17-ynezz@true.cz> In-Reply-To: <20191105003657.16540-1-ynezz@true.cz> References: <20191105003657.16540-1-ynezz@true.cz> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191104_163715_814251_A75BDF76 X-CRM114-Status: UNSURE ( 8.81 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [178.217.244.18 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record Subject: [OpenWrt-Devel] [PATCH uci 16/18] delta: prevent possible null pointer use X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <openwrt-devel.lists.openwrt.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/openwrt-devel>, <mailto:openwrt-devel-request@lists.openwrt.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/openwrt-devel/> List-Post: <mailto:openwrt-devel@lists.openwrt.org> List-Help: <mailto:openwrt-devel-request@lists.openwrt.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/openwrt-devel>, <mailto:openwrt-devel-request@lists.openwrt.org?subject=subscribe> Cc: =?utf-8?q?Petr_=C5=A0tetiar?= <ynezz@true.cz> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "openwrt-devel" <openwrt-devel-bounces@lists.openwrt.org> Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org |
Series |
fixes and improvements
|
expand
|
diff --git a/delta.c b/delta.c index 97bdd29d3005..228a328c21a1 100644 --- a/delta.c +++ b/delta.c @@ -392,7 +392,7 @@ static void uci_filter_delta(struct uci_context *ctx, const char *name, const ch match = false; } - if (!match) { + if (!match && ptr.section) { uci_add_delta(ctx, &list, c, ptr.section, ptr.option, ptr.value); }
scan-build from clang version 9 has reported following issue: delta.c:39:13: warning: Null pointer passed to 1st parameter expecting 'nonnull' int size = strlen(section) + 1; ^~~~~~~~~~~~~~~ Signed-off-by: Petr Štetiar <ynezz@true.cz> --- delta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)