| Message ID | 20190903162450.740-1-karlp@etactica.com |
|---|---|
| State | Superseded |
| Delegated to: | David Bauer |
| Headers | show |
| Series | [OpenWrt-Devel] ath79: eg200: enable status led usage | expand |
Karl Pálsson <karlp@etactica.com> wrote: > > Signed-off-by: Karl Palsson <karlp@etactica.com> > --- It's minor, but if someone picks this, please _don't_ change my SoB to match the email. The original source commits and all git config names are unaccented, and it's how I use my name, it's just the office365 mail server that is "mangling" my name, and it's not to be trusted. (ref: https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=075c570cde08c2a27f7e2a64995cc74ae52b5704 where it actually was "matched SoB to email" unlike the comment) Sincerely, Karl Palsson
Hello Karl, On 9/3/19 6:57 PM, Karl Palsson wrote: > > > Karl Pálsson <karlp@etactica.com> wrote: >> >> Signed-off-by: Karl Palsson <karlp@etactica.com> >> --- > > It's minor, but if someone picks this, please _don't_ change my > SoB to match the email. The original source commits and all git > config names are unaccented, and it's how I use my name, it's > just the office365 mail server that is "mangling" my name, and > it's not to be trusted. (ref: > https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=075c570cde08c2a27f7e2a64995cc74ae52b5704 > where it actually was "matched SoB to email" unlike the comment) Git won't let me push to master without a on-matching SoB. $ git push upstream upstream-master:master Enumerating objects: 21, done. Counting objects: 100% (21/21), done. Delta compression using up to 4 threads Compressing objects: 100% (11/11), done. Writing objects: 100% (11/11), 1.20 KiB | 616.00 KiB/s, done. Total 11 (delta 7), reused 0 (delta 0) remote: No matching SoB line found for author Karl Pálsson <karlp@etactica.com> remote: in commit a155a153e0949aefd9147061f9a00a0d91d4400a remote: To git.openwrt.org:openwrt/openwrt.git ! [remote rejected] upstream-master -> master (pre-receive hook declined) error: failed to push some refs to 'git@git.openwrt.org:openwrt/openwrt.git' Best wishes David
David Bauer <mail@david-bauer.net> wrote: > > Git won't let me push to master without a on-matching SoB. > > $ git push upstream upstream-master:master > Enumerating objects: 21, done. > Counting objects: 100% (21/21), done. > Delta compression using up to 4 threads > Compressing objects: 100% (11/11), done. > Writing objects: 100% (11/11), 1.20 KiB | 616.00 KiB/s, done. > Total 11 (delta 7), reused 0 (delta 0) remote: No matching SoB > line found for author Karl Pálsson <karlp@etactica.com> remote: > in commit a155a153e0949aefd9147061f9a00a0d91d4400a remote: To > git.openwrt.org:openwrt/openwrt.git > ! [remote rejected] upstream-master -> master (pre-receive hook declined) > error: failed to push some refs to > 'git@git.openwrt.org:openwrt/openwrt.git' Thanks for trying. I'll have to find another mail server to send through. It was previously sending through my private mail server, but that wasn't really appropriate for mail being sent for work. I've then finally managed to get git-send-email to work via the work email server, but get this sort of problem. The commits themselves _do_ have the author. I've just been suggested a method of adding a second From: field to the annotated patch when sending, which may help, otherwise I'll revert to the (clearly second tier) method of sending PRs via github, where the actual git commits are preserved, instead of whatever the world of mail decides to mangle and rewrite on the way. Sincerely, Karl Palsson
diff --git a/target/linux/ath79/base-files/etc/board.d/01_leds b/target/linux/ath79/base-files/etc/board.d/01_leds index ced8a94fd0..e317ce26e1 100755 --- a/target/linux/ath79/base-files/etc/board.d/01_leds +++ b/target/linux/ath79/base-files/etc/board.d/01_leds @@ -87,7 +87,6 @@ engenius,ews511ap) etactica,eg200) ucidef_set_led_netdev "lan" "LAN" "$boardname:red:eth0" "eth0" ucidef_set_led_oneshot "modbus" "Modbus" "$boardname:red:modbus" "100" "33" - ucidef_set_led_default "etactica" "etactica" "$boardname:red:etactica" "ignore" ;; glinet,gl-ar150) ucidef_set_led_netdev "wan" "WAN" "$boardname:green:wan" "eth1" diff --git a/target/linux/ath79/dts/ar9331_etactica_eg200.dts b/target/linux/ath79/dts/ar9331_etactica_eg200.dts index 708e9defa4..9160aa2b2e 100644 --- a/target/linux/ath79/dts/ar9331_etactica_eg200.dts +++ b/target/linux/ath79/dts/ar9331_etactica_eg200.dts @@ -11,6 +11,9 @@ compatible = "etactica,eg200", "qca,ar9331"; aliases { + led-boot = &led_etactica; + led-failsafe = &led_etactica; + led-upgrade = &led_etactica; serial0 = &uart; }; @@ -34,7 +37,7 @@ gpios = <&gpio 16 GPIO_ACTIVE_HIGH>; }; - etactica { + led_etactica: etactica { label = "eg200:red:etactica"; gpios = <&gpio 15 GPIO_ACTIVE_HIGH>; };
This enables using the "eTactica" LED during boot, to indicate failsafe, and during upgrade, while still leaving the LED alone for normal operation. This brings the device more in line with how other devices work, and makes the failsafe functionality easier to use and understand. Signed-off-by: Karl Palsson <karlp@etactica.com> --- target/linux/ath79/base-files/etc/board.d/01_leds | 1 - target/linux/ath79/dts/ar9331_etactica_eg200.dts | 5 ++++- 2 files changed, 4 insertions(+), 2 deletions(-)