| Message ID | 20190803151356.18733-3-arnysch@gmx.net |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | asterisk16-chan-lantiq: Two independent patches | expand |
On Sat, Aug 03, 2019 at 05:13:56PM +0200, Arnold Schulz wrote: > This is now the same behaviour as used by the external asterisk > packages asterisk-chan-dongle and asterisk-chan-sccp. > > Signed-off-by: Arnold Schulz <arnysch@gmx.net> > --- > net/asterisk-16.x-chan-lantiq/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/asterisk-16.x-chan-lantiq/Makefile b/net/asterisk-16.x-chan-lantiq/Makefile > index 8210c07..55c1c35 100644 > --- a/net/asterisk-16.x-chan-lantiq/Makefile > +++ b/net/asterisk-16.x-chan-lantiq/Makefile > @@ -27,12 +27,12 @@ PKG_FLAGS:=nonshared > include $(INCLUDE_DIR)/package.mk > > define Package/$(PKG_NAME) > - SUBMENU:=Telephony Lantiq > + SUBMENU:=Telephony > SECTION:=net > CATEGORY:=Network > TITLE:=Lantiq channel driver > URL:=https://github.com/kochstefan/asterisk_channel_lantiq > - DEPENDS:=+asterisk16 +kmod-ltq-vmmc > + DEPENDS:=asterisk16 +kmod-ltq-vmmc > endef Hi Arnold, Please see commit 8dd77211e025709bef36d4994fcf08ccc9107422. With your patch chan-lantiq would again not be built by the buildbots. I know that the extra submenu isn't nice. But we need the '+asterisk' dep for the build bots to build the package. And when you stick chan-lantiq into the Telephony submenu with its depend '+asterisk' then menuconfig looks even stranger. NACK from me. Kind regards, Seb > > define Package/$(PKG_NAME)/description > -- > 2.20.1
diff --git a/net/asterisk-16.x-chan-lantiq/Makefile b/net/asterisk-16.x-chan-lantiq/Makefile index 8210c07..55c1c35 100644 --- a/net/asterisk-16.x-chan-lantiq/Makefile +++ b/net/asterisk-16.x-chan-lantiq/Makefile @@ -27,12 +27,12 @@ PKG_FLAGS:=nonshared include $(INCLUDE_DIR)/package.mk define Package/$(PKG_NAME) - SUBMENU:=Telephony Lantiq + SUBMENU:=Telephony SECTION:=net CATEGORY:=Network TITLE:=Lantiq channel driver URL:=https://github.com/kochstefan/asterisk_channel_lantiq - DEPENDS:=+asterisk16 +kmod-ltq-vmmc + DEPENDS:=asterisk16 +kmod-ltq-vmmc endef define Package/$(PKG_NAME)/description
This is now the same behaviour as used by the external asterisk packages asterisk-chan-dongle and asterisk-chan-sccp. Signed-off-by: Arnold Schulz <arnysch@gmx.net> --- net/asterisk-16.x-chan-lantiq/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.20.1