| Message ID | 20190724134035.3066-1-freifunk@adrianschmutzler.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [OpenWrt-Devel] octeon: Replace backticks by $(...) | expand |
Adrian Schmutzler <freifunk@adrianschmutzler.de> [2019-07-24 15:40:35]: You've forget to provide commit description/message in all your patches, usually answer to "Why do you need this changes?" or "Why are you proposing this changes?" > Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> > --- > target/linux/octeon/base-files/lib/upgrade/platform.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/linux/octeon/base-files/lib/upgrade/platform.sh b/target/linux/octeon/base-files/lib/upgrade/platform.sh > index 0e4ca37629..5d1a53a196 100755 > --- a/target/linux/octeon/base-files/lib/upgrade/platform.sh > +++ b/target/linux/octeon/base-files/lib/upgrade/platform.sh > @@ -85,8 +85,8 @@ platform_check_image() { > er | \ > erlite) > local tar_file="$1" > - local kernel_length=`(tar xf $tar_file sysupgrade-$board/kernel -O | wc -c) 2> /dev/null` > - local rootfs_length=`(tar xf $tar_file sysupgrade-$board/root -O | wc -c) 2> /dev/null` > + local kernel_length=$(tar xf $tar_file sysupgrade-$board/kernel -O | wc -c 2> /dev/null) > + local rootfs_length=$(tar xf $tar_file sysupgrade-$board/root -O | wc -c 2> /dev/null) BTW, this looks more then backticks replacement, but also subshell removal. -- ynezz
diff --git a/target/linux/octeon/base-files/lib/upgrade/platform.sh b/target/linux/octeon/base-files/lib/upgrade/platform.sh index 0e4ca37629..5d1a53a196 100755 --- a/target/linux/octeon/base-files/lib/upgrade/platform.sh +++ b/target/linux/octeon/base-files/lib/upgrade/platform.sh @@ -85,8 +85,8 @@ platform_check_image() { er | \ erlite) local tar_file="$1" - local kernel_length=`(tar xf $tar_file sysupgrade-$board/kernel -O | wc -c) 2> /dev/null` - local rootfs_length=`(tar xf $tar_file sysupgrade-$board/root -O | wc -c) 2> /dev/null` + local kernel_length=$(tar xf $tar_file sysupgrade-$board/kernel -O | wc -c 2> /dev/null) + local rootfs_length=$(tar xf $tar_file sysupgrade-$board/root -O | wc -c 2> /dev/null) [ "$kernel_length" = 0 -o "$rootfs_length" = 0 ] && { echo "The upgrade image is corrupt." return 1
Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> --- target/linux/octeon/base-files/lib/upgrade/platform.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)