diff mbox series

[OpenWrt-Devel] mxs: disable unused serial drivers

Message ID 20190309084435.10111-1-mhei@heimpold.de
State Accepted, archived
Delegated to: Zoltan HERPAI
Headers show
Series [OpenWrt-Devel] mxs: disable unused serial drivers | expand

Commit Message

Michael Heimpold March 9, 2019, 8:44 a.m. UTC
This disables PL010 and 8250 serial support for this platform
as both drivers are not used: the debug UART is PL011 and the
application UARTs use a dedicated MXS specific driver.

The kernel size reduction is neglectable, but it also removes
the non-working (confusing) /dev/ttyS0 and /dev/ttyS1 devices
in a running system (which generate errors when trying to use):

  root@OpenWrt:~# echo "hello world" > /dev/ttyS0
  ash: write error: I/O error
  root@OpenWrt:~#

Signed-off-by: Michael Heimpold <mhei@heimpold.de>
---
 target/linux/mxs/config-4.14 | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Zoltan HERPAI March 11, 2019, 8:52 p.m. UTC | #1
Michael Heimpold wrote:
> This disables PL010 and 8250 serial support for this platform
> as both drivers are not used: the debug UART is PL011 and the
> application UARTs use a dedicated MXS specific driver.
>
> The kernel size reduction is neglectable, but it also removes
> the non-working (confusing) /dev/ttyS0 and /dev/ttyS1 devices
> in a running system (which generate errors when trying to use):
>
>   root@OpenWrt:~# echo "hello world" > /dev/ttyS0
>   ash: write error: I/O error
>   root@OpenWrt:~#
>
> Signed-off-by: Michael Heimpold <mhei@heimpold.de>
>   
Thanks Michael, I've checked this on an iMX233-Olinuxino-Maxi, patch was 
applied to master.

Thanks,
Zoltan H
diff mbox series

Patch

diff --git a/target/linux/mxs/config-4.14 b/target/linux/mxs/config-4.14
index 43d6a59bae..abad1807cd 100644
--- a/target/linux/mxs/config-4.14
+++ b/target/linux/mxs/config-4.14
@@ -262,9 +262,7 @@  CONFIG_RTC_MC146818_LIB=y
 CONFIG_RWSEM_XCHGADD_ALGORITHM=y
 # CONFIG_SCHED_INFO is not set
 # CONFIG_SCSI_DMA is not set
-CONFIG_SERIAL_8250_FSL=y
-CONFIG_SERIAL_AMBA_PL010=y
-CONFIG_SERIAL_AMBA_PL010_CONSOLE=y
+# CONFIG_SERIAL_8250 is not set
 CONFIG_SERIAL_AMBA_PL011=y
 CONFIG_SERIAL_AMBA_PL011_CONSOLE=y
 CONFIG_SERIAL_MCTRL_GPIO=y